Unity 8

Merge lp:~aacid/unity8/removeMouseClick55 into lp:unity8

Proposed by Albert Astals Cid on 2015-01-12

Status:	Merged
Approved by:	Michał Sawicz on 2015-01-12
Approved revision:	1545
Merged at revision:	1549
Proposed branch:	lp:~aacid/unity8/removeMouseClick55
Merge into:	lp:unity8
Diff against target:	35 lines (+4/-0) 1 file modified tests/utils/modules/Unity/Test/UnityTestCase.qml (+4/-0)
To merge this branch:	bzr merge lp:~aacid/unity8/removeMouseClick55
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michał Sawicz		2015-01-12	Approve on 2015-01-12
Review via email: mp+246094@code.launchpad.net

Tests: Add Qt 5.5 removal TODOs

* Are there any related MPs required for this MP to build/function as expected?
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
No, it's just some todos for the future

* Did you make sure that your branch does not contain spurious tags?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

* If you changed the UI, has there been a design review?
N/A

Michał Sawicz (saviq) wrote on 2015-01-12:

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'tests/utils/modules/Unity/Test/UnityTestCase.qml'
2	--- tests/utils/modules/Unity/Test/UnityTestCase.qml 2015-01-09 10:42:42 +0000
3	+++ tests/utils/modules/Unity/Test/UnityTestCase.qml 2015-01-12 08:49:15 +0000
4	@@ -37,6 +37,7 @@
5	this.getCurrentTimeMs = function() {return this.currentTimeMs}
6	}
7
8	+ // TODO This function can be removed altogether once we use Qt 5.5 which has the same feature
9	function mouseClick(item, x, y, button, modifiers, delay) {
10	if (button === undefined)
11	button = Qt.LeftButton;
12	@@ -52,6 +53,7 @@
13	qtest_fail("window not shown", 2);
14	}
15
16	+ // TODO This function can be removed altogether once we use Qt 5.5 which has the same feature
17	function mouseDoubleClick(item, x, y, button, modifiers, delay) {
18	if (button === undefined)
19	button = Qt.LeftButton;
20	@@ -67,6 +69,7 @@
21	qtest_fail("window not shown", 2)
22	}
23
24	+ // TODO This function can be removed altogether once we use Qt 5.5 which has the same feature
25	function mousePress(item, x, y, button, modifiers, delay) {
26	if (button === undefined)
27	button = Qt.LeftButton;
28	@@ -82,6 +85,7 @@
29	qtest_fail("window not shown", 2)
30	}
31
32	+ // TODO This function can be removed altogether once we use Qt 5.5 which has the same feature
33	function mouseRelease(item, x, y, button, modifiers, delay) {
34	if (button === undefined)
35	button = Qt.LeftButton;