Code review comment for lp:~aacid/unity8/rangeinput_filter

Andrea Cimitan (cimi) wrote :

> > This seems to simplify a bit the code in the filter
> > http://paste.ubuntu.com/15327313/
>
> But that breaks the alignment of things, in make tryFilterRangeInput the
> distance between "Post1" "to" and "Post2" is 50px with my branch, with your
> branch "Post1" and "to" is 57px while "to" and "Post2" is 50px, so things look
> uncentered.
Spent some time this morning trying to fix that, but QML Layouts don't seem to work for me today :) They do weird things :)

one last thing: we need to add the tests for the mapping of those components in FilterWidgetFactory (and for valueslider iirc)

review: Needs Fixing

« Back to merge proposal