Merge lp:~aacid/unity8/qt55 into lp:unity8
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | MichaĆ Sawicz on 2015-04-13 | ||||
| Approved revision: | 1700 | ||||
| Merged at revision: | 1734 | ||||
| Proposed branch: | lp:~aacid/unity8/qt55 | ||||
| Merge into: | lp:unity8 | ||||
| Diff against target: |
49 lines (+5/-1) 4 files modified
plugins/Greeter/Unity/Launcher/CMakeLists.txt (+1/-0) plugins/Unity/Launcher/CMakeLists.txt (+1/-0) tests/mocks/Unity/Launcher/CMakeLists.txt (+1/-0) tests/mocks/libusermetrics/ColorTheme.h (+2/-1) |
||||
| To merge this branch: | bzr merge lp:~aacid/unity8/qt55 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Timo Jyrinki | 2015-03-27 | Approve on 2015-04-08 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-04-02 | |
|
Review via email:
|
|||
Commit Message
Compile with Qt 5.5
Description of the Change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
No, compile only change
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| Daniel d'Andrada (dandrader) wrote : | # |
"""
+#include <QtCore/QObject>
"""
We are not doing #includes like that anymore, it should be just <QObject>. So go ahead and fix the "#include <QtGui/QColor>" below as well.
| Albert Astals Cid (aacid) wrote : | # |
style fixed
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1699
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

FAILED: Continuous integration, rev:1698 jenkins. qa.ubuntu. com/job/ unity8- ci/5494/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 2022 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- vivid/658 jenkins. qa.ubuntu. com/job/ unity8- vivid-amd64- ci/659 jenkins. qa.ubuntu. com/job/ unity8- vivid-i386- ci/659 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1783 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 2020 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 2020/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 19254
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5494/ rebuild
http://