Code review comment for lp:~aacid/unity8/previewIconActionsModelChange

Albert Astals Cid (aacid) wrote :

> we should just compare the url instead converting to string, like you suggested me here
> https://code.launchpad.net/~cimi/unity8/preview-sharing-string-and-array/+merge/287008/comments/732516

It is hard to do that since the url is relative to the folder you are building the code, it's a different scenario to what i suggested there since for you the urls where set hardcoded on the test.

« Back to merge proposal