Merge lp:~aacid/unity8/please_reenter_context into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 1858
Merged at revision: 1880
Proposed branch: lp:~aacid/unity8/please_reenter_context
Merge into: lp:unity8
Diff against target: 200 lines (+50/-49)
2 files modified
po/unity8.pot (+49/-48)
qml/Greeter/NarrowView.qml (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity8/please_reenter_context
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+265094@code.launchpad.net

Commit message

Add context for "Please re-enter"

Translators need to know we're asking the user to reenter the passphrase

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) :
review: Needs Information
Revision history for this message
Albert Astals Cid (aacid) wrote :

> seems like is gonna be deprecated

Well we can change the code when it's deprecated, no need to hold into an easy fix because of that, we already use i18n.ctr in various places anyway

Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y
 * Did CI run pass? If not, please explain why.
unrelated
 * Did you make sure that the branch does not contain spurious tags?
y

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/unity8.pot'
2--- po/unity8.pot 2015-06-22 10:01:15 +0000
3+++ po/unity8.pot 2015-07-17 08:14:54 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: unity8\n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2015-06-22 12:00+0200\n"
9+"POT-Creation-Date: 2015-07-17 10:10+0200\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13@@ -223,15 +223,15 @@
14 msgid "OK"
15 msgstr ""
16
17-#: qml/Dash/GenericScopeView.qml:532 qml/Dash/GenericScopeView.qml:690
18+#: qml/Dash/GenericScopeView.qml:539 qml/Dash/GenericScopeView.qml:697
19 msgid "See less"
20 msgstr ""
21
22-#: qml/Dash/GenericScopeView.qml:532
23+#: qml/Dash/GenericScopeView.qml:539
24 msgid "See all"
25 msgstr ""
26
27-#: qml/Dash/GenericScopeView.qml:594
28+#: qml/Dash/GenericScopeView.qml:601
29 msgctxt "Label: Hint for dash search line edit"
30 msgid "Search"
31 msgstr ""
32@@ -315,57 +315,58 @@
33 msgid "Tap to unlock"
34 msgstr ""
35
36-#: qml/Greeter/NarrowView.qml:53 qml/Wizard/Pages/passwd-confirm.qml:53
37+#: qml/Greeter/NarrowView.qml:54 qml/Wizard/Pages/passwd-confirm.qml:53
38 msgid "Sorry, incorrect passphrase."
39 msgstr ""
40
41-#: qml/Greeter/NarrowView.qml:54 qml/Wizard/Pages/passwd-confirm.qml:54
42+#: qml/Greeter/NarrowView.qml:55 qml/Wizard/Pages/passwd-confirm.qml:54
43 msgid "Sorry, incorrect passcode."
44 msgstr ""
45
46-#: qml/Greeter/NarrowView.qml:55
47+#: qml/Greeter/NarrowView.qml:56
48 msgid "This will be your last attempt."
49 msgstr ""
50
51-#: qml/Greeter/NarrowView.qml:57
52+#: qml/Greeter/NarrowView.qml:58
53 msgid ""
54 "If passphrase is entered incorrectly, your phone will conduct a factory "
55 "reset and all personal data will be deleted."
56 msgstr ""
57
58-#: qml/Greeter/NarrowView.qml:58
59+#: qml/Greeter/NarrowView.qml:59
60 msgid ""
61 "If passcode is entered incorrectly, your phone will conduct a factory reset "
62 "and all personal data will be deleted."
63 msgstr ""
64
65-#: qml/Greeter/NarrowView.qml:115
66+#: qml/Greeter/NarrowView.qml:116
67 #, qt-format
68 msgid "Enter %1"
69 msgstr ""
70
71-#: qml/Greeter/NarrowView.qml:116 qml/Wizard/Pages/passwd-set.qml:60
72+#: qml/Greeter/NarrowView.qml:117 qml/Wizard/Pages/passwd-set.qml:60
73 msgid "Enter passphrase"
74 msgstr ""
75
76-#: qml/Greeter/NarrowView.qml:117
77+#: qml/Greeter/NarrowView.qml:118
78 msgid "Enter passcode"
79 msgstr ""
80
81-#: qml/Greeter/NarrowView.qml:118
82+#: qml/Greeter/NarrowView.qml:119
83 #, qt-format
84 msgid "Sorry, incorrect %1"
85 msgstr ""
86
87-#: qml/Greeter/NarrowView.qml:119
88+#: qml/Greeter/NarrowView.qml:120
89 msgid "Sorry, incorrect passphrase"
90 msgstr ""
91
92-#: qml/Greeter/NarrowView.qml:120
93+#: qml/Greeter/NarrowView.qml:121
94+msgctxt "passphrase"
95 msgid "Please re-enter"
96 msgstr ""
97
98-#: qml/Greeter/NarrowView.qml:121
99+#: qml/Greeter/NarrowView.qml:122
100 msgid "Sorry, incorrect passcode"
101 msgstr ""
102
103@@ -515,38 +516,6 @@
104 msgid "Back"
105 msgstr ""
106
107-#: qml/Wizard/Pages/here-terms.qml:27
108-msgid "Terms & Conditions"
109-msgstr ""
110-
111-#: qml/Wizard/Pages/passwd-confirm.qml:49
112-msgid "Confirm passphrase"
113-msgstr ""
114-
115-#: qml/Wizard/Pages/passwd-confirm.qml:50
116-msgid "Confirm passcode"
117-msgstr ""
118-
119-#: qml/Wizard/Pages/passwd-confirm.qml:53
120-#: qml/Wizard/Pages/passwd-confirm.qml:54
121-msgid "Please try again."
122-msgstr ""
123-
124-#: qml/Wizard/Pages/passwd-confirm.qml:82 qml/Wizard/Pages/passwd-set.qml:90
125-#: qml/Wizard/Pages/10-welcome.qml:88 qml/Wizard/Pages/30-passwd-type.qml:128
126-#: qml/Wizard/Pages/40-wifi.qml:215 qml/Wizard/Pages/50-location.qml:131
127-#: qml/Wizard/Pages/60-reporting.qml:50
128-msgid "Continue"
129-msgstr ""
130-
131-#: qml/Wizard/Pages/passwd-set.qml:61
132-msgid "Choose your passcode"
133-msgstr ""
134-
135-#: qml/Wizard/Pages/passwd-set.qml:68
136-msgid "Passphrase must be 4 characters long"
137-msgstr ""
138-
139 #: qml/Wizard/Pages/10-welcome.qml:27
140 msgid "Hi!"
141 msgstr ""
142@@ -559,6 +528,13 @@
143 msgid "Let’s get started."
144 msgstr ""
145
146+#: qml/Wizard/Pages/10-welcome.qml:88 qml/Wizard/Pages/30-passwd-type.qml:128
147+#: qml/Wizard/Pages/40-wifi.qml:215 qml/Wizard/Pages/50-location.qml:131
148+#: qml/Wizard/Pages/60-reporting.qml:50 qml/Wizard/Pages/passwd-confirm.qml:82
149+#: qml/Wizard/Pages/passwd-set.qml:90
150+msgid "Continue"
151+msgstr ""
152+
153 #: qml/Wizard/Pages/20-sim.qml:25
154 msgid "Add a SIM card and restart your device"
155 msgstr ""
156@@ -684,6 +660,31 @@
157 msgid "Finish"
158 msgstr ""
159
160+#: qml/Wizard/Pages/here-terms.qml:27
161+msgid "Terms & Conditions"
162+msgstr ""
163+
164+#: qml/Wizard/Pages/passwd-confirm.qml:49
165+msgid "Confirm passphrase"
166+msgstr ""
167+
168+#: qml/Wizard/Pages/passwd-confirm.qml:50
169+msgid "Confirm passcode"
170+msgstr ""
171+
172+#: qml/Wizard/Pages/passwd-confirm.qml:53
173+#: qml/Wizard/Pages/passwd-confirm.qml:54
174+msgid "Please try again."
175+msgstr ""
176+
177+#: qml/Wizard/Pages/passwd-set.qml:61
178+msgid "Choose your passcode"
179+msgstr ""
180+
181+#: qml/Wizard/Pages/passwd-set.qml:68
182+msgid "Passphrase must be 4 characters long"
183+msgstr ""
184+
185 #. Translators: This is the arrow for "Back" buttons
186 #: qml/Wizard/StackButton.qml:39
187 #, qt-format
188
189=== modified file 'qml/Greeter/NarrowView.qml'
190--- qml/Greeter/NarrowView.qml 2015-03-04 13:23:34 +0000
191+++ qml/Greeter/NarrowView.qml 2015-07-17 08:14:54 +0000
192@@ -118,7 +118,7 @@
193 i18n.tr("Enter passcode")
194 errorText: promptText !== "" ? i18n.tr("Sorry, incorrect %1").arg(promptText) :
195 alphaNumeric ? i18n.tr("Sorry, incorrect passphrase") + "\n" +
196- i18n.tr("Please re-enter") :
197+ i18n.ctr("passphrase", "Please re-enter") :
198 i18n.tr("Sorry, incorrect passcode")
199
200 onEntered: root.responded(passphrase)

Subscribers

People subscribed via source and target branches