Merge lp:~aacid/unity8/onetozero into lp:unity8
Proposed by
Albert Astals Cid
| Status: | Merged |
|---|---|
| Approved by: | Andrea Cimitan |
| Approved revision: | 2803 |
| Merged at revision: | 2843 |
| Proposed branch: | lp:~aacid/unity8/onetozero |
| Merge into: | lp:unity8 |
| Diff against target: |
12 lines (+1/-1) 1 file modified
qml/Components/KeyboardShortcutsOverlay.qml (+1/-1) |
| To merge this branch: | bzr merge lp:~aacid/unity8/onetozero |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Approve | |
| Andrea Cimitan (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Let's follow the keyboard order
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
After heavily testing with several different keyboards (they all have numbers from 1 to 0), I consider this branch safe.
* Did you perform an exploratory manual test run of the code change and any related functionality?
yes
* Did CI run pass? If not, please explain why.