Merge lp:~aacid/unity8/notificationsFullscreenOnIndexChange into lp:unity8

[Albert Astals Cid]

Update notificationList.topmostIsFullscreen when the index changes

Since the code is index dependant

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2279
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/742/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/979
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/995
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/995
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/993/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/993/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/993/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/993/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/993/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/993/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/742/rebuild

review: Needs Fixing (continuous-integration)

[Andrea Cimitan (cimi)]

possible to test easily?

review: Needs Information

[Albert Astals Cid (aacid)]

> possible to test easily?

Not really, there's actually no test at all for the pin "notification" and adding one is far from easy given how the code is written.

If you really want i can try to work on it but it will take a while.

[Andrea Cimitan (cimi)]

> > possible to test easily?
>
> Not really, there's actually no test at all for the pin "notification" and
> adding one is far from easy given how the code is written.
>
> If you really want i can try to work on it but it will take a while.
I don't think this branch is then the correct place to start a testing framework for notifications then, but thanks for looking at it though. We should have a card for notification testing

[Michael Zanetti (mzanetti)]

> > possible to test easily?
>
> Not really, there's actually no test at all for the pin "notification" and
> adding one is far from easy given how the code is written.
>
> If you really want i can try to work on it but it will take a while.

In light of the upcoming notifications rework I don't think it's worth it.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2279
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/856/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1100
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1108
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1108
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1106
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1106/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1106/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1106
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1106/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1106/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1106
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1106/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1106/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/856/rebuild

review: Needs Fixing (continuous-integration)

[Andrea Cimitan (cimi)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
y
 * Did CI run pass? If not, please explain why.
 * Did you make sure that the branch does not contain spurious tags?
y

review: Approve

[Lukáš Tinkl (lukas-kde)]

Kind of superseded by https://code.launchpad.net/~lukas-kde/unity8/fullscreenNotifications-lp1581498/+merge/294799

review: Disapprove

Unmerged revisions

=== modified file 'qml/Notifications/Notifications.qml'
--- qml/Notifications/Notifications.qml	2015-10-26 09:59:50 +0000
+++ qml/Notifications/Notifications.qml	2016-03-15 14:32:13 +0000
@@ -68,13 +68,12 @@
         // FIXME: disabled all transitions because of LP: #1354406 workaround
         //layer.enabled: add.running || remove.running || populate.running
 
-        Component.onCompleted: {
-            if (index == 1) {
-                notificationList.topmostIsFullscreen = fullscreen
-            }
-        }
+        readonly property int theIndex: index
+        onTheIndexChanged: updateListTopMostIsFullscreen();
+        Component.onCompleted: updateListTopMostIsFullscreen();
+        onFullscreenChanged: updateListTopMostIsFullscreen();
 
-        onFullscreenChanged: {
+        function updateListTopMostIsFullscreen() {
             // index 1 because 0 is the PlaceHolder...
             if (index == 1) {
                 notificationList.topmostIsFullscreen = fullscreen