Merge lp:~aacid/unity8/noiconpreviewheader into lp:unity8
Proposed by
Albert Astals Cid
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andrea Cimitan | ||||
Approved revision: | 894 | ||||
Merged at revision: | 922 | ||||
Proposed branch: | lp:~aacid/unity8/noiconpreviewheader | ||||
Merge into: | lp:unity8 | ||||
Diff against target: |
65 lines (+15/-7) 2 files modified
qml/Dash/Previews/PreviewHeader.qml (+3/-0) tests/qmltests/Dash/Previews/tst_PreviewHeader.qml (+12/-7) |
||||
To merge this branch: | bzr merge lp:~aacid/unity8/noiconpreviewheader | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Cimitan (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Michal Hruby (community) | Approve | ||
Review via email: mp+219502@code.launchpad.net |
Commit message
Don't reserve space for mascot if no mascot is specified
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
FAILED: Continuous integration, rev:893 jenkins. qa.ubuntu. com/job/ unity8- ci/2959/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/207 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- trusty/ 1819/console jenkins. qa.ubuntu. com/job/ unity8- utopic- amd64-ci/ 53 jenkins. qa.ubuntu. com/job/ unity8- utopic- armhf-ci/ 53 jenkins. qa.ubuntu. com/job/ unity8- utopic- armhf-ci/ 53/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity8- utopic- i386-ci/ 53 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/700 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/437 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/437/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 7149
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/2959/ rebuild
http://