Merge lp:~aacid/unity8/nodda into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Daniel d'Andrada on 2016-05-02 |
| Approved revision: | 2125 |
| Merged at revision: | 2410 |
| Proposed branch: | lp:~aacid/unity8/nodda |
| Merge into: | lp:unity8 |
| Prerequisite: | lp:~aacid/unity8/fixQmlTestsNewSDK |
| Diff against target: |
7650 lines (+314/-6218) 77 files modified
CMakeLists.txt (+12/-1) debian/control (+2/-0) debian/unity8-private.install (+0/-1) libs/CMakeLists.txt (+0/-1) libs/UbuntuGestures/CMakeLists.txt (+0/-41) libs/UbuntuGestures/CandidateInactivityTimer.cpp (+0/-46) libs/UbuntuGestures/CandidateInactivityTimer.h (+0/-51) libs/UbuntuGestures/DebugHelpers.cpp (+0/-95) libs/UbuntuGestures/DebugHelpers.h (+0/-31) libs/UbuntuGestures/Pool.h (+0/-124) libs/UbuntuGestures/TimeSource.cpp (+0/-49) libs/UbuntuGestures/TimeSource.h (+0/-64) libs/UbuntuGestures/Timer.cpp (+0/-152) libs/UbuntuGestures/Timer.h (+0/-122) libs/UbuntuGestures/TouchOwnershipEvent.cpp (+0/-35) libs/UbuntuGestures/TouchOwnershipEvent.h (+0/-50) libs/UbuntuGestures/TouchRegistry.cpp (+0/-553) libs/UbuntuGestures/TouchRegistry.h (+0/-201) libs/UbuntuGestures/UbuntuGesturesGlobal.h (+0/-23) libs/UbuntuGestures/UnownedTouchEvent.cpp (+0/-39) libs/UbuntuGestures/UnownedTouchEvent.h (+0/-45) plugins/Ubuntu/Gestures/AxisVelocityCalculator.h (+1/-1) plugins/Ubuntu/Gestures/CMakeLists.txt (+5/-5) plugins/Ubuntu/Gestures/Damper.cpp (+0/-24) plugins/Ubuntu/Gestures/Damper.h (+0/-89) plugins/Ubuntu/Gestures/Direction.h (+1/-0) plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+0/-932) plugins/Ubuntu/Gestures/DirectionalDragArea.h (+0/-143) plugins/Ubuntu/Gestures/DirectionalDragArea_p.h (+0/-169) plugins/Ubuntu/Gestures/Gestures.qmltypes (+0/-132) plugins/Ubuntu/Gestures/MouseEventGenerator.cpp (+48/-134) plugins/Ubuntu/Gestures/MouseEventGenerator.h (+23/-61) plugins/Ubuntu/Gestures/PressedOutsideNotifier.h (+1/-1) plugins/Ubuntu/Gestures/TouchGate.cpp (+2/-2) plugins/Ubuntu/Gestures/TouchGestureArea.cpp (+9/-6) plugins/Ubuntu/Gestures/TouchGestureArea.h (+1/-2) plugins/Ubuntu/Gestures/plugin.cpp (+3/-5) qml/Components/DragHandle.qml (+16/-18) qml/Components/FloatingFlickable.qml (+59/-0) qml/Dash/Dash.qml (+3/-3) qml/Launcher/Launcher.qml (+4/-4) qml/Panel/IndicatorsMenu.qml (+17/-13) qml/Stages/DesktopStage.qml (+1/-1) qml/Stages/PhoneStage.qml (+4/-4) qml/Stages/TabletStage.qml (+4/-4) qml/Tutorial/TutorialBottom.qml (+3/-3) src/CMakeLists.txt (+0/-4) tests/CMakeLists.txt (+0/-1) tests/libs/CMakeLists.txt (+0/-1) tests/libs/UbuntuGestures/CMakeLists.txt (+0/-16) tests/libs/UbuntuGestures/tst_TouchRegistry.cpp (+0/-974) tests/plugins/Ubuntu/Gestures/CMakeLists.txt (+4/-4) tests/plugins/Ubuntu/Gestures/DownwardsLauncher.qml (+0/-72) tests/plugins/Ubuntu/Gestures/GestureTest.cpp (+2/-2) tests/plugins/Ubuntu/Gestures/LeftwardsLauncher.qml (+0/-76) tests/plugins/Ubuntu/Gestures/RightwardsLauncher.qml (+0/-76) tests/plugins/Ubuntu/Gestures/UpwardsLauncher.qml (+0/-76) tests/plugins/Ubuntu/Gestures/tst_Damper.cpp (+0/-40) tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp (+0/-1250) tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.qml (+0/-76) tests/plugins/Ubuntu/Gestures/tst_FloatingFlickable.cpp (+26/-19) tests/plugins/Ubuntu/Gestures/tst_FloatingFlickable.qml (+1/-0) tests/plugins/Ubuntu/Gestures/tst_TouchGate.cpp (+1/-1) tests/qmltests/Components/CMakeLists.txt (+6/-3) tests/qmltests/Components/tst_DragHandle.cpp (+25/-21) tests/qmltests/Components/tst_EdgeDragEvaluator.cpp (+1/-1) tests/qmltests/Greeter/tst_Greeter.qml (+1/-1) tests/qmltests/Greeter/tst_NarrowView.qml (+1/-1) tests/qmltests/Greeter/tst_WideView.qml (+1/-1) tests/qmltests/Launcher/tst_Launcher.qml (+1/-1) tests/qmltests/Tutorial/tst_Tutorial.qml (+2/-2) tests/qmltests/tst_OrientedShell.qml (+1/-1) tests/qmltests/tst_Shell.qml (+7/-5) tests/qmltests/tst_ShellWithPin.qml (+1/-1) tests/utils/modules/Unity/Test/CMakeLists.txt (+4/-2) tests/utils/modules/Unity/Test/UnityTestCase.qml (+8/-8) tests/utils/modules/Unity/Test/testutil.cpp (+2/-2) |
| To merge this branch: | bzr merge lp:~aacid/unity8/nodda |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing on 2016-05-02 | |
| Daniel d'Andrada (community) | 2015-12-17 | Approve on 2016-05-02 | |
| PS Jenkins bot | continuous-integration | 2015-12-17 | Needs Fixing on 2015-12-17 |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-12-07.
Commit Message
Remove DirectionalDragArea and libs/UbuntuGestures and port to SDK equivalents
Description of the Change
* Are there any related MPs required for this MP to build/function as expected?
None
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2090
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2097
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2098
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2099
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2100
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Daniel d'Andrada (dandrader) wrote : | # |
Please document FloatingFlickab
| Daniel d'Andrada (dandrader) wrote : | # |
> Please document FloatingFlickab
You could even give it a more informative/
| Daniel d'Andrada (dandrader) wrote : | # |
"""
* Copyright (C) 2013 Canonical, Ltd.
"""
Please fix the copyright year in FloatingFlickab
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2101
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Daniel d'Andrada (dandrader) wrote : | # |
In tests/autopilot
"""
- current_
+ current_
"""
Seems unrelated.
Same in tests/qmltests/
-------
I don't get why you had to make those changes in tests/qmltests/
-------
This "wait(1000);" in tests/qmltests/
| Albert Astals Cid (aacid) wrote : | # |
> In tests/autopilot
>
> """
> - current_
> + current_
> """
>
> Seems unrelated.
>
> Same in tests/qmltests/
> tests/qmltests/
Yeah i merged https:/
| Albert Astals Cid (aacid) wrote : | # |
> I don't get why you had to make those changes in tests/qmltests/
That's https:/
| Albert Astals Cid (aacid) wrote : | # |
> This "wait(1000);" in tests/qmltests/
Yeah, removed, now for some reason there's failing tests there i did not have when i presented the branch, i'll investigate.
| Daniel d'Andrada (dandrader) wrote : | # |
-- checking for module 'UbuntuGestures'
-- package 'UbuntuGestures' not found
Getting this error in my arm chroot. Might be related to the fact that uitk replaced the package libubuntugestures with libubuntugestures5
| Daniel d'Andrada (dandrader) wrote : | # |
In src/CMakeLists.txt
"""
# For it to find libUbuntuGestur
set_target_
"""
You can remove this since we no longer build libUbuntuGestures ourselves.
| Daniel d'Andrada (dandrader) wrote : | # |
In src/CMakeLists.txt:
"""
include_
${Qt5Gui_
${CMAKE_
${CONNECTIV
)
"""
"${CMAKE_
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2102
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
Fixed the src/CMakeLists.txt issues
| Daniel d'Andrada (dandrader) wrote : | # |
"""
// don't go the whole distance in order to smooth out the movement
"""
Please remove that comment from qml/Components/
| Daniel d'Andrada (dandrader) wrote : | # |
Looks like FloatingFlickable is broken. I'm no longer able to move the list of windows in the desktop spread with my finger.
| Michael Terry (mterry) wrote : | # |
Ugh, if this lands it blocks my tutorial-redesign branch on landing the monitorOnly mode in the SDK. Which I'll get started on trying to land anyway. But still. I'm sad to lose the race. :(
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2108
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Daniel d'Andrada (dandrader) wrote : | # |
Code looks good. Didn't spot any regressions on my Nexus 7 in tablet nor desktop modes
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2114
https:/
Executed test runs:
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2116
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2117
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2117
https:/
Executed test runs:
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2117
https:/
Executed test runs:
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2117
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
Lots of stuff changed behind my feet so need to update this :'(
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2120
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Michael Terry (mterry) wrote : | # |
The new SwipeArea property "grabGesture" (which is an inverse of the property the new tutorial uses -- "monitorOnly"), landed in the released toolkit now.
So that's not a blocker anymore.
| Albert Astals Cid (aacid) wrote : | # |
> The new SwipeArea property "grabGesture" (which is an inverse of the property
> the new tutorial uses -- "monitorOnly"), landed in the released toolkit now.
>
> So that's not a blocker anymore.
I'd say we should still wait for https:/
- 2121. By Albert Astals Cid on 2016-04-13
-
Merge
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2121
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
- 2122. By Albert Astals Cid on 2016-04-13
-
Fix borken merge
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2122
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Daniel d'Andrada (dandrader) wrote : | # |
On 13/04/2016 05:28, Albert Astals Cid wrote:
>> The new SwipeArea property "grabGesture" (which is an inverse of the property
>> the new tutorial uses -- "monitorOnly"), landed in the released toolkit now.
>>
>> So that's not a blocker anymore.
> I'd say we should still wait for https:/
I think you pasted the wrong URL...
| Albert Astals Cid (aacid) wrote : | # |
> On 13/04/2016 05:28, Albert Astals Cid wrote:
> >> The new SwipeArea property "grabGesture" (which is an inverse of the
> property
> >> the new tutorial uses -- "monitorOnly"), landed in the released toolkit
> now.
> >>
> >> So that's not a blocker anymore.
> > I'd say we should still wait for
> https:/
> too since it's a bugfix that we have on our side that the SDK doesn't.
>
> I think you pasted the wrong URL...
Right, i meant https:/
- 2123. By Albert Astals Cid on 2016-04-26
-
Merge
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2123
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2123
https:/
Executed test runs:
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
- 2124. By Albert Astals Cid on 2016-05-02
-
Merge
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2124
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Daniel d'Andrada (dandrader) wrote : | # |
Addded cmake checks for libubuntugestur
- 2125. By Daniel d'Andrada on 2016-05-02
-
Add cmake check for libubuntugestur
es5-dev and libubuntugestur es5-private- dev
| Daniel d'Andrada (dandrader) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.
* Did CI run pass? If not, please explain why.
Only one failure which seems unrelated (https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2125
https:/
Executed test runs:
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/

FAILED: Continuous integration, rev:2089 jenkins. qa.ubuntu. com/job/ unity8- ci/6909/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 5692/console jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- xenial- touch/324/ console jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- vivid/1620/ console jenkins. qa.ubuntu. com/job/ unity8- qmluitest- xenial- amd64/323/ console jenkins. qa.ubuntu. com/job/ unity8- vivid-amd64- ci/1515/ console jenkins. qa.ubuntu. com/job/ unity8- vivid-i386- ci/1515/ console jenkins. qa.ubuntu. com/job/ unity8- xenial- amd64-ci/ 322/console jenkins. qa.ubuntu. com/job/ unity8- xenial- i386-ci/ 321/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 5705/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- xenial- armhf/323/ console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/6909/ rebuild
http://