Merge lp:~aacid/unity8/no_preview_in_preview_title into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Michał Sawicz
Approved revision: 968
Merged at revision: 971
Proposed branch: lp:~aacid/unity8/no_preview_in_preview_title
Merge into: lp:unity8
Prerequisite: lp:~mterry/unity8/unsplit
Diff against target: 124 lines (+30/-35)
2 files modified
po/unity8.pot (+29/-34)
qml/Dash/PreviewListView.qml (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity8/no_preview_in_preview_title
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michał Sawicz Approve
Review via email: mp+223029@code.launchpad.net

Commit message

Drop the " Preview" suffix from Preview title

As requested in https://bugs.launchpad.net/unity8/+bug/1316671

Description of the change

* Are there any related MPs required for this MP to build/function as expected?
 Prerequisite Branch

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
It's a design driven change.

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

 * Did CI run pass? If not, please explain why.
Not yet.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/unity8.pot'
2--- po/unity8.pot 2014-05-27 20:48:17 +0000
3+++ po/unity8.pot 2014-06-13 07:58:33 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: unity8\n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2014-05-27 22:48+0200\n"
9+"POT-Creation-Date: 2014-06-13 09:55+0200\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13@@ -72,10 +72,35 @@
14 "phone<br><br>Tap on the screen to start"
15 msgstr ""
16
17+#: qml/Components/Lockscreen.qml:214
18+msgid "Emergency Call"
19+msgstr ""
20+
21+#: qml/Components/Lockscreen.qml:231
22+msgid "OK"
23+msgstr ""
24+
25 #: qml/Components/PageHeader.qml:365
26 msgid "Recent searches"
27 msgstr ""
28
29+#: qml/Components/PassphraseLockscreen.qml:60
30+#, qt-format
31+msgid "Hello %1"
32+msgstr ""
33+
34+#: qml/Components/PassphraseLockscreen.qml:60
35+msgid "Hello"
36+msgstr ""
37+
38+#: qml/Components/PinLockscreen.qml:198
39+msgid "CANCEL"
40+msgstr ""
41+
42+#: qml/Components/PinLockscreen.qml:216
43+msgid "DONE"
44+msgstr ""
45+
46 #: qml/Components/SeeMore.qml:35
47 msgid "See more"
48 msgstr ""
49@@ -88,11 +113,6 @@
50 msgid "Recent"
51 msgstr ""
52
53-#: qml/Dash/PreviewListView.qml:52
54-#, qt-format
55-msgid "%1 Preview"
56-msgstr ""
57-
58 #: qml/Dash/Previews/PreviewActionCombo.qml:34
59 msgid "More..."
60 msgstr ""
61@@ -117,31 +137,6 @@
62 msgid "Swipe to unlock"
63 msgstr ""
64
65-#: qml/Greeter/Lockscreen.qml:215
66-msgid "Emergency Call"
67-msgstr ""
68-
69-#: qml/Greeter/Lockscreen.qml:232
70-msgid "OK"
71-msgstr ""
72-
73-#: qml/Greeter/PassphraseLockscreen.qml:60
74-#, qt-format
75-msgid "Hello %1"
76-msgstr ""
77-
78-#: qml/Greeter/PassphraseLockscreen.qml:60
79-msgid "Hello"
80-msgstr ""
81-
82-#: qml/Greeter/PinLockscreen.qml:198
83-msgid "CANCEL"
84-msgstr ""
85-
86-#: qml/Greeter/PinLockscreen.qml:216
87-msgid "DONE"
88-msgstr ""
89-
90 #: qml/Hud/HudParametrizedActionsPage.qml:132
91 msgid "Confirm"
92 msgstr ""
93@@ -162,15 +157,15 @@
94 msgid "Speaking..."
95 msgstr ""
96
97-#: qml/Notifications/NotificationMenuItemFactory.qml:92
98+#: qml/Notifications/NotificationMenuItemFactory.qml:91
99 msgid "Show password"
100 msgstr ""
101
102-#: qml/Notifications/NotificationMenuItemFactory.qml:104
103+#: qml/Notifications/NotificationMenuItemFactory.qml:103
104 msgid "Please enter SIM PIN"
105 msgstr ""
106
107-#: qml/Panel/SearchIndicator.qml:27 test.qml:7
108+#: qml/Panel/SearchIndicator.qml:27
109 msgid "Search"
110 msgstr ""
111
112
113=== modified file 'qml/Dash/PreviewListView.qml'
114--- qml/Dash/PreviewListView.qml 2014-05-19 11:10:58 +0000
115+++ qml/Dash/PreviewListView.qml 2014-06-13 07:58:33 +0000
116@@ -49,7 +49,7 @@
117 right: parent.right
118 verticalCenter: parent.verticalCenter
119 }
120- text: scope ? i18n.tr("%1 Preview").arg(scope.name) : ""
121+ text: scope ? scope.name : ""
122 // TODO Saviq: These should come from updated Ubuntu Palette.
123 color: "#888888"
124 font.family: "Ubuntu"

Subscribers

People subscribed via source and target branches