lp:~aacid/unity8/noArtShapeSizeForRegularCards
Created by
Albert Astals Cid
and last modified
- Get this branch:
- bzr branch lp:~aacid/unity8/noArtShapeSizeForRegularCards
Only
Albert Astals Cid
can upload to this branch. If you are
Albert Astals Cid
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Andrea Cimitan (community): Approve
- Unity8 CI Bot: Needs Fixing (continuous-integration)
-
Diff: 169 lines (+3/-15)13 files modifiedplugins/Dash/CardCreator.js (+3/-3)
tests/plugins/Dash/cardcreator/1.res (+0/-1)
tests/plugins/Dash/cardcreator/10.res (+0/-1)
tests/plugins/Dash/cardcreator/11.res (+0/-1)
tests/plugins/Dash/cardcreator/12.res (+0/-1)
tests/plugins/Dash/cardcreator/2.res (+0/-1)
tests/plugins/Dash/cardcreator/3.res (+0/-1)
tests/plugins/Dash/cardcreator/4.res (+0/-1)
tests/plugins/Dash/cardcreator/5.res (+0/-1)
tests/plugins/Dash/cardcreator/6.res (+0/-1)
tests/plugins/Dash/cardcreator/7.res (+0/-1)
tests/plugins/Dash/cardcreator/8.res (+0/-1)
tests/plugins/Dash/cardcreator/9.res (+0/-1)
Branch information
Recent revisions
- 2549. By Albert Astals Cid
-
Remove artShapeSize from non cardtool cards
artShapeSize is only used in the cardtool card to read the value them we pass down in fixedArtShapeSize
According to qmlprofiler evaluating this useless binding accounts for ~0.5% when scrolling up and down a very long scope
- 2548. By Albert Astals Cid
-
Do not calculate implicitHeight for Cards in a CardGrid
We set their height with
item.height = Qt.binding(function( ) { return cardTool. cardHeight; });
anyway so it's lost CPU timeThe qmlprofiler said it took around 1.5% of the time of scrolling up/down a very long scope
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:unity8