Merge lp:~aacid/unity8/new-scopes-image-gallery-scroll-workaround into lp:~unity-team/unity8/new-scopes

Proposed by Albert Astals Cid
Status: Merged
Merged at revision: 652
Proposed branch: lp:~aacid/unity8/new-scopes-image-gallery-scroll-workaround
Merge into: lp:~unity-team/unity8/new-scopes
Diff against target: 19 lines (+9/-0)
1 file modified
qml/Dash/Previews/PreviewImageGallery.qml (+9/-0)
To merge this branch: bzr merge lp:~aacid/unity8/new-scopes-image-gallery-scroll-workaround
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Review via email: mp+207118@code.launchpad.net

Commit message

Add back the workaround for not being able scroll the image gallery

Taken from AppPreview.qml

Fixes bug #1281709

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

Yup.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/Previews/PreviewImageGallery.qml'
2--- qml/Dash/Previews/PreviewImageGallery.qml 2014-02-05 12:08:18 +0000
3+++ qml/Dash/Previews/PreviewImageGallery.qml 2014-02-19 09:14:14 +0000
4@@ -33,6 +33,15 @@
5 cacheBuffer: width * 3
6 model: root.widgetData["sources"]
7
8+ // FIXME: Because of ListViews inside ListViews inside Flickables inside ListViews (and some more)
9+ // we finally reached the point where this ListView doesn't correctly get swipe input any more but
10+ // instead the parent ListView is the one that is swiped. This MouseArea sort of creates a blocking
11+ // layer to make sure this ListView can be swiped, regardless of what's behind it.
12+ MouseArea {
13+ anchors.fill: parent
14+ enabled: parent.contentWidth > parent.width
15+ }
16+
17 LazyImage {
18 objectName: "placeholderScreenshot"
19 anchors {

Subscribers

People subscribed via source and target branches

to all changes: