Unity 8

Merge lp:~aacid/unity8/minor_test_coverity_fixes into lp:unity8

  1. minor_test_coverity_fixes
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Lukáš Tinkl
Approved revision: 2411
Merged at revision: 2468
Proposed branch: lp:~aacid/unity8/minor_test_coverity_fixes
Merge into: lp:unity8
Diff against target: 84 lines (+5/-3)
7 files modified
tests/mocks/GSettings.1.0/fake_gsettings.cpp (+1/-0)
tests/mocks/IntegratedLightDM/liblightdm/GreeterPrivate.h (+0/-1)
tests/mocks/Ubuntu/Payments/MockPayments.cpp (+1/-0)
tests/mocks/Unity/Application/MirSurfaceItem.cpp (+1/-0)
tests/mocks/libusermetrics/UserMetrics.cpp (+1/-1)
tests/plugins/Unity/Indicators/MenuContentActivatorTest.cpp (+1/-0)
tests/uqmlscene/main.cpp (+0/-1)
To merge this branch: bzr merge lp:~aacid/unity8/minor_test_coverity_fixes
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Lukáš Tinkl (community) Approve
Review via email: mp+295829@code.launchpad.net

Commit message

Minor coverity fixes

Remove unused member variables
Initialize to 0/nullptr some member variables

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

LGTM

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1359/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/1797
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/886
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/886
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/886
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1818
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1765
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1765
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1765
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1756/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1756/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1756/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1756/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1756/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1756/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1756/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1756/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1756
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1756/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1359/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1394/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/1860
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/943
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/943
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/943
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1886
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1824
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1824
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1824
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1815/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1394/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/mocks/GSettings.1.0/fake_gsettings.cpp'
2--- tests/mocks/GSettings.1.0/fake_gsettings.cpp 2016-04-14 15:04:29 +0000
3+++ tests/mocks/GSettings.1.0/fake_gsettings.cpp 2016-05-26 13:17:37 +0000
4@@ -23,6 +23,7 @@
5 GSettingsControllerQml::GSettingsControllerQml()
6 : m_disableHeight(false)
7 , m_usageMode("Staged")
8+ , m_lockedOutTime(0)
9 , m_autohideLauncher(false)
10 , m_launcherWidth(8)
11 , m_edgeDragWidth(2)
12
13=== modified file 'tests/mocks/IntegratedLightDM/liblightdm/GreeterPrivate.h'
14--- tests/mocks/IntegratedLightDM/liblightdm/GreeterPrivate.h 2015-01-20 11:50:19 +0000
15+++ tests/mocks/IntegratedLightDM/liblightdm/GreeterPrivate.h 2016-05-26 13:17:37 +0000
16@@ -41,7 +41,6 @@
17 void handleRespond(const QString &response);
18
19 protected:
20- GreeterImpl *m_impl; // if the backend needs more private data
21 Greeter * const q_ptr;
22
23 private:
24
25=== modified file 'tests/mocks/Ubuntu/Payments/MockPayments.cpp'
26--- tests/mocks/Ubuntu/Payments/MockPayments.cpp 2014-09-15 21:32:06 +0000
27+++ tests/mocks/Ubuntu/Payments/MockPayments.cpp 2016-05-26 13:17:37 +0000
28@@ -21,6 +21,7 @@
29
30 MockPayments::MockPayments(QObject *parent)
31 : QObject(parent)
32+ , m_price(0)
33 {
34 }
35
36
37=== modified file 'tests/mocks/Unity/Application/MirSurfaceItem.cpp'
38--- tests/mocks/Unity/Application/MirSurfaceItem.cpp 2016-05-09 08:54:11 +0000
39+++ tests/mocks/Unity/Application/MirSurfaceItem.cpp 2016-05-26 13:17:37 +0000
40@@ -40,6 +40,7 @@
41 MirSurfaceItem::MirSurfaceItem(QQuickItem *parent)
42 : MirSurfaceItemInterface(parent)
43 , m_qmlSurface(nullptr)
44+ , m_qmlContentComponent(nullptr)
45 , m_qmlItem(nullptr)
46 , m_consumesInput(false)
47 , m_surfaceWidth(0)
48
49=== modified file 'tests/mocks/libusermetrics/UserMetrics.cpp'
50--- tests/mocks/libusermetrics/UserMetrics.cpp 2015-09-16 14:34:56 +0000
51+++ tests/mocks/libusermetrics/UserMetrics.cpp 2016-05-26 13:17:37 +0000
52@@ -220,7 +220,7 @@
53 }
54
55 UserMetricsPrivate::UserMetricsPrivate(UserMetrics *parent) :
56- q_ptr(parent), m_firstColor(this), m_secondColor(this)
57+ q_ptr(parent), m_firstColor(this), m_secondColor(this), m_currentDay(0)
58 {
59 m_fakeData.insert("", UserMetricsDataPtr(new UserMetricsData(this)));
60 }
61
62=== modified file 'tests/plugins/Unity/Indicators/MenuContentActivatorTest.cpp'
63--- tests/plugins/Unity/Indicators/MenuContentActivatorTest.cpp 2015-05-21 15:50:16 +0000
64+++ tests/plugins/Unity/Indicators/MenuContentActivatorTest.cpp 2016-05-26 13:17:37 +0000
65@@ -28,6 +28,7 @@
66 public:
67 FakeTimer(QObject *parent = 0)
68 : UnityIndicators::AbstractTimer(parent)
69+ , m_duration(0)
70 {}
71
72 int interval() const override { return m_duration; }
73
74=== modified file 'tests/uqmlscene/main.cpp'
75--- tests/uqmlscene/main.cpp 2015-09-17 12:25:29 +0000
76+++ tests/uqmlscene/main.cpp 2016-05-26 13:17:37 +0000
77@@ -159,7 +159,6 @@
78 bool maximized;
79 bool fullscreen;
80 bool transparent;
81- bool scenegraphOnGraphicsview;
82 bool clip;
83 bool versionDetection;
84 bool quitImmediately;

Subscribers

People subscribed via source and target branches