Merge lp:~aacid/unity8/margins_contribute_to_display_margin into lp:unity8
Proposed by
Albert Astals Cid
Status: | Merged |
---|---|
Approved by: | Michael Zanetti |
Approved revision: | 1775 |
Merged at revision: | 1817 |
Proposed branch: | lp:~aacid/unity8/margins_contribute_to_display_margin |
Merge into: | lp:unity8 |
Prerequisite: | lp:~aacid/unity8/card_height_overlay_header |
Diff against target: |
46 lines (+8/-3) 2 files modified
qml/Components/ResponsiveVerticalJournal.qml (+7/-2) qml/Dash/GenericScopeView.qml (+1/-1) |
To merge this branch: | bzr merge lp:~aacid/unity8/margins_contribute_to_display_margin |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Zanetti (community) | Approve | ||
Review via email: mp+258855@code.launchpad.net |
Commit message
Take into account the extra margin on top when calculating the display margin
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
* Did you perform an exploratory manual test run of the code change and any related functionality?
yes
* Did CI run pass? If not, please explain why.
waiting
* Did you make sure that the branch does not contain spurious tags?
yes