Unity 8

Merge lp:~aacid/unity8/make_test_page_header_more_stable into lp:unity8

  1. make_test_page_header_more_stable
  2. Merge into trunk
Proposed by Albert Astals Cid on 2015-07-14
Status: Merged
Approved by: Andrea Cimitan on 2015-07-14
Approved revision: 1857
Merged at revision: 1876
Proposed branch: lp:~aacid/unity8/make_test_page_header_more_stable
Merge into: lp:unity8
Diff against target: 67 lines (+12/-6)
1 file modified
tests/qmltests/Dash/tst_PageHeader.qml (+12/-6)
To merge this branch: bzr merge lp:~aacid/unity8/make_test_page_header_more_stable
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing on 2015-07-15
Andrea Cimitan (community) 2015-07-14 Approve on 2015-07-14
Review via email: mp+264679@code.launchpad.net

Commit Message

make testPageHeader more stable

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Test change only

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Andrea Cimitan (cimi) wrote :

waiting CI....

PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1857
http://jenkins.qa.ubuntu.com/job/unity8-ci/6028/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/327
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/266
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/267
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-wily-mako/234
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/327
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/327/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21831

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6028/rebuild

review: Needs Fixing (continuous-integration)
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
qmltests did
 * Did you make sure that the branch does not contain spurious tags?
yes

review: Approve
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1857
http://jenkins.qa.ubuntu.com/job/unity8-ci/6045/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/347/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-wily/75
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/283
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/284
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-wily-mako/251/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/347
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/347/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21864

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6045/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/Dash/tst_PageHeader.qml'
2--- tests/qmltests/Dash/tst_PageHeader.qml 2015-01-09 09:15:45 +0000
3+++ tests/qmltests/Dash/tst_PageHeader.qml 2015-07-14 08:35:37 +0000
4@@ -34,6 +34,12 @@
5 property alias searchEnabled : pageHeader.searchEntryEnabled
6 property alias searchQuery : pageHeader.searchQuery
7
8+ function doTypeString(text) {
9+ var headerContainer = findChild(pageHeader, "headerContainer");
10+ tryCompare(headerContainer, "contentY", 0);
11+ typeString(text);
12+ }
13+
14 function init() {
15 searchEnabled = true;
16
17@@ -63,7 +69,7 @@
18 pageHeader.resetSearch()
19
20 pageHeader.triggerSearch()
21- typeString("test")
22+ doTypeString("test")
23
24 compare(searchQuery, "test", "Typing in the search field did not change searchQuery")
25 }
26@@ -72,7 +78,7 @@
27 searchEnabled = true
28 pageHeader.triggerSearch()
29 searchQuery = "test1"
30- typeString("test2")
31+ doTypeString("test2")
32 compare(searchQuery, "test1test2", "Setting searchQuery text does not update the TextField")
33 }
34
35@@ -91,28 +97,28 @@
36
37 function test_history() {
38 pageHeader.triggerSearch()
39- typeString("humppa1")
40+ doTypeString("humppa1")
41 pageHeader.resetSearch()
42
43 tryCompare(pageHeader.searchHistory, "count", 1)
44 compare(pageHeader.searchHistory.get(0).query, "humppa1")
45
46 pageHeader.triggerSearch()
47- typeString("humppa2")
48+ doTypeString("humppa2")
49 pageHeader.resetSearch()
50
51 compare(pageHeader.searchHistory.count, 2)
52 compare(pageHeader.searchHistory.get(0).query, "humppa2")
53
54 pageHeader.triggerSearch()
55- typeString("humppa3")
56+ doTypeString("humppa3")
57 pageHeader.resetSearch()
58
59 compare(pageHeader.searchHistory.count, 3)
60 compare(pageHeader.searchHistory.get(0).query, "humppa3")
61
62 pageHeader.triggerSearch()
63- typeString("humppa4")
64+ doTypeString("humppa4")
65 pageHeader.resetSearch()
66
67 compare(pageHeader.searchHistory.count, 3)

Subscribers

People subscribed via source and target branches