Merge lp:~aacid/unity8/make_cmake_happy into lp:unity8
Proposed by
Albert Astals Cid
| Status: | Merged |
|---|---|
| Approved by: | Michael Zanetti |
| Approved revision: | 1433 |
| Merged at revision: | 1443 |
| Proposed branch: | lp:~aacid/unity8/make_cmake_happy |
| Merge into: | lp:unity8 |
| Diff against target: |
23 lines (+2/-1) 2 files modified
CMakeLists.txt (+1/-0) plugins/Utils/CMakeLists.txt (+1/-1) |
| To merge this branch: | bzr merge lp:~aacid/unity8/make_cmake_happy |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Michael Zanetti (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix a few cmake warnings when running ./build.sh in a clean checkout
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
cmake is now happier
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
* Did you perform an exploratory manual test run of the code change and any related functionality?
yes. builds fine still, shuts up with warnings
* Did CI run pass? If not, please explain why.
waiting, bug very unlikely CI fails on this
* Did you make sure that the branch does not contain spurious tags?
yes