Merge lp:~aacid/unity8/listitemworkaround into lp:unity8

[Albert Astals Cid]

Workaround SDK ListItem bug

 * Are there any related MPs required for this MP to build/function as expected?
Prereq

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2050
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/730/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/958
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/974
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/974
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/972/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/972/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/972/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/972/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/972/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/972/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/730/rebuild

review: Needs Fixing (continuous-integration)

[lp:~aacid/unity8/listitemworkaround]

2051. By Albert Astals Cid on 2016-03-14

import is used here elsewhere

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2051
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/731/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/959
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/975
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/975
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/973/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/973/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/973/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/973/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/973/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/973/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/731/rebuild

review: Needs Fixing (continuous-integration)

[Michael Terry (mterry)]

Code seems fine. But I couldn't actually reproduce the original bug? I was pressing on search categories on the app scope and store. Is it a different navigational element here?

[Albert Astals Cid (aacid)]

Did you follow the reproduction instructions mzanetti gives in the bug? It's relatively easy to reproduce them here with those long press + small move movements ehre.

[Michael Terry (mterry)]

OK, reflashed. Reproduced without this change, couldn't with. Code seems simple enough, and even includes pointers to bug to remove it. Great! :)

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 Yes

 * Did CI run pass? If not, please explain why.
 no... but for seemingly unrelated reasons

 * Did you make sure that the branch does not contain spurious tags?
 Yes

review: Approve

=== modified file 'qml/Dash/DashNavigationList.qml'
--- qml/Dash/DashNavigationList.qml	2016-03-14 14:43:44 +0000
+++ qml/Dash/DashNavigationList.qml	2016-03-14 14:43:44 +0000
@@ -16,6 +16,7 @@
 
 import QtQuick 2.4
 import Ubuntu.Components 1.3
+import Ubuntu.Components.ListItems 1.3 as ListItems
 import "../Components"
 
 Item {
@@ -52,7 +53,8 @@
             Repeater {
                 model: navigation && navigation.loaded ? navigation : null
                 clip: true
-                delegate: ListItem {
+                // FIXME Move to ListItem (and remove import) once 1556971 is fixed
+                delegate: ListItems.Empty {
                     objectName: root.objectName + "child" + index
                     height: root.itemHeight
                     width: column.width

=== modified file 'qml/Dash/PageHeaderExtraPanel.qml'
--- qml/Dash/PageHeaderExtraPanel.qml	2016-03-14 14:43:44 +0000
+++ qml/Dash/PageHeaderExtraPanel.qml	2016-03-14 14:43:44 +0000
@@ -92,7 +92,8 @@
             objectName: "recentSearchesRepeater"
             model: searchHistory
 
-            delegate: ListItem {
+            // FIXME Move to ListItem once 1556971 is fixed
+            delegate: ListItems.Empty {
                 anchors {
                     left: parent.left
                     right: parent.right