Merge lp:~aacid/unity8/launcher_test_remove_dda_constraints into lp:unity8

Proposed by Albert Astals Cid on 2016-01-14
Status: Merged
Approved by: Michał Sawicz on 2016-01-25
Approved revision: 2136
Merged at revision: 2149
Proposed branch: lp:~aacid/unity8/launcher_test_remove_dda_constraints
Merge into: lp:unity8
Diff against target: 12 lines (+2/-0)
1 file modified
tests/qmltests/Launcher/tst_Launcher.qml (+2/-0)
To merge this branch: bzr merge lp:~aacid/unity8/launcher_test_remove_dda_constraints
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing on 2016-01-25
Michał Sawicz 2016-01-14 Approve on 2016-01-25
PS Jenkins bot continuous-integration Needs Fixing on 2016-01-14
Review via email: mp+282600@code.launchpad.net

Commit Message

Remove the DDAs constrains for every test

Since the launcher is loaded/unloaded for every test too

Otherwise tests sometimes fail because of timing

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
N/A

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2136
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/71/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/71/rebuild

review: Approve (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2136
http://jenkins.qa.ubuntu.com/job/unity8-ci/7068/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6026
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/483/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1773
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/476
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1668
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1668
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/475
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/474
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4654
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6037
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6037/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26656
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/227/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/481
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/481/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26657

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7068/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2136
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/71/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/71/rebuild

review: Needs Fixing (continuous-integration)
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y
 * Did CI run pass? If not, please explain why.
Britney was happy with it in CI Train, have restarted the test above
 * Did you make sure that the branch does not contain spurious tags?
Y

review: Approve
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2136
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/196/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/196/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/Launcher/tst_Launcher.qml'
2--- tests/qmltests/Launcher/tst_Launcher.qml 2016-01-06 20:39:20 +0000
3+++ tests/qmltests/Launcher/tst_Launcher.qml 2016-01-14 14:44:47 +0000
4@@ -195,6 +195,8 @@
5
6 // Now do check that snapping is in fact enabled
7 compare(listView.snapMode, ListView.SnapToItem, "Snapping is not enabled");
8+
9+ removeTimeConstraintsFromDirectionalDragAreas(root);
10 }
11
12 function dragLauncherIntoView() {

Subscribers

People subscribed via source and target branches