Merge lp:~aacid/unity8/killOurListItems into lp:unity8

[Albert Astals Cid]

Kill qml/Components/ListItems

ThinDivider can be replaced either by Ubuntu.Components.ListItems.ThinDivider or by an image
Header.qml is renamed to DashSectionHeader and added to the Dash/ folder

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2656
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2306/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3040
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1688
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1688
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1688
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3068
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2925/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2925/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2925/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2925/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2925/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2925/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2925/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2925/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2925
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2925/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2306/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

In general I totally agree with this, but why not using the ThinDivider from the SDK?

review: Needs Information

[Albert Astals Cid (aacid)]

> In general I totally agree with this, but why not using the ThinDivider from
> the SDK?

It is using it for ScopesListCategory.qml

For the Launcher it looked too different (and IMHO worse) given how the Launcher uses a darker theme and was using already a different image than our "custom" ThinDivider

[Michael Zanetti (mzanetti)]

okay then...

* Code change looks good
* tried tryDash and tryLauncher, couldn't spot a visual difference to before
* CI instability is unrelated

review: Approve

=== removed file 'qml/Components/ListItems/ThinDivider.qml'
--- qml/Components/ListItems/ThinDivider.qml	2015-07-15 15:07:19 +0000
+++ qml/Components/ListItems/ThinDivider.qml	1970-01-01 00:00:00 +0000
@@ -1,27 +0,0 @@
-/*
- * Copyright (C) 2012 Canonical, Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-import QtQuick 2.4
-
-Image {
-    anchors {
-        left: (parent) ? parent.left : null
-        right: (parent) ? parent.right : null
-    }
-    height: (visible) ? units.dp(2) : 0
-
-    source: "graphics/ListItemDividerHorizontal.png"
-}

=== removed directory 'qml/Components/ListItems/graphics'
=== removed file 'qml/Components/ListItems/graphics/[e-mail]'
Binary files qml/Components/ListItems/graphics/[e-mail]	2016-06-03 23:00:28 +0000 and qml/Components/ListItems/graphics/[e-mail]	1970-01-01 00:00:00 +0000 differ
=== renamed file 'qml/Components/ListItems/Header.qml' => 'qml/Dash/DashSectionHeader.qml'
=== modified file 'qml/Dash/GenericScopeView.qml'
--- qml/Dash/GenericScopeView.qml	2016-09-22 07:37:21 +0000
+++ qml/Dash/GenericScopeView.qml	2016-10-04 09:36:46 +0000
@@ -22,7 +22,6 @@
 import Unity 0.2
 import Dash 0.1
 import "../Components"
-import "../Components/ListItems" as ListItems
 import "Previews/PreviewSingleton"
 
 FocusScope {
@@ -621,7 +620,7 @@
         }
 
         sectionProperty: "name"
-        sectionDelegate: ListItems.Header {
+        sectionDelegate: DashSectionHeader {
             objectName: "dashSectionHeader" + (delegate ? delegate.category : "")
             property int delegateIndex: -1
             readonly property var delegate: categoryView.item(delegateIndex)

=== modified file 'qml/Dash/ScopesListCategory.qml'
--- qml/Dash/ScopesListCategory.qml	2016-07-27 16:23:18 +0000
+++ qml/Dash/ScopesListCategory.qml	2016-10-04 09:36:46 +0000
@@ -16,9 +16,9 @@
 
 import QtQuick 2.4
 import Ubuntu.Components 1.3
+import Ubuntu.Components.ListItems 1.3 as ListItems
 import Dash 0.1
 import "../Components"
-import "../Components/ListItems" as ListItems
 
 Item {
     id: root
@@ -40,7 +40,7 @@
 
     implicitHeight: visible ? childrenRect.height : 0
 
-    ListItems.Header {
+    DashSectionHeader {
         id: header
         width: root.width
         height: units.gu(5)

=== modified file 'qml/Launcher/LauncherPanel.qml'
--- qml/Launcher/LauncherPanel.qml	2016-08-08 10:42:40 +0000
+++ qml/Launcher/LauncherPanel.qml	2016-10-04 09:36:46 +0000
@@ -18,7 +18,6 @@
 import Ubuntu.Components 1.3
 import Unity.Launcher 0.1
 import Ubuntu.Components.Popups 1.3
-import "../Components/ListItems"
 import "../Components"
 
 Rectangle {
@@ -296,10 +295,11 @@
                             }
                         }
 
-                        ThinDivider {
+                        Image {
                             id: dropIndicator
                             objectName: "dropIndicator"
                             anchors.centerIn: parent
+                            height: visible ? units.dp(2) : 0
                             width: parent.width + mainColumn.anchors.leftMargin + mainColumn.anchors.rightMargin
                             opacity: 0
                             source: "graphics/divider-line.png"