Merge lp:~aacid/unity8/initialize_udevMonitor into lp:unity8
Proposed by
Albert Astals Cid
Status: | Merged |
---|---|
Approved by: | Lukáš Tinkl |
Approved revision: | 2410 |
Merged at revision: | 2464 |
Proposed branch: | lp:~aacid/unity8/initialize_udevMonitor |
Merge into: | lp:unity8 |
Diff against target: |
11 lines (+1/-0) 1 file modified
plugins/Unity/InputInfo/linux/qinputdeviceinfo_linux.cpp (+1/-0) |
To merge this branch: | bzr merge lp:~aacid/unity8/initialize_udevMonitor |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Approve | |
Lukáš Tinkl (community) | Approve | ||
Review via email: mp+295807@code.launchpad.net |
Commit message
initialize udevMonitor
Otherwise constructor+
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
Coverity says "uninit_member: Non-static class member udevMonitor is not initialized in this constructor nor in any functions that it calls."
To post a comment you must log in.
LGTM, always good to init member vars