Merge lp:~aacid/unity8/initialize_physicallyEnded into lp:unity8

Proposed by Albert Astals Cid
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp:~aacid/unity8/initialize_physicallyEnded
Merge into: lp:unity8
Diff against target: 12 lines (+1/-1)
1 file modified
libs/UbuntuGestures/TouchRegistry.h (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity8/initialize_physicallyEnded
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Lukáš Tinkl (community) Approve
Review via email: mp+295802@code.launchpad.net

Commit message

Initialize physicallyEnded in the dummy constructor

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

LGTM

review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

The code moved to the uitk

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

2410. By Albert Astals Cid

Initialize physicallyEnded too in the dummy constructor

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libs/UbuntuGestures/TouchRegistry.h'
2--- libs/UbuntuGestures/TouchRegistry.h 2015-07-20 16:30:40 +0000
3+++ libs/UbuntuGestures/TouchRegistry.h 2016-05-26 08:31:26 +0000
4@@ -155,7 +155,7 @@
5
6 class TouchInfo {
7 public:
8- TouchInfo() : id(-1) {}
9+ TouchInfo() : id(-1), physicallyEnded(false) {}
10 TouchInfo(int id);
11 bool isValid() const { return id >= 0; }
12 void reset();

Subscribers

People subscribed via source and target branches