Merge lp:~aacid/unity8/initialize_nextTimeoutTime into lp:unity8

Proposed by Albert Astals Cid
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp:~aacid/unity8/initialize_nextTimeoutTime
Merge into: lp:unity8
Diff against target: 10 lines (+1/-0)
1 file modified
libs/UbuntuGestures/Timer.cpp (+1/-0)
To merge this branch: bzr merge lp:~aacid/unity8/initialize_nextTimeoutTime
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Lukáš Tinkl (community) Approve
Review via email: mp+295803@code.launchpad.net

Commit message

Initialize m_nextTimeoutTime

It's not really needed since it's only used in update() if start()
has been called that then initializes m_nextTimeoutTime

But it's always nice to initialize all members

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

LGTM, trivial change, it indeed never hurts to init member vars

review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

The code moved to the uitk

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

2410. By Albert Astals Cid

Initialize m_nextTimeoutTime

It's not really needed since it's only used in update() if start()
has been called that then initializes m_nextTimeoutTime

But it's always nice to initialize all members

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libs/UbuntuGestures/Timer.cpp'
2--- libs/UbuntuGestures/Timer.cpp 2015-04-24 13:19:24 +0000
3+++ libs/UbuntuGestures/Timer.cpp 2016-05-26 08:37:20 +0000
4@@ -63,6 +63,7 @@
5 , m_interval(0)
6 , m_singleShot(false)
7 , m_timeSource(timeSource)
8+ , m_nextTimeoutTime(0)
9 {
10 }
11

Subscribers

People subscribed via source and target branches