Merge lp:~aacid/unity8/initialize_nextTimeoutTime into lp:unity8
Status: | Rejected |
---|---|
Rejected by: | Albert Astals Cid |
Proposed branch: | lp:~aacid/unity8/initialize_nextTimeoutTime |
Merge into: | lp:unity8 |
Diff against target: |
10 lines (+1/-0) 1 file modified
libs/UbuntuGestures/Timer.cpp (+1/-0) |
To merge this branch: | bzr merge lp:~aacid/unity8/initialize_nextTimeoutTime |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Needs Fixing | |
Lukáš Tinkl (community) | Approve | ||
Review via email: mp+295803@code.launchpad.net |
Commit message
Initialize m_nextTimeoutTime
It's not really needed since it's only used in update() if start()
has been called that then initializes m_nextTimeoutTime
But it's always nice to initialize all members
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
Unmerged revisions
- 2410. By Albert Astals Cid
-
Initialize m_nextTimeoutTime
It's not really needed since it's only used in update() if start()
has been called that then initializes m_nextTimeoutTimeBut it's always nice to initialize all members
LGTM, trivial change, it indeed never hurts to init member vars