Merge lp:~aacid/unity8/initializeSomeMockMembers into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 2892
Merged at revision: 2907
Proposed branch: lp:~aacid/unity8/initializeSomeMockMembers
Merge into: lp:unity8
Diff against target: 19 lines (+8/-1)
1 file modified
tests/plugins/WindowManager/UnityApplicationMocks.h (+8/-1)
To merge this branch: bzr merge lp:~aacid/unity8/initializeSomeMockMembers
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Daniel d'Andrada (community) Approve
Review via email: mp+320905@code.launchpad.net

Commit message

UnityApplicationMocks: Initialize m_state and m_requestedState

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Daniel d'Andrada (dandrader) :
review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2892
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3522/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4663
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2819
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2819
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4691
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4514
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4514/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4514
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4514/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4514
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4514/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4514
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4514/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4514
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4514/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4514
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4514/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3522/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/plugins/WindowManager/UnityApplicationMocks.h'
2--- tests/plugins/WindowManager/UnityApplicationMocks.h 2017-03-16 15:30:33 +0000
3+++ tests/plugins/WindowManager/UnityApplicationMocks.h 2017-03-24 09:50:09 +0000
4@@ -95,7 +95,14 @@
5 {
6 Q_OBJECT
7 public:
8- Application(QString appId) : ApplicationInfoInterface(appId, nullptr), m_appId(std::move(appId)) {}
9+ Application(QString appId)
10+ : ApplicationInfoInterface(appId, nullptr)
11+ , m_appId(std::move(appId))
12+ , m_state(Starting)
13+ , m_requestedState(RequestedRunning)
14+ {
15+
16+ }
17
18 void close() override {}
19 QString appId() const override { return m_appId;}

Subscribers

People subscribed via source and target branches