Merge lp:~aacid/unity8/hack_location_data_i18n into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 1599
Merged at revision: 1616
Proposed branch: lp:~aacid/unity8/hack_location_data_i18n
Merge into: lp:unity8
Diff against target: 311 lines (+86/-74)
2 files modified
po/unity8.pot (+83/-73)
qml/Dash/ScopeSettings/ScopeSettingBoolean.qml (+3/-1)
To merge this branch: bzr merge lp:~aacid/unity8/hack_location_data_i18n
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+249174@code.launchpad.net

Commit message

Hardcode tranlsation for internal.location field

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
yes, no regressions
 * Did CI run pass? If not, please explain why.
y
 * Did you make sure that the branch does not contain spurious tags?
y

review: Approve
Revision history for this message
Andrea Cimitan (cimi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/unity8.pot'
2--- po/unity8.pot 2015-01-22 10:09:56 +0000
3+++ po/unity8.pot 2015-02-13 10:45:38 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: unity8\n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2015-01-22 11:09+0100\n"
9+"POT-Creation-Date: 2015-02-13 11:45+0100\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13@@ -18,7 +18,7 @@
14 "Content-Transfer-Encoding: 8bit\n"
15 "Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
16
17-#: plugins/LightDM/Greeter.cpp:130
18+#: plugins/LightDM/Greeter.cpp:112
19 msgid "Password: "
20 msgstr ""
21
22@@ -106,52 +106,6 @@
23 msgid "Cancel"
24 msgstr ""
25
26-#: qml/Components/EdgeDemoOverlay.qml:151
27-msgid "Skip intro"
28-msgstr ""
29-
30-#: qml/Components/EdgeDemo.qml:125
31-msgid "Right edge"
32-msgstr ""
33-
34-#: qml/Components/EdgeDemo.qml:126
35-msgid "Try swiping from the right edge to unlock the phone"
36-msgstr ""
37-
38-#: qml/Components/EdgeDemo.qml:157
39-msgid "Top edge"
40-msgstr ""
41-
42-#: qml/Components/EdgeDemo.qml:158
43-msgid "Try swiping from the top edge to access the indicators"
44-msgstr ""
45-
46-#: qml/Components/EdgeDemo.qml:183
47-msgid "Close"
48-msgstr ""
49-
50-#: qml/Components/EdgeDemo.qml:184
51-msgid "Swipe up again to close the settings screen"
52-msgstr ""
53-
54-#: qml/Components/EdgeDemo.qml:214
55-msgid "Left edge"
56-msgstr ""
57-
58-#: qml/Components/EdgeDemo.qml:215
59-msgid "Swipe from the left to reveal the launcher for quick access to apps"
60-msgstr ""
61-
62-#: qml/Components/EdgeDemo.qml:242
63-msgid "Well done"
64-msgstr ""
65-
66-#: qml/Components/EdgeDemo.qml:243
67-msgid ""
68-"You have now mastered the edge gestures and can start using the "
69-"phone<br><br>Tap on the screen to start"
70-msgstr ""
71-
72 #: qml/Components/Lockscreen.qml:238
73 msgid "Return to Call"
74 msgstr ""
75@@ -164,32 +118,32 @@
76 msgid "OK"
77 msgstr ""
78
79-#: qml/Dash/GenericScopeView.qml:485 qml/Dash/GenericScopeView.qml:642
80+#: qml/Dash/GenericScopeView.qml:528 qml/Dash/GenericScopeView.qml:686
81 msgid "See less"
82 msgstr ""
83
84-#: qml/Dash/GenericScopeView.qml:485
85+#: qml/Dash/GenericScopeView.qml:528
86 msgid "See all"
87 msgstr ""
88
89-#: qml/Dash/GenericScopeView.qml:547 qml/Dash/PageHeader.qml:274
90+#: qml/Dash/GenericScopeView.qml:590 qml/Dash/PageHeader.qml:276
91 #: qml/Panel/SearchIndicator.qml:27
92 msgid "Search"
93 msgstr ""
94
95-#: qml/Dash/PageHeader.qml:267
96+#: qml/Dash/PageHeader.qml:269
97 msgid "Store"
98 msgstr ""
99
100-#: qml/Dash/PageHeader.qml:284
101+#: qml/Dash/PageHeader.qml:286
102 msgid "Settings"
103 msgstr ""
104
105-#: qml/Dash/PageHeader.qml:291
106+#: qml/Dash/PageHeader.qml:293
107 msgid "Remove from Favorites"
108 msgstr ""
109
110-#: qml/Dash/PageHeader.qml:291
111+#: qml/Dash/PageHeader.qml:293
112 msgid "Add to Favorites"
113 msgstr ""
114
115@@ -221,6 +175,10 @@
116 msgid "Release to refresh…"
117 msgstr ""
118
119+#: qml/Dash/ScopeSettings/ScopeSettingBoolean.qml:43
120+msgid "Enable location data"
121+msgstr ""
122+
123 #: qml/Dash/ScopesList.qml:66
124 msgid "Manage"
125 msgstr ""
126@@ -233,7 +191,7 @@
127 msgid "Also installed"
128 msgstr ""
129
130-#: qml/Greeter/Greeter.qml:133
131+#: qml/Greeter/Greeter.qml:141
132 msgid "Unlock"
133 msgstr ""
134
135@@ -289,60 +247,112 @@
136 msgid "Roaming"
137 msgstr ""
138
139-#: qml/Shell.qml:390
140+#: qml/Shell.qml:402
141 #, qt-format
142 msgid "Enter %1"
143 msgstr ""
144
145-#: qml/Shell.qml:391 qml/Wizard/Pages/passwd-set.qml:60
146+#: qml/Shell.qml:403 qml/Wizard/Pages/passwd-set.qml:60
147 msgid "Enter passphrase"
148 msgstr ""
149
150-#: qml/Shell.qml:392
151+#: qml/Shell.qml:404
152 msgid "Enter passcode"
153 msgstr ""
154
155-#: qml/Shell.qml:393
156+#: qml/Shell.qml:405
157 #, qt-format
158 msgid "Sorry, incorrect %1"
159 msgstr ""
160
161-#: qml/Shell.qml:394
162+#: qml/Shell.qml:406
163 msgid "Sorry, incorrect passphrase"
164 msgstr ""
165
166-#: qml/Shell.qml:395
167+#: qml/Shell.qml:407
168 msgid "Please re-enter"
169 msgstr ""
170
171-#: qml/Shell.qml:396
172+#: qml/Shell.qml:408
173 msgid "Sorry, incorrect passcode"
174 msgstr ""
175
176-#: qml/Shell.qml:490 qml/Wizard/Pages/passwd-confirm.qml:53
177+#: qml/Shell.qml:502 qml/Wizard/Pages/passwd-confirm.qml:53
178 msgid "Sorry, incorrect passphrase."
179 msgstr ""
180
181-#: qml/Shell.qml:491 qml/Wizard/Pages/passwd-confirm.qml:54
182+#: qml/Shell.qml:503 qml/Wizard/Pages/passwd-confirm.qml:54
183 msgid "Sorry, incorrect passcode."
184 msgstr ""
185
186-#: qml/Shell.qml:492
187+#: qml/Shell.qml:504
188 msgid "This will be your last attempt."
189 msgstr ""
190
191-#: qml/Shell.qml:494
192+#: qml/Shell.qml:506
193 msgid ""
194 "If passphrase is entered incorrectly, your phone will conduct a factory "
195 "reset and all personal data will be deleted."
196 msgstr ""
197
198-#: qml/Shell.qml:495
199+#: qml/Shell.qml:507
200 msgid ""
201 "If passcode is entered incorrectly, your phone will conduct a factory reset "
202 "and all personal data will be deleted."
203 msgstr ""
204
205+#: qml/Tutorial/TutorialBottomFinish.qml:24
206+msgid "This action does different things for different apps"
207+msgstr ""
208+
209+#: qml/Tutorial/TutorialBottomFinish.qml:25
210+msgid "Tap here to finish."
211+msgstr ""
212+
213+#: qml/Tutorial/TutorialBottom.qml:28
214+msgid "Open special menus"
215+msgstr ""
216+
217+#: qml/Tutorial/TutorialBottom.qml:29
218+msgid "Swipe up from the bottom edge."
219+msgstr ""
220+
221+#: qml/Tutorial/TutorialLeftFinish.qml:24
222+msgid "These are the shortcuts to favorite apps"
223+msgstr ""
224+
225+#: qml/Tutorial/TutorialLeftFinish.qml:25 qml/Tutorial/TutorialRight.qml:144
226+msgid "Tap here to continue."
227+msgstr ""
228+
229+#: qml/Tutorial/TutorialLeft.qml:26
230+msgid "Open the launcher"
231+msgstr ""
232+
233+#: qml/Tutorial/TutorialLeft.qml:27
234+msgid "Short swipe from the left edge."
235+msgstr ""
236+
237+#: qml/Tutorial/TutorialPage.qml:178
238+msgid "You almost got it!"
239+msgstr ""
240+
241+#: qml/Tutorial/TutorialPage.qml:195
242+msgid "Try again."
243+msgstr ""
244+
245+#: qml/Tutorial/TutorialRight.qml:31
246+msgid "To view open apps"
247+msgstr ""
248+
249+#: qml/Tutorial/TutorialRight.qml:32
250+msgid "Long swipe from the right edge."
251+msgstr ""
252+
253+#: qml/Tutorial/TutorialRight.qml:122
254+msgid "View all your running tasks."
255+msgstr ""
256+
257 #: qml/Wizard/Page.qml:89
258 msgid "Back"
259 msgstr ""
260@@ -360,7 +370,7 @@
261 msgstr ""
262
263 #: qml/Wizard/Pages/10-welcome.qml:88 qml/Wizard/Pages/30-passwd-type.qml:128
264-#: qml/Wizard/Pages/40-wifi.qml:197 qml/Wizard/Pages/50-location.qml:131
265+#: qml/Wizard/Pages/40-wifi.qml:215 qml/Wizard/Pages/50-location.qml:131
266 #: qml/Wizard/Pages/60-reporting.qml:50 qml/Wizard/Pages/passwd-confirm.qml:82
267 #: qml/Wizard/Pages/passwd-set.qml:90
268 msgid "Continue"
269@@ -374,7 +384,7 @@
270 msgid "Without it, you won’t be able to make calls or use text messaging."
271 msgstr ""
272
273-#: qml/Wizard/Pages/20-sim.qml:69 qml/Wizard/Pages/40-wifi.qml:197
274+#: qml/Wizard/Pages/20-sim.qml:69 qml/Wizard/Pages/40-wifi.qml:215
275 msgid "Skip"
276 msgstr ""
277
278@@ -410,15 +420,15 @@
279 msgid "Numbers and letters"
280 msgstr ""
281
282-#: qml/Wizard/Pages/40-wifi.qml:28
283+#: qml/Wizard/Pages/40-wifi.qml:29
284 msgid "Connect to Wi‑Fi"
285 msgstr ""
286
287-#: qml/Wizard/Pages/40-wifi.qml:147
288+#: qml/Wizard/Pages/40-wifi.qml:168
289 msgid "Available networks…"
290 msgstr ""
291
292-#: qml/Wizard/Pages/40-wifi.qml:148
293+#: qml/Wizard/Pages/40-wifi.qml:169
294 msgid "No available networks."
295 msgstr ""
296
297
298=== modified file 'qml/Dash/ScopeSettings/ScopeSettingBoolean.qml'
299--- qml/Dash/ScopeSettings/ScopeSettingBoolean.qml 2014-08-26 12:27:36 +0000
300+++ qml/Dash/ScopeSettings/ScopeSettingBoolean.qml 2015-02-13 10:45:38 +0000
301@@ -38,7 +38,9 @@
302 rightMargin: units.gu(1)
303 verticalCenter: parent.verticalCenter
304 }
305- text: widgetData.displayName
306+ // TODO The translation should ideally come from the bottom layers and not be hardcoded here
307+ // https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1393438
308+ text: widgetData.settingId == "internal.location" ? i18n.tr("Enable location data") : widgetData.displayName
309 elide: Text.ElideMiddle
310 maximumLineCount: 2
311 wrapMode: Text.Wrap

Subscribers

People subscribed via source and target branches