Unity 8

Merge lp:~aacid/unity8/flaky_gsv_test into lp:unity8

  1. flaky_gsv_test
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Michał Sawicz
Approved revision: 916
Merged at revision: 927
Proposed branch: lp:~aacid/unity8/flaky_gsv_test
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
tests/qmltests/Dash/tst_GenericScopeView.qml (+1/-0)
To merge this branch: bzr merge lp:~aacid/unity8/flaky_gsv_test
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+220767@code.launchpad.net

Commit message

GenericScopeViewTest: Wait a bit more

Otherwise sometimes we end getting up the wrong delegate (maybe one that will be garbage collected?)

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes, test is more stable here

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:916
http://jenkins.qa.ubuntu.com/job/unity8-ci/3029/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/430
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/123
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/123
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/123/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/123
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/893
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/855
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/855/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/7574

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3029/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
N/A

 * Did CI run pass? If not, please explain why.
Known failures, this test is fixed though.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/Dash/tst_GenericScopeView.qml'
2--- tests/qmltests/Dash/tst_GenericScopeView.qml 2014-05-22 17:59:15 +0000
3+++ tests/qmltests/Dash/tst_GenericScopeView.qml 2014-05-23 08:16:55 +0000
4@@ -126,6 +126,7 @@
5
6 function test_filter_expand_collapse() {
7 // wait for the item to be there
8+ waitForRendering(genericScopeView);
9 tryCompareFunction(function() { return findChild(genericScopeView, "dashSectionHeader0") != null; }, true);
10
11 var header = findChild(genericScopeView, "dashSectionHeader0")

Subscribers

People subscribed via source and target branches