Merge lp:~aacid/unity8/fixuninitializedvalues into lp:unity8

[Albert Astals Cid]

Fix uses of uninitialized values reported by valgrind

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:166
http://jenkins.qa.ubuntu.com/job/unity8-ci/507/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1926
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/932/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/508
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/508/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/507
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1931
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1931/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1645

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/507/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:166
http://jenkins.qa.ubuntu.com/job/unity8-ci/516/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1948
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/943
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/517
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/517/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/516
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1953
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1953/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1666

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/516/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

6 template <class Type> class Damper {
7 public:
8 + Damper() : m_value(0), m_maxDelta(0) { }

I think this breaks compilation for non-numeric templates like Damper<QString> . I agree that the whole class is not really useful anyways in such cases...

[Michael Zanetti (mzanetti)]

ok... this whole thing is really tailored for numeric values....

review: Approve

=== modified file 'plugins/Ubuntu/Gestures/Damper.h'
--- plugins/Ubuntu/Gestures/Damper.h	2013-06-05 22:03:08 +0000
+++ plugins/Ubuntu/Gestures/Damper.h	2013-08-06 13:22:48 +0000
@@ -24,6 +24,8 @@
  */
 template <class Type> class Damper {
 public:
+    Damper() : m_value(0), m_maxDelta(0) { }
+
     // Maximum delta between the raw value and its dampened counterpart.
     void setMaxDelta(Type maxDelta) {
         if (maxDelta < 0) qFatal("Damper::maxDelta must be a positive number.");

=== modified file 'tests/mocks/Ubuntu/Application/ApplicationInfo.cpp'
--- tests/mocks/Ubuntu/Application/ApplicationInfo.cpp	2013-06-05 22:03:08 +0000
+++ tests/mocks/Ubuntu/Application/ApplicationInfo.cpp	2013-08-06 13:22:48 +0000
@@ -23,6 +23,7 @@
 
 ApplicationInfo::ApplicationInfo(QObject *parent)
     : QObject(parent)
+     ,m_handle(0)
      ,m_stage(MainStage)
      ,m_state(Starting)
      ,m_fullscreen(false)