Merge lp:~aacid/unity8/fix_uninit_var_scope into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Michal Hruby
Approved revision: 442
Merged at revision: 442
Proposed branch: lp:~aacid/unity8/fix_uninit_var_scope
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
plugins/Unity/scope.cpp (+1/-0)
To merge this branch: bzr merge lp:~aacid/unity8/fix_uninit_var_scope
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Paweł Stołowski (community) Approve
Michal Hruby (community) Approve
Review via email: mp+190660@code.launchpad.net

Commit message

Fix unitialized variable in Scope

==18457== Conditional jump or move depends on uninitialised value(s)
==18457== at 0x15AD1FD6: Scope::setActive(bool) (scope.cpp:165)
==18457== by 0x15B0023D: Scope::qt_metacall(QMetaObject::Call, int, void**) (moc_scope.cpp:478)
==18457== by 0x48B709F: QQmlPropertyPrivate::write(QObject*, QQmlPropertyData const&, QVariant const&, QQmlContextData*, QFlags<QQmlPropertyPrivate::WriteFlag>) (in /usr/lib/arm-linux-gnueabihf/libQt5Qml.so.5.0.2)

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

+1

review: Approve
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:442
http://jenkins.qa.ubuntu.com/job/unity8-ci/1368/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4947/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2848
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2234
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/391
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1368
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1368/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1367
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/1123/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/822
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/822/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2850
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2850/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2369
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2409

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1368/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/Unity/scope.cpp'
2--- plugins/Unity/scope.cpp 2013-10-07 10:09:21 +0000
3+++ plugins/Unity/scope.cpp 2013-10-11 13:46:31 +0000
4@@ -40,6 +40,7 @@
5
6 Scope::Scope(QObject *parent) : QObject(parent)
7 , m_formFactor("phone")
8+ , m_isActive(false)
9 , m_searchInProgress(false)
10 {
11 m_categories.reset(new Categories(this));

Subscribers

People subscribed via source and target branches