Merge lp:~aacid/unity8/fix_tstDash into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Michael Terry
Approved revision: 887
Merged at revision: 901
Proposed branch: lp:~aacid/unity8/fix_tstDash
Merge into: lp:unity8
Diff against target: 12 lines (+1/-1)
1 file modified
tests/qmltests/Dash/tst_Dash.qml (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity8/fix_tstDash
Reviewer Review Type Date Requested Status
Michael Terry Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+219296@code.launchpad.net

Commit message

Set the tabbarmodel index as we do on real code

It works better :D

Description of the change

* Are there any related MPs required for this MP to build/function as expected?
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
N/A, test code only

* Did you make sure that your branch does not contain spurious tags?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

* If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

Looks good to me!

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 - Yes, ran qmluitests

 * Did CI run pass? If not, please explain why.
 - No, because of other qmluitest failures

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/Dash/tst_Dash.qml'
2--- tests/qmltests/Dash/tst_Dash.qml 2014-04-14 13:21:55 +0000
3+++ tests/qmltests/Dash/tst_Dash.qml 2014-05-13 07:48:19 +0000
4@@ -127,7 +127,7 @@
5 var dashContent = findChild(dash, "dashContent");
6 var current_index = dashContent.currentIndex;
7
8- tabbar.selectedIndex = data.visualIndex;
9+ tabbar.model.selectedIndex = data.visualIndex;
10 compare(dashContent.currentIndex, data.shouldBeVisible ? data.visualIndex : current_index);
11 }
12 }

Subscribers

People subscribed via source and target branches