Merge lp:~aacid/unity8/fix_test_focusAppFromLauncherExitsSpread into lp:unity8

Proposed by Albert Astals Cid on 2016-01-12
Status: Merged
Approved by: Michael Zanetti on 2016-01-12
Approved revision: 2114
Merged at revision: 2145
Proposed branch: lp:~aacid/unity8/fix_test_focusAppFromLauncherExitsSpread
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
tests/qmltests/tst_Shell.qml (+1/-0)
To merge this branch: bzr merge lp:~aacid/unity8/fix_test_focusAppFromLauncherExitsSpread
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing on 2016-01-15
PS Jenkins bot continuous-integration Needs Fixing on 2016-01-12
Michael Zanetti (community) 2016-01-12 Approve on 2016-01-12
Review via email: mp+282292@code.launchpad.net

Commit Message

Move the mouse over the bfb before waiting for rendering

If the rendering takes too much the dismissTimer will kick and hide the launcher if we're not over the bfb already making the rest of the test fail

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Michael Zanetti (mzanetti) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

the touched one passes here, unlikely this causes other failures.

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:2114
http://jenkins.qa.ubuntu.com/job/unity8-ci/7046/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5994
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/461/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1751
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/454
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1646
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1646
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/453
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/452
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4630
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6005
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6005/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26574
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/209/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/459
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/459/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26573

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7046/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2114
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/85/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/85/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/tst_Shell.qml'
2--- tests/qmltests/tst_Shell.qml 2015-12-08 15:37:51 +0000
3+++ tests/qmltests/tst_Shell.qml 2016-01-12 11:57:29 +0000
4@@ -1731,6 +1731,7 @@
5
6 revealLauncherByEdgePushWithMouse();
7 tryCompare(launcher, "x", 0);
8+ mouseMove(bfb, bfb.width / 2, bfb.height / 2)
9 waitForRendering(shell)
10
11 mouseClick(bfb, bfb.width / 2, bfb.height / 2)

Subscribers

People subscribed via source and target branches