Merge lp:~aacid/unity8/fix_make_try_warning into lp:unity8

Proposed by Albert Astals Cid on 2015-07-08
Status: Merged
Approved by: Andrea Cimitan on 2015-07-09
Approved revision: 1848
Merged at revision: 1874
Proposed branch: lp:~aacid/unity8/fix_make_try_warning
Merge into: lp:unity8
Diff against target: 49 lines (+18/-1)
2 files modified
tests/uqmlscene/CMakeLists.txt (+1/-0)
tests/uqmlscene/main.cpp (+17/-1)
To merge this branch: bzr merge lp:~aacid/unity8/fix_make_try_warning
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) 2015-07-08 Approve on 2015-07-09
PS Jenkins bot continuous-integration Needs Fixing on 2015-07-08
Review via email: mp+264139@code.launchpad.net

Commit Message

Fix warning when doing make try*

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, thanks removes the warning
 * Did CI run pass? If not, please explain why.
AP
 * Did you make sure that the branch does not contain spurious tags?
Y

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/uqmlscene/CMakeLists.txt'
2--- tests/uqmlscene/CMakeLists.txt 2015-04-01 11:25:54 +0000
3+++ tests/uqmlscene/CMakeLists.txt 2015-07-08 13:04:38 +0000
4@@ -8,6 +8,7 @@
5 pkg_check_modules(XCB REQUIRED xcb)
6
7 include_directories(
8+ ${CMAKE_CURRENT_BINARY_DIR}
9 ${CMAKE_SOURCE_DIR}/src
10 ${Qt5Gui_PRIVATE_INCLUDE_DIRS}
11 ${CMAKE_SOURCE_DIR}/libs/UbuntuGestures
12
13=== modified file 'tests/uqmlscene/main.cpp'
14--- tests/uqmlscene/main.cpp 2015-06-12 16:07:43 +0000
15+++ tests/uqmlscene/main.cpp 2015-07-08 13:04:38 +0000
16@@ -345,12 +345,26 @@
17 }
18 }
19
20+class DummyTestRootObject : public QObject
21+{
22+ Q_OBJECT
23+ Q_PROPERTY(bool windowShown READ windowShown NOTIFY windowShownChanged)
24+
25+public:
26+ DummyTestRootObject(QObject *o) : QObject(o) {}
27+
28+ bool windowShown() const { return false; }
29+
30+Q_SIGNALS:
31+ void windowShownChanged();
32+};
33+
34 static QObject *s_testRootObject = nullptr;
35 static QObject *testRootObject(QQmlEngine *engine, QJSEngine *jsEngine)
36 {
37 Q_UNUSED(jsEngine);
38 if (!s_testRootObject) {
39- s_testRootObject = new QObject(engine);
40+ s_testRootObject = new DummyTestRootObject(engine);
41 }
42 return s_testRootObject;
43 }
44@@ -560,3 +574,5 @@
45
46 return exitCode;
47 }
48+
49+#include "main.moc"

Subscribers

People subscribed via source and target branches