Merge lp:~aacid/unity8/fix_lazyimagetest_53 into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Michał Sawicz
Approved revision: 976
Merged at revision: 992
Proposed branch: lp:~aacid/unity8/fix_lazyimagetest_53
Merge into: lp:unity8
Diff against target: 11 lines (+0/-1)
1 file modified
tests/qmltests/Components/tst_LazyImage.qml (+0/-1)
To merge this branch: bzr merge lp:~aacid/unity8/fix_lazyimagetest_53
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+223896@code.launchpad.net

Commit message

Don't seem to need this waitForRendering

And makes test fail in 5.3

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Ran test in a loop for a while, no errors

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes. Test passes.

 * Did CI run pass? If not, please explain why.
No, other 5.3 failures :|

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/Components/tst_LazyImage.qml'
2--- tests/qmltests/Components/tst_LazyImage.qml 2014-06-02 13:26:01 +0000
3+++ tests/qmltests/Components/tst_LazyImage.qml 2014-06-20 10:53:33 +0000
4@@ -152,7 +152,6 @@
5
6 function test_lazyimage(data) {
7 data.func();
8- waitForRendering(baseRect);
9
10 if (data.transition) {
11 // wait for the transition to complete

Subscribers

People subscribed via source and target branches