Merge lp:~aacid/unity8/fix_gsv_test into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Michael Zanetti
Approved revision: 1288
Merged at revision: 1293
Proposed branch: lp:~aacid/unity8/fix_gsv_test
Merge into: lp:unity8
Diff against target: 11 lines (+1/-1)
1 file modified
tests/qmltests/Dash/tst_GenericScopeView.qml (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity8/fix_gsv_test
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+235580@code.launchpad.net

Commit message

Fix seeAll test

We made the header a bit bigger

Description of the change

* Are there any related MPs required for this MP to build/function as expected?
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
Test only

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

yup

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes. test passing now

 * Did CI run pass? If not, please explain why.

no, other failures still

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/Dash/tst_GenericScopeView.qml'
2--- tests/qmltests/Dash/tst_GenericScopeView.qml 2014-09-18 21:23:55 +0000
3+++ tests/qmltests/Dash/tst_GenericScopeView.qml 2014-09-23 09:01:47 +0000
4@@ -496,7 +496,7 @@
5 mouseClick(seeAll0, seeAll0.width / 2, seeAll0.height / 2);
6 verify(category0.expanded);
7 tryCompare(category0, "height", category0.item.expandedHeight + seeAll0.height);
8- tryCompare(genericScopeView.categoryView, "contentY", units.gu(13.5));
9+ tryCompare(genericScopeView.categoryView, "contentY", units.gu(14));
10
11 scrollToEnd();
12

Subscribers

People subscribed via source and target branches