Merge lp:~aacid/unity8/fix_cursor_noise into lp:unity8

Proposed by Albert Astals Cid on 2015-11-19
Status: Merged
Approved by: Daniel d'Andrada on 2015-11-19
Approved revision: 2040
Merged at revision: 2066
Proposed branch: lp:~aacid/unity8/fix_cursor_noise
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
plugins/Cursor/CursorImageProvider.cpp (+1/-0)
To merge this branch: bzr merge lp:~aacid/unity8/fix_cursor_noise
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) 2015-11-19 Approve on 2015-11-19
Review via email: mp+277982@code.launchpad.net

Commit Message

Initialize the image to be transparent

Otherwise since we're not painting all the pixels we get noise

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Daniel d'Andrada (dandrader) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/Cursor/CursorImageProvider.cpp'
2--- plugins/Cursor/CursorImageProvider.cpp 2015-09-29 13:45:05 +0000
3+++ plugins/Cursor/CursorImageProvider.cpp 2015-11-19 12:04:19 +0000
4@@ -42,6 +42,7 @@
5 "</svg>";
6
7 qimage = QImage(20, 32, QImage::Format_ARGB32);
8+ qimage.fill(Qt::transparent);
9 QPainter imagePainter(&qimage);
10
11 QSvgRenderer *svgRenderer = new QSvgRenderer(QByteArray(svgString));

Subscribers

People subscribed via source and target branches