Merge lp:~aacid/unity8/fixUnminimizePosition into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Lukáš Tinkl |
| Approved revision: | 2870 |
| Merged at revision: | 2894 |
| Proposed branch: | lp:~aacid/unity8/fixUnminimizePosition |
| Merge into: | lp:unity8 |
| Prerequisite: | lp:~lukas-kde/unity8/fix-restore-position |
| Diff against target: |
11 lines (+1/-0) 1 file modified
qml/Stage/Stage.qml (+1/-0) |
| To merge this branch: | bzr merge lp:~aacid/unity8/fixUnminimizePosition |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lukáš Tinkl (community) | Approve | ||
| Unity8 CI Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Fix unminimizing going to the wrong position the second time
This was caused by the "restored" state property changes being "restored" to the old values when going to the "minimized" state
Since we're only interested in the "enter" state changes for the windowedX/Y values we set restoreEntryValues to false
Description of the change
It makes for easier testing if you set the value of animationDuration in Stage.qml to a big value like 2500
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
FAILED: Continuous integration, rev:2870
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/