Merge lp:~aacid/unity8/fixLauncherUpDownKeys into lp:unity8
Proposed by
Albert Astals Cid
Status: | Approved |
---|---|
Approved by: | Andrea Cimitan |
Approved revision: | 2915 |
Proposed branch: | lp:~aacid/unity8/fixLauncherUpDownKeys |
Merge into: | lp:unity8 |
Prerequisite: | lp:~aacid/unity8/closeQuicklistOnFocusMove |
Diff against target: |
126 lines (+46/-11) 2 files modified
qml/Launcher/LauncherPanel.qml (+11/-10) tests/qmltests/Launcher/tst_Launcher.qml (+35/-1) |
To merge this branch: | bzr merge lp:~aacid/unity8/fixLauncherUpDownKeys |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Cimitan (community) | Approve | ||
Unity8 CI Bot | continuous-integration | Approve | |
Review via email: mp+321883@code.launchpad.net |
Commit message
Fix Up/Down after Tab with quicklist open
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
Prereq
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Unmerged revisions
- 2915. By Albert Astals Cid
-
Fix Up/Down after Tab with quicklist open
- 2914. By Albert Astals Cid
-
Hide quicklist when launcher index changes
While at it fix a few verify calls that wanted to be compare
PASSED: Continuous integration, rev:2915 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3669/ /unity8- jenkins. ubuntu. com/job/ build/4870 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= xenial+ overlay, testname= qmluitests. sh/2986 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= zesty,testname= qmluitests. sh/2986 /unity8- jenkins. ubuntu. com/job/ build-0- fetch/4898 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 4709 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 4709/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= zesty/4709 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= zesty/4709/ artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 4709 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 4709/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= zesty/4709 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= zesty/4709/ artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 4709 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 4709/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= zesty/4709 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= zesty/4709/ artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3669/ rebuild
https:/