Merge lp:~aacid/unity8/enterSpreadTest into lp:unity8

Proposed by Albert Astals Cid on 2015-01-09
Status: Merged
Approved by: Michał Sawicz on 2015-01-09
Approved revision: 1525
Merged at revision: 1540
Proposed branch: lp:~aacid/unity8/enterSpreadTest
Merge into: lp:unity8
Diff against target: 19 lines (+2/-0)
1 file modified
tests/qmltests/Stages/tst_PhoneStage.qml (+2/-0)
To merge this branch: bzr merge lp:~aacid/unity8/enterSpreadTest
Reviewer Review Type Date Requested Status
Michał Sawicz 2015-01-09 Approve on 2015-01-09
Review via email: mp+245928@code.launchpad.net

Commit Message

Test: Make sure the mouse area is enabled before clicking into it

Despite the name swipeToCloseEnabled controls the enabled property of the whole mouse area
of the spread delegate so it needs to be true (animations & movement finished) before we can click on it

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
No, it's only a test change. I checked that looping the test doesn't seem to be flacky anymore

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y
 * Did CI run pass? If not, please explain why.
Not yet
 * Did you make sure that the branch does not contain spurious tags?
Y

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/Stages/tst_PhoneStage.qml'
2--- tests/qmltests/Stages/tst_PhoneStage.qml 2014-12-02 08:45:11 +0000
3+++ tests/qmltests/Stages/tst_PhoneStage.qml 2015-01-09 08:34:24 +0000
4@@ -205,6 +205,7 @@
5
6 if (data.targetPhase == 2) {
7 var app2 = findChild(spreadView, "appDelegate2");
8+ tryCompare(app2, "swipeToCloseEnabled", true);
9 mouseClick(app2, units.gu(1), units.gu(1));
10 }
11
12@@ -249,6 +250,7 @@
13 }
14
15 console.log("clicking app", data.index, "(", appId, ")")
16+ tryCompare(tile, "swipeToCloseEnabled", true);
17 mouseClick(spreadView, tile.mapToItem(spreadView).x + units.gu(1), spreadView.height / 2)
18 tryCompare(ApplicationManager, "focusedApplicationId", appId);
19 tryCompare(spreadView, "phase", 0);

Subscribers

People subscribed via source and target branches