Unity 8

Merge lp:~aacid/unity8/dropgcc49more into lp:unity8

  1. dropgcc49more
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Michael Zanetti
Approved revision: 1917
Merged at revision: 1925
Proposed branch: lp:~aacid/unity8/dropgcc49more
Merge into: lp:unity8
Diff against target: 14 lines (+0/-5)
1 file modified
debian/rules (+0/-5)
To merge this branch: bzr merge lp:~aacid/unity8/dropgcc49more
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Zanetti (community) Approve
Matthias Klose Pending
Review via email: mp+268047@code.launchpad.net

Commit message

Drop gcc 4.9 requirement in debian/rules

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

FWIW

[11:38:30] <tsdgeos> doko: is https://code.launchpad.net/~aacid/unity8/dropgcc49more/+merge/268047 correct? i think i've seen some other projects do this too
[11:39:23] <doko> tsdgeos, yes

Revision history for this message
Michael Zanetti (mzanetti) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes, still builds for me.

 * Did CI run pass? If not, please explain why.

nope. ci broken atm :(

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1917
http://jenkins.qa.ubuntu.com/job/unity8-ci/6195/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/545/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-wily/225/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/434/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/435/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/545/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6195/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/rules'
2--- debian/rules 2015-04-22 21:34:05 +0000
3+++ debian/rules 2015-08-14 09:37:55 +0000
4@@ -8,11 +8,6 @@
5 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
6 export NO_PNG_PKG_MANGLE=1
7
8-# Explicitly selecting a G{CC,++}-version here to avoid accidental
9-# ABI breaks introduced by toolchain updates.
10-export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
11-export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
12-
13 %:
14 dh $@ --parallel --fail-missing --with python3
15

Subscribers

People subscribed via source and target branches