Merge lp:~aacid/unity8/do_not_animate_panel_color_startup into lp:unity8

[Albert Astals Cid]

Set the theme earlier

This way we avoid some flashing/animating of colors because of the theme change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Michael Terry (mterry)]

Could you avoid relying on "startingUp" from the shell by just avoiding animating color until the Panel object is Component.onCompleted?

[Michael Terry (mterry)]

Oh, I see we set the theme on Shell.onCompleted. But why do we do that? Can't we just set theme as a binding from the get go? Maybe that avoids this bug altogether then.

[lp:~aacid/unity8/do_not_animate_panel_color_startup]

2342. By Albert Astals Cid on 2016-04-28

Set the theme earlier

This way we avoid some flashing/animating of colors because of the theme change

[Albert Astals Cid (aacid)]

> Oh, I see we set the theme on Shell.onCompleted. But why do we do that?
> Can't we just set theme as a binding from the get go? Maybe that avoids this
> bug altogether then.

Done.

[Michael Terry (mterry)]

LGTM.

Also tested with wizard (since it uses a different theme and now we'd be setting the theme before it's created) and it worked.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 Yes

 * Did CI run pass? If not, please explain why.
 TBD, but I don't envision a problem

review: Approve

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2342
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1081/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/630
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/630
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/630/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1452
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1418
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1418
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1418
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1418/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1418
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1418/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1418
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1418/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1418
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1418/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1418
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1418/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1418
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1418/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1081/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'qml/Shell.qml'
--- qml/Shell.qml	2016-04-21 13:47:29 +0000
+++ qml/Shell.qml	2016-04-28 10:09:05 +0000
@@ -45,9 +45,11 @@
 import WindowManager 0.1
 
 
-Item {
+StyledItem {
     id: shell
 
+    theme.name: "Ubuntu.Components.Themes.SuruDark"
+
     // to be set from outside
     property int orientationAngle: 0
     property int orientation
@@ -171,7 +173,6 @@
     }
 
     Component.onCompleted: {
-        theme.name = "Ubuntu.Components.Themes.SuruDark"
         finishStartUpTimer.start();
     }