Merge lp:~aacid/unity8/desktopRotatedCamera into lp:unity8
| Status: | Superseded | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp:~aacid/unity8/desktopRotatedCamera | ||||
| Merge into: | lp:unity8 | ||||
| Diff against target: |
2267 lines (+1060/-168) 18 files modified
data/com.canonical.Unity8.gschema.xml (+11/-0) qml/Components/PhysicalKeysMapper.qml (+24/-0) qml/Launcher/Launcher.qml (+141/-9) qml/Launcher/LauncherDelegate.qml (+54/-20) qml/Launcher/LauncherPanel.qml (+122/-51) qml/Launcher/graphics/launcher-app-focus-ring.svg (+12/-0) qml/Shell.qml (+51/-1) qml/Stages/AbstractStage.qml (+2/-0) qml/Stages/DecoratedWindow.qml (+27/-10) qml/Stages/DesktopStage.qml (+49/-18) qml/Stages/WindowResizeArea.qml (+7/-4) tests/mocks/GSettings.1.0/fake_gsettings.cpp (+64/-0) tests/mocks/GSettings.1.0/fake_gsettings.h (+18/-0) tests/mocks/Unity/Application/ApplicationManager.cpp (+12/-0) tests/mocks/Unity/Launcher/MockLauncherModel.cpp (+5/-0) tests/qmltests/Launcher/tst_Launcher.qml (+244/-18) tests/qmltests/tst_OrientedShell.qml (+13/-1) tests/qmltests/tst_Shell.qml (+204/-36) |
||||
| To merge this branch: | bzr merge lp:~aacid/unity8/desktopRotatedCamera | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lukáš Tinkl (community) | 2016-02-25 | Approve on 2016-03-08 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2016-02-26 | |
| Unity8 CI Bot | continuous-integration | Needs Fixing on 2016-02-26 | |
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2016-03-10.
Commit Message
Desktop stage: Support rotatesWindowCo
Description of the Change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2205
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2206
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Lukáš Tinkl (lukas-kde) wrote : | # |
Left some inline comments, also seems you want to rotate just the ApplicationWindow inside the delegate, why not do it directly there instead of doing the calculations to take the decoration into account?
| Lukáš Tinkl (lukas-kde) wrote : | # |
Also, shouldn't there be some transition/
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2206
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
> Left some inline comments, also seems you want to rotate just the
> ApplicationWindow inside the delegate, why not do it directly there instead of
> doing the calculations to take the decoration into account?
Yes, only the ApplicationWindow needs rotating and that's what i'm rotating only, no? I'm not sure what you mean with "there" means as instead of what i'm doing now.
| Albert Astals Cid (aacid) wrote : | # |
> Also, shouldn't there be some transition/
The window doesn't really rotate, you move the phone and the window stays "the same" visually
| Lukáš Tinkl (lukas-kde) wrote : | # |
> > Left some inline comments, also seems you want to rotate just the
> > ApplicationWindow inside the delegate, why not do it directly there instead
> of
> > doing the calculations to take the decoration into account?
>
> Yes, only the ApplicationWindow needs rotating and that's what i'm rotating
> only, no? I'm not sure what you mean with "there" means as instead of what i'm
> doing now.
Yup sorry, that's what I meant, blaming launchpad diff for not being to show/expand the context...
| Albert Astals Cid (aacid) wrote : | # |
> Why not just use "rotation: rotationAngle" instead of constructing the Rotation Transform? The "transformOrigin" is by default Item.Center
Because it doesn't work, see current code http://
You need the correct origin otherwise the rotation sends the item away from the rest of the item
| Albert Astals Cid (aacid) wrote : | # |
> What about other states like "maximized", shouldn't we care about them as well?
They do work already, see tryOrientedShell, mako, windowed, start the second camera app and maximize it, then go to invertedlandscape and see how it works fine
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2208
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Daniel d'Andrada (dandrader) wrote : | # |
Maybe we would make camera-app not be fullscreen when in desktop mode (have code somewhere calling cameraApplicati
| Daniel d'Andrada (dandrader) wrote : | # |
Good work, by the way. Completely forgot about implementing RotatesWindowCo
Another thing:
"""
{tag: "mako_windowed", deviceName: "mako", orientationAngl
"""
Wouldn't a "manta_windowed" make more sense? (larger display area)
| Daniel d'Andrada (dandrader) wrote : | # |
> Maybe we would make camera-app not be fullscreen when in desktop mode (have
> code somewhere calling cameraApplicati
> creating another app.
By the way, that would mimic the magic that will (or already does, don't recall trying) happen on the device.
| Albert Astals Cid (aacid) wrote : | # |
> Wouldn't a "manta_windowed" make more sense? (larger display area)
Does it matter? I guess the point is that it works on one it "should" work on all, maybe i can just add all three?
| Albert Astals Cid (aacid) wrote : | # |
> Maybe we would make camera-app not be fullscreen when in desktop mode (have code somewhere
> calling cameraApplicati
This has advantage that we kind of test the "same" camera app that we [will] have on the real world, the disadvantage is that we lose the hability to try/test pure fullscreen apps on the destkop stage (which i guess at some point makes sense too).
That's why i decided to go for the duplication case, but can make it the other way if you prefer.
| Daniel d'Andrada (dandrader) wrote : | # |
On 26/02/2016 10:36, Albert Astals Cid wrote:
>> Wouldn't a "manta_windowed" make more sense? (larger display area)
> Does it matter? I guess the point is that it works on one it "should" work on all, maybe i can just add all three?
just sugar on top. makes more sense when you look at it or try it out
manually.
| Daniel d'Andrada (dandrader) wrote : | # |
On 26/02/2016 10:43, Albert Astals Cid wrote:
> This has advantage that we kind of test the "same" camera app that we [will] have on the real world, the disadvantage is that we lose the hability to try/test pure fullscreen apps on the destkop stage (which i guess at some point makes sense too).
We already have other fullscreen apps there: gallery-app, webbrowser-app
| Albert Astals Cid (aacid) wrote : | # |
> We already have other fullscreen apps there: gallery-app, webbrowser-app
Sure, but they do not have rotatesWindowCo
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2208
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2210
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2210
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 2091. By Lukáš Tinkl on 2016-02-29
-
fix for fullscreen apps in desktop mode
- 2092. By Lukáš Tinkl on 2016-02-29
-
similar fix to height...
| Lukáš Tinkl (lukas-kde) wrote : | # |
Worked fine from my testing
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Yes, unrelated failures
* Did you make sure that the branch does not contain spurious tags?
Yes
- 2093. By Albert Astals Cid on 2016-03-10
-
Desktop stage: Support rotatesWindowCo
ntents - 2094. By Albert Astals Cid on 2016-03-10
-
Make it work on non fullscreen windows too
- 2095. By Albert Astals Cid on 2016-03-10
-
Add SurfaceManagerC
ontrols - 2096. By Albert Astals Cid on 2016-03-10
-
These are readonly too (i think)
- 2097. By Albert Astals Cid on 2016-03-10
-
add the other two windowed variants too
- 2098. By Albert Astals Cid on 2016-03-10
-
also switch the min/maxwidth/height
- 2099. By Albert Astals Cid on 2016-03-11
-
Merge makeMakeTryOrie
ntedShellWork - 2100. By Albert Astals Cid on 2016-03-11
-
account for 180
- 2101. By Albert Astals Cid on 2016-03-14
-
Merge
- 2102. By Albert Astals Cid on 2016-03-24
-
Merge
- 2103. By Albert Astals Cid on 2016-04-26
-
Merge
- 2104. By Albert Astals Cid on 2016-04-27
-
Change to windowed/not windowed before starting the app
- 2105. By Albert Astals Cid on 2016-05-09
-
Merge
- 2106. By Albert Astals Cid on 2016-05-23
-
Merge
- 2107. By Albert Astals Cid on 2016-05-23
-
"compile"
- 2108. By Albert Astals Cid on 2016-05-23
-
fix startup of non rotatesWindowCo
ntents apps - 2109. By Albert Astals Cid on 2016-05-24
-
Revert change infected from other branch
- 2110. By Albert Astals Cid on 2016-06-02
-
Merge

PASSED: Continuous integration, rev:2205 /unity8- jenkins. ubuntu. com/job/ lp-unity8- 1-ci/481/ /unity8- jenkins. ubuntu. com/job/ build/643 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= vivid+overlay/ 209 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= xenial/ 209 /unity8- jenkins. ubuntu. com/job/ build-0- fetch/666 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= vivid+overlay/ 684 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial/ 684 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 680 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 680/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial/ 680 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial/ 680/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 680 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 680/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial/ 680 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial/ 680/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 680 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 680/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial/ 680 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial/ 680/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- 1-ci/481/ rebuild
https:/