Code review comment for lp:~aacid/unity8/dash_overview

MichaƂ Sawicz (saviq) wrote :

Based on silo 11:

> - no bottom edge hint

Still no edge hint, waiting for asset.

> - Store and Done button are not visible enough (should be white?)

Still not good.

> - overlays not coloured [lp:~aacid/unity8/implementOverlayColor]

They are now, but overlay text needs to be switched between light and dark depending on overlay colour.

> - overlay corners don't line up (could be fixed by the above)
> - not enough padding above/below buttons in the bottom bar
> - bottom bar too translucent
> - wrong images [ssserver]
> 4.png:
> - mascot should be gone [ssserver]

All that still applies.

> 5.png:
> - background in Results should be gone [ssserver]
> - translucent white bar as category separator [separate fix - needs new
> dividers]
> - scopes in Recommendations have wrong layout [ssserver]

As discussed on IRC, search is broken, can't test that.

« Back to merge proposal