Merge lp:~aacid/unity8/createQmlObjectDifferentFile into lp:unity8
Status: | Merged |
---|---|
Approved by: | Michał Sawicz |
Approved revision: | 2137 |
Merged at revision: | 2162 |
Proposed branch: | lp:~aacid/unity8/createQmlObjectDifferentFile |
Merge into: | lp:unity8 |
Diff against target: |
34 lines (+3/-3) 2 files modified
plugins/Dash/CardCreator.js (+2/-2) plugins/Dash/CardCreatorCache.qml (+1/-1) |
To merge this branch: | bzr merge lp:~aacid/unity8/createQmlObjectDifferentFile |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michał Sawicz | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Unity8 CI Bot | continuous-integration | Needs Fixing | |
Review via email: mp+283528@code.launchpad.net |
Commit message
Do not use the same filepath parameter for all the card creator createQmlObject calls
Seems that something deep down in Qt is deciding that if the filepath is the same the qmlcomponent has to be the same and we get weird errors like the fallback of one category showing up at the fallback of other
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
FAILED: Continuous integration, rev:2137 /unity8- jenkins. ubuntu. com/job/ lp-unity8- 1-ci/164/
https:/
Executed test runs:
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- 1-ci/164/ rebuild
https:/