Merge lp:~aacid/unity8/complainRegisterServiceFails into lp:unity8

[Albert Astals Cid]

Add warning if registerService fails

Coverity argues we do that in the rest of calls so be consistent

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
N/A

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2838
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3250/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4267
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2541
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2541
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4295
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4129
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4129/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4129
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4129/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4129
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4129/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4129
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4129/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4129
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4129/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4129
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4129/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3250/rebuild

review: Approve (continuous-integration)

[Lukáš Tinkl (lukas-kde)]

LGTM, CI passing too

review: Approve

[Daniel d'Andrada (dandrader)]

"""
- * Copyright (C) 2016 Canonical, Ltd.
+ * Copyright (C) 2017 Canonical, Ltd.
"""

Shouldn't it be "2016-2017" instead of just "2017"?

=== modified file 'plugins/Utils/URLDispatcher.cpp'
--- plugins/Utils/URLDispatcher.cpp	2016-07-18 20:42:57 +0000
+++ plugins/Utils/URLDispatcher.cpp	2017-03-02 09:01:07 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2016 Canonical, Ltd.
+ * Copyright (C) 2016-2017 Canonical, Ltd.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -17,6 +17,7 @@
 #include "URLDispatcher.h"
 
 #include <QDBusConnection>
+#include <QDebug>
 
 class URLDispatcherInterface : public QObject
 {
@@ -63,7 +64,9 @@
         connection.registerObject(QStringLiteral("/com/canonical/URLDispatcher"),
                                   dispatcher,
                                   QDBusConnection::ExportScriptableContents);
-        connection.registerService(QStringLiteral("com.canonical.URLDispatcher"));
+        if (!connection.registerService(QStringLiteral("com.canonical.URLDispatcher"))) {
+            qWarning() << "Unable to register DBus service com.canonical.URLDispatcher";
+        }
         m_dispatcher = dispatcher;
     } else {
         connection.unregisterService(QStringLiteral("com.canonical.URLDispatcher"));