Unity 8

Merge lp:~aacid/unity8/clipScopesListHeader into lp:unity8

  1. clipScopesListHeader
  2. Merge into trunk
Proposed by Albert Astals Cid on 2015-01-05
Status: Merged
Approved by: Andrea Cimitan on 2015-01-07
Approved revision: 1524
Merged at revision: 1527
Proposed branch: lp:~aacid/unity8/clipScopesListHeader
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
qml/Dash/ScopesList.qml (+1/-0)
To merge this branch: bzr merge lp:~aacid/unity8/clipScopesListHeader
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) 2015-01-05 Approve on 2015-01-07
PS Jenkins bot continuous-integration Approve on 2015-01-05
Review via email: mp+245556@code.launchpad.net

Commit Message

Clip the Scopes List header

Now that we have a background since we use a default ScopeStyle we need to clip the "upper/search" part of the header

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1524
http://jenkins.qa.ubuntu.com/job/unity8-ci/5070/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/642
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/234
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/235
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/235
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/551
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/640
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/640/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16793

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5070/rebuild

review: Approve (continuous-integration)
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
Yes
 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/ScopesList.qml'
2--- qml/Dash/ScopesList.qml 2014-12-15 22:30:24 +0000
3+++ qml/Dash/ScopesList.qml 2015-01-05 10:43:43 +0000
4@@ -65,6 +65,7 @@
5 objectName: "pageHeader"
6 title: i18n.tr("Manage")
7 width: parent.width
8+ clip: true
9 showBackButton: true
10 backIsClose: root.state == "edit"
11 storeEntryEnabled: root.state == "browse"

Subscribers

People subscribed via source and target branches