Merge lp:~aacid/unity8/cleanup_assets into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Michael Zanetti on 2015-11-30 |
| Approved revision: | 2033 |
| Merged at revision: | 2086 |
| Proposed branch: | lp:~aacid/unity8/cleanup_assets |
| Merge into: | lp:unity8 |
| Prerequisite: | lp:~mzanetti/unity8/move-screenshots-to-tests |
| Diff against target: |
343 lines (+38/-39) 14 files modified
tests/autopilot/unity8/shell/tests/test_notifications.py (+1/-1) tests/mocks/Unity/Application/ApplicationInfo.cpp (+1/-2) tests/mocks/Unity/Launcher/MockLauncherItem.cpp (+1/-1) tests/mocks/Unity/fake_resultsmodel.cpp (+1/-1) tests/mocks/Unity/fake_scopesoverview.cpp (+1/-1) tests/qmltests/Components/tst_ModeSwitchWarningDialog.qml (+2/-2) tests/qmltests/Dash/Previews/tst_PreviewComment.qml (+2/-2) tests/qmltests/Dash/Previews/tst_PreviewExpandable.qml (+2/-2) tests/qmltests/Dash/Previews/tst_PreviewImageGallery.qml (+3/-3) tests/qmltests/Notifications/tst_Notifications.qml (+11/-11) tests/qmltests/Notifications/tst_OptionToggle.qml (+2/-2) tests/qmltests/Notifications/tst_SwipeToAct.qml (+5/-5) tests/qmltests/Notifications/tst_VisualSnapDecisionsQueue.qml (+4/-4) tests/qmltests/tst_Shell.qml (+2/-2) |
| To merge this branch: | bzr merge lp:~aacid/unity8/cleanup_assets |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-11-30 | |
| Michael Zanetti (community) | 2015-11-23 | Approve on 2015-11-25 | |
|
Review via email:
|
|||
Commit Message
Move images only used in tests to tests folder
Description of the Change
* Are there any related MPs required for this MP to build/function as expected?
Prerequisite
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| Albert Astals Cid (aacid) wrote : | # |
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2030
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Michael Zanetti (mzanetti) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
No production code touched, just tests
* Did CI run pass? If not, please explain why.
yes
* Did you make sure that the branch does not contain spurious tags?
yes
| Daniel d'Andrada (dandrader) wrote : | # |
Why do I see a bunch of .po changed in the diff?
| Albert Astals Cid (aacid) wrote : | # |
> Why do I see a bunch of .po changed in the diff?
Like i said in the first comment my guess:
* It's coming from the parent https:/
* Launchpad is being weird
- 2031. By Albert Astals Cid on 2015-11-30
-
Merge
- 2032. By Albert Astals Cid on 2015-11-30
-
Fix wrong merge
- 2033. By Albert Astals Cid on 2015-11-30
-
Bring po from trunk to make the diff nicer
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2033
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

No idea why the change on po/shn.po, i think i'm inheriting it from the prerequisite somehow.