Merge lp:~aacid/unity8/clazy_run into lp:unity8
- clazy_run
- Merge into trunk
| Status: | Merged |
|---|---|
| Approved by: | Lukáš Tinkl |
| Approved revision: | 2396 |
| Merged at revision: | 2587 |
| Proposed branch: | lp:~aacid/unity8/clazy_run |
| Merge into: | lp:unity8 |
| Diff against target: |
139 lines (+16/-16) 9 files modified
plugins/AccountsService/AccountsService.cpp (+2/-2) plugins/LightDM/IntegratedLightDM/liblightdm/UsersModel.cpp (+0/-2) plugins/Unity/Indicators/actionrootstate.cpp (+1/-1) plugins/Utils/deviceconfigparser.cpp (+1/-1) plugins/Utils/timezoneFormatter.cpp (+1/-1) plugins/Utils/windowstatestorage.cpp (+3/-1) plugins/Wizard/timezonemodel.cpp (+5/-5) src/SecondaryWindow.cpp (+1/-1) tools/registry-tracker.cpp (+2/-2) |
| To merge this branch: | bzr merge lp:~aacid/unity8/clazy_run |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Lukáš Tinkl (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Small clazy fixes
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
| Lukáš Tinkl (lukas-kde) wrote : | # |
LGTM
Code looks good
- 2334. By Daniel d'Andrada
-
Use Item.grabToImage() instead of qtmir's ApplicationScre
enshot provider The latter doesn't make sense in surface-based window management.
Approved by: Michael Zanetti, Gerry Boland - 2335. By Daniel d'Andrada
-
Refactor keymap switching code
- Make it declarative
- Isolate it in a single file
Approved by: Lukáš Tinkl - 2336. By Daniel d'Andrada
-
Surface-based window management
- We no longer deal with the Session concept.
- Each application has a list of top-level surfaces and each surface has a list of prompt surfaces (general support for child surfaces not yet implemented)
- Stages (desktop, phone and tablet) work on a TopLevelSurfaceList model instead of ApplicationManager.
- TopLevelSurfaceList contains all the top-level surfaces from all running (or suspended) applications
Approved by: Gerry Boland, Lukáš Tinkl - 2337. By Michael Zanetti
-
Fixes for programmatically closing Applications
* Don't keep on restarting the zombietimer in the mock or else we'll never close if stopApplication() is called repeatedly
* Don't keep on hammering on stopApplication() like mad, just call it once per application - 2338. By Robert Bruce Park
-
Use new bileto_
pre_release_ hook
Approved by: Robert Bruce Park - 2339. By CI Train Bot Account
-
Releasing 8.12+16.
04.20160421. 1-0ubuntu1 - 2340. By CI Train Bot Account
-
Resync trunk.
- 2341. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2342. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2343. By Lukáš Tinkl
-
Hide the close button for dash Fixes: #1550056, #1564347
Approved by: Josh Arenson - 2344. By Lukáš Tinkl
-
Unity8 windows now cascade instead of opening all in the top left corner Fixes: #1513813
Approved by: Lukáš Tinkl - 2345. By Lukáš Tinkl
-
Notifications visual update, close button on mouse hover Fixes: #1564343
Approved by: Michael Zanetti - 2346. By Lukáš Tinkl
-
Shell visual update
Approved by: Albert Astals Cid - 2347. By Lukáš Tinkl
-
Drop OOBE wizard autopilot tests
Approved by: Michael Terry - 2348. By Lukáš Tinkl
-
Stabilize wizard tests
Approved by: Albert Astals Cid - 2349. By Lukáš Tinkl
-
Fix labels in desktop spread
- 2350. By Lukáš Tinkl
-
Fix upcoming event ETAs falling out of sync Fixes: #1557571
- 2351. By Albert Astals Cid
-
LVWPH: Account for contentHeight not really being "all" of the content height
m_minYExtent is also part of the content height Fixes: #1569976
Approved by: Michael Zanetti - 2352. By Albert Astals Cid
-
rootObject can be null for a small moment after setSource is called
Fixes: #1560501
Approved by: Daniel d'Andrada - 2353. By Albert Astals Cid
-
forceLayout before calling positionViewAtIndex
We need the list size to be correctly updated before positionViewAtIndex
This needs https:/
/bugs.launchpad .net/ubuntu/ +source/ qtdeclarative- opensource- src/+bug/ 1556842 to actually work Fixes: #1553475
Approved by: Michael Zanetti - 2354. By Albert Astals Cid
-
Compile with Qt 5.6
And actually emit the signal Fixes: #1565632
Approved by: Timo Jyrinki, Michael Zanetti - 2355. By Albert Astals Cid
-
Turn verify intro tryCompareFunction
Approved by: Michael Zanetti - 2356. By Albert Astals Cid
-
Better error message if the item does not exist
Instead of
Cannot read property 'width' of null
and a line pointing to UnityTestCase.qml, you get
No item given
and a line pointing to the offending code
Approved by: Michael Terry - 2357. By Albert Astals Cid
-
See all/less -> Show all/less
Fixes: #1349471
Approved by: Andrea Cimitan - 2358. By Albert Astals Cid
-
Add env var to enable js debugging/profiling even if not built on debug mode
Approved by: Michael Zanetti
- 2359. By Albert Astals Cid
-
CardCreator: Remove ShaderEffectSource
Seems we don't really need it (can't see any regression without it) and it fixes the weird flickering of the appstore card when changing departments Fixes: #1544875
Approved by: Josh Arenson - 2360. By Albert Astals Cid
-
Take into account that sectionItem height can change
Approved by: Josh Arenson
- 2361. By Albert Astals Cid
-
NotificationAudio: We don't need weird "ifdef" for multimedia 5.6 vs 5.0 roles anymore
Approved by: Michael Zanetti - 2362. By Albert Astals Cid
-
Stabilize test_superTabTo
CycleLauncher Approved by: Michael Terry
- 2363. By Michael Zanetti
-
install devices.conf by default
Approved by: Michael Terry - 2364. By Michael Zanetti
-
improve the pin lockscreen
On smallish screens, like the BQ E4.5, it frequently happens that one
misses a digit when quickly entering the pin. After a while of debugging
usage on my phone I noticed that the cause of this is actually that the
user keeps moving the finger while touching the buttons and so it
often happens that the touch events are not recognized as clicks.I've been using this patch for a while now and it increased the reliability
of the pin entry a lot. I've also asked other people who reported the issue
to test this and feedback has been rather good.
Approved by: Michael Terry - 2365. By Michael Zanetti
-
Drop the rotation lock for the dash Fixes: #1465331, #1574165
Approved by: Lukáš Tinkl - 2366. By Michael Terry
-
Fix some unreliable test code.
Approved by: Albert Astals Cid - 2367. By Michael Terry
-
Ignore Home Key presses when the greeter is up.
This avoids pocket presses / dialing on devices like the arale. Fixes: #1565818
Approved by: Daniel d'Andrada - 2368. By Josh Arenson
-
Change the color of the activity pulse to blue Fixes: #1568082
Approved by: Michael Terry - 2369. By Josh Arenson
-
Make scope filter settings button the same color as other foreground elements Fixes: #1563357
Approved by: Albert Astals Cid - 2370. By Ted Gould
-
Switch to using uid/pwdent for getting username
Approved by: Michael Terry - 2371. By Daniel van Vugt
-
Reinstate the touch performance/
smoothness fix
(LP: #1486341, LP: #1556763).It never really went away, but someone accidentally moved it out of
pre-start and into post-start where it has no effect. Fixes: #1556763
Approved by: Timo Jyrinki, Daniel d'Andrada - 2372. By CI Train Bot Account
-
Releasing 8.12+16.
04.20160427. 3-0ubuntu1 - 2373. By CI Train Bot Account
-
Resync trunk.
- 2374. By Gerry Boland
-
Indicators: set menu height binding while fully open/closed, fixes dynamic grid unit bug.
Before this, if the grid units changed, the menu "height" remained fixed, but minimizedPanelH
eight and openedHeight would adapt. This would mean for case phone (GU 22) to desktop (GU8):
a. if the menu was closed, it would remain at the old height (3*22=66pixels), while the panel would shrink (3*8 = 24). This would mean the menu was technically open, and would block input to windows
b. if the menu was opened, it would remain open at the old phone height, and not grow to the new screen height.
Approved by: Michael Terry - 2375. By Michael Zanetti
-
Temporary means to override GUs on the internal screen
Approved by: Lukáš Tinkl - 2376. By Daniel d'Andrada
-
Refactor screenshotting code and make it work in multimonitor scenarios
+ Workaround bug in QWindow regrading "visible" property when moving a window between screens.
+ Implement snapshotting the focused window with Alt+PrtScn
Approved by: Lukáš Tinkl - 2377. By Daniel d'Andrada
-
Make shell rotation animation work on multimonitor scenarios.
Fixes the Shell snapshotting code, used in ninety-degrees rotation animations, to work on multimonitor scenarios.
Approved by: Lukáš Tinkl - 2378. By Daniel d'Andrada
-
Ensure shell transformations use bindings as OrientedShell can get resized
Approved by: Michael Zanetti - 2379. By Michael Zanetti
-
reduce some paint layers.
This will reduce overdraw by 2 layers when apps are focused, by 1 layer when
in spread.
Approved by: Michael Terry - 2380. By Michael Zanetti
-
Call the dash sizing hack when units.gu changes
Approved by: Gerry Boland - 2381. By CI Train Bot Account
-
Releasing 8.12+16.
04.20160429. 2-0ubuntu1 - 2382. By CI Train Bot Account
-
Resync trunk.
- 2383. By Andrea Cimitan
-
Add social actions to cards
Approved by: Josh Arenson - 2384. By Albert Astals Cid
-
Pass the category correctly
Approved by: Pawel Stolowski
- 2385. By Albert Astals Cid
-
Make the previewActions react to the actions model changing
i.e. use a binding instead of a direct assingment Fixes: #1485887
Approved by: Andrea Cimitan - 2386. By Albert Astals Cid
-
Update the icon also to the original one if that's what the scope wants
Approved by: Andrea Cimitan
- 2387. By Albert Astals Cid
-
Reload Preview Zoomable Image source if it gets updated
Approved by: Michael Zanetti
- 2388. By CI Train Bot Account
-
Make the previewActions react to the actions model changing
i.e. use a binding instead of a direct assingment Fixes: #1485887
Approved by: Andrea Cimitan - 2389. By CI Train Bot Account
-
Update the icon also to the original one if that's what the scope wants
Approved by: Andrea Cimitan
- 2390. By CI Train Bot Account
-
Reload Preview Zoomable Image source if it gets updated
Approved by: Michael Zanetti
- 2391. By Albert Astals Cid
-
Expandable Filter Widget
Approved by: Andrea Cimitan, Pawel Stolowski - 2392. By CI Train Bot Account
-
Releasing 8.12+16.
04.20160504. 2-0ubuntu1 - 2393. By CI Train Bot Account
-
Resync trunk.
- 2394. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2395. By Albert Astals Cid
-
Merge
- 2396. By Albert Astals Cid
-
Some more fixes
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2395
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2396
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
- 2397. By Albert Astals Cid
-
Merge
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2397
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2397
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
Preview Diff
| 1 | === modified file 'plugins/AccountsService/AccountsService.cpp' |
| 2 | --- plugins/AccountsService/AccountsService.cpp 2016-07-08 18:39:55 +0000 |
| 3 | +++ plugins/AccountsService/AccountsService.cpp 2016-08-08 14:17:00 +0000 |
| 4 | @@ -68,9 +68,9 @@ |
| 5 | QVariant primaryButtonConverter(const QVariant &value) |
| 6 | { |
| 7 | QString stringValue = value.toString(); |
| 8 | - if (stringValue == "left") { |
| 9 | + if (stringValue == QLatin1String("left")) { |
| 10 | return QVariant::fromValue(0); |
| 11 | - } else if (stringValue == "right") { |
| 12 | + } else if (stringValue == QLatin1String("right")) { |
| 13 | return QVariant::fromValue(1); // Mir is less clear on this -- any non-zero value is the same |
| 14 | } else { |
| 15 | return QVariant::fromValue(0); // default to left |
| 16 | |
| 17 | === modified file 'plugins/LightDM/IntegratedLightDM/liblightdm/UsersModel.cpp' |
| 18 | --- plugins/LightDM/IntegratedLightDM/liblightdm/UsersModel.cpp 2016-06-27 14:51:40 +0000 |
| 19 | +++ plugins/LightDM/IntegratedLightDM/liblightdm/UsersModel.cpp 2016-08-08 14:17:00 +0000 |
| 20 | @@ -40,8 +40,6 @@ |
| 21 | QAbstractListModel(parent), |
| 22 | d_ptr(new UsersModelPrivate(this)) |
| 23 | { |
| 24 | - Q_D(UsersModel); |
| 25 | - |
| 26 | // Extend roleNames (we want to keep the "display" role) |
| 27 | QHash<int, QByteArray> roles = roleNames(); |
| 28 | roles[NameRole] = "name"; |
| 29 | |
| 30 | === modified file 'plugins/Unity/Indicators/actionrootstate.cpp' |
| 31 | --- plugins/Unity/Indicators/actionrootstate.cpp 2014-11-11 10:45:41 +0000 |
| 32 | +++ plugins/Unity/Indicators/actionrootstate.cpp 2016-08-08 14:17:00 +0000 |
| 33 | @@ -44,7 +44,7 @@ |
| 34 | connect(m_actionGroup, &QDBusActionGroup::statusChanged, this, [&](bool) { updateActionState(); }); |
| 35 | connect(m_actionGroup, &QDBusActionGroup::actionAppear, this, [&](const QString&) { updateActionState(); }); |
| 36 | connect(m_actionGroup, &QDBusActionGroup::actionVanish, this, [&](const QString&) { updateActionState(); }); |
| 37 | - connect(m_actionGroup, &QDBusActionGroup::actionStateChanged, this, [&](QVariant) { updateActionState(); }); |
| 38 | + connect(m_actionGroup, &QDBusActionGroup::actionStateChanged, this, [&](const QVariant&) { updateActionState(); }); |
| 39 | |
| 40 | connect(m_actionGroup, &QObject::destroyed, this, [&](QObject*) { updateActionState(); }); |
| 41 | } |
| 42 | |
| 43 | === modified file 'plugins/Utils/deviceconfigparser.cpp' |
| 44 | --- plugins/Utils/deviceconfigparser.cpp 2016-03-31 09:39:38 +0000 |
| 45 | +++ plugins/Utils/deviceconfigparser.cpp 2016-08-08 14:17:00 +0000 |
| 46 | @@ -26,7 +26,7 @@ |
| 47 | // Local files have highest priority |
| 48 | QString path; |
| 49 | Q_FOREACH (const QString &standardPath, QStandardPaths::standardLocations(QStandardPaths::GenericConfigLocation)) { |
| 50 | - if (QFileInfo(standardPath + "/devices.conf").exists()) { |
| 51 | + if (QFileInfo::exists(standardPath + "/devices.conf")) { |
| 52 | path = standardPath + "/devices.conf"; |
| 53 | break; |
| 54 | } |
| 55 | |
| 56 | === modified file 'plugins/Utils/timezoneFormatter.cpp' |
| 57 | --- plugins/Utils/timezoneFormatter.cpp 2016-03-29 03:47:39 +0000 |
| 58 | +++ plugins/Utils/timezoneFormatter.cpp 2016-08-08 14:17:00 +0000 |
| 59 | @@ -39,7 +39,7 @@ |
| 60 | QTimeZone tz(tzId.toByteArray()); |
| 61 | if (tz.isValid()) { |
| 62 | const QDateTime now = QDateTime::currentDateTime().toTimeZone(tz); |
| 63 | - return QStringLiteral("%1 %2").arg(now.time().toString(QStringLiteral("h:mm"))).arg(tz.abbreviation(now)); |
| 64 | + return QStringLiteral("%1 %2").arg(now.time().toString(QStringLiteral("h:mm")), tz.abbreviation(now)); |
| 65 | } |
| 66 | return QString(); |
| 67 | } |
| 68 | |
| 69 | === modified file 'plugins/Utils/windowstatestorage.cpp' |
| 70 | --- plugins/Utils/windowstatestorage.cpp 2016-06-20 14:26:27 +0000 |
| 71 | +++ plugins/Utils/windowstatestorage.cpp 2016-08-08 14:17:00 +0000 |
| 72 | @@ -28,7 +28,9 @@ |
| 73 | QMutex WindowStateStorage::s_mutex; |
| 74 | |
| 75 | inline QString sanitiseString(QString string) { |
| 76 | - return string.remove("\"").remove("'").remove("\\"); |
| 77 | + return string.remove(QLatin1Char('\"')) |
| 78 | + .remove(QLatin1Char('\'')) |
| 79 | + .remove(QLatin1Char('\\')); |
| 80 | } |
| 81 | |
| 82 | WindowStateStorage::WindowStateStorage(QObject *parent): |
| 83 | |
| 84 | === modified file 'plugins/Wizard/timezonemodel.cpp' |
| 85 | --- plugins/Wizard/timezonemodel.cpp 2016-03-21 23:44:24 +0000 |
| 86 | +++ plugins/Wizard/timezonemodel.cpp 2016-08-08 14:17:00 +0000 |
| 87 | @@ -60,12 +60,12 @@ |
| 88 | |
| 89 | switch (role) { |
| 90 | case Qt::DisplayRole: |
| 91 | - return QStringLiteral("%1, %2, %3").arg(geonames_city_get_name(city)) |
| 92 | - .arg(geonames_city_get_state(city)) |
| 93 | - .arg(geonames_city_get_country(city)); |
| 94 | + return QStringLiteral("%1, %2, %3").arg(geonames_city_get_name(city), |
| 95 | + geonames_city_get_state(city), |
| 96 | + geonames_city_get_country(city)); |
| 97 | case SimpleRole: |
| 98 | - return QStringLiteral("%1, %2").arg(geonames_city_get_name(city)) |
| 99 | - .arg(geonames_city_get_country(city)); |
| 100 | + return QStringLiteral("%1, %2").arg(geonames_city_get_name(city), |
| 101 | + geonames_city_get_country(city)); |
| 102 | case TimeZoneRole: |
| 103 | return geonames_city_get_timezone(city); |
| 104 | case CountryRole: |
| 105 | |
| 106 | === modified file 'src/SecondaryWindow.cpp' |
| 107 | --- src/SecondaryWindow.cpp 2016-04-22 13:10:40 +0000 |
| 108 | +++ src/SecondaryWindow.cpp 2016-08-08 14:17:00 +0000 |
| 109 | @@ -30,7 +30,7 @@ |
| 110 | if (!ok) { |
| 111 | pxpgu = 8; |
| 112 | } |
| 113 | - engine->rootContext()->setContextProperty("internalGu", pxpgu); |
| 114 | + engine->rootContext()->setContextProperty(QStringLiteral("internalGu"), pxpgu); |
| 115 | setResizeMode(QQuickView::SizeRootObjectToView); |
| 116 | setColor("black"); |
| 117 | setTitle(QStringLiteral("Unity8 Shell - Secondary Screen")); |
| 118 | |
| 119 | === modified file 'tools/registry-tracker.cpp' |
| 120 | --- tools/registry-tracker.cpp 2015-03-10 10:44:44 +0000 |
| 121 | +++ tools/registry-tracker.cpp 2016-08-08 14:17:00 +0000 |
| 122 | @@ -110,7 +110,7 @@ |
| 123 | } |
| 124 | |
| 125 | // FIXME: keep in sync with the SSRegistry config |
| 126 | - QString runtime_ini = QString(RUNTIME_CONFIG).arg(m_registry_config.fileName()).arg(m_mw_config.fileName()).arg(m_serverScopes ? "SSRegistry" : ""); |
| 127 | + QString runtime_ini = QString(RUNTIME_CONFIG).arg(m_registry_config.fileName(), m_mw_config.fileName(), m_serverScopes ? "SSRegistry" : ""); |
| 128 | if (!m_systemScopes) { |
| 129 | m_scopeInstallDir.reset(new QTemporaryDir(tmp.filePath("scopes.XXXXXX"))); |
| 130 | if (!m_scopeInstallDir->isValid()) { |
| 131 | @@ -118,7 +118,7 @@ |
| 132 | } |
| 133 | scopeInstallDir = m_scopeInstallDir->path(); |
| 134 | } |
| 135 | - QString registry_ini = QString(REGISTRY_CONFIG).arg(m_mw_config.fileName()).arg(scopeInstallDir).arg(scopeRunnerBin); |
| 136 | + QString registry_ini = QString(REGISTRY_CONFIG).arg(m_mw_config.fileName(), scopeInstallDir, scopeRunnerBin); |
| 137 | QString mw_ini = QString(MW_CONFIG).arg(m_endpoints_dir.path()); |
| 138 | |
| 139 | if (!m_systemScopes) { |
FAILED: Continuous integration, rev:2333
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/