Merge lp:~aacid/unity8/card_height_overlay_header into lp:unity8
Proposed by
Albert Astals Cid
Status: | Merged |
---|---|
Approved by: | Michael Zanetti |
Approved revision: | 1773 |
Merged at revision: | 1786 |
Proposed branch: | lp:~aacid/unity8/card_height_overlay_header |
Merge into: | lp:unity8 |
Diff against target: |
23 lines (+3/-1) 2 files modified
plugins/Dash/CardCreator.js (+2/-0) tests/plugins/Dash/cardcreator/5.res (+1/-1) |
To merge this branch: | bzr merge lp:~aacid/unity8/card_height_overlay_header |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Michael Zanetti (community) | Approve | ||
Review via email: mp+258756@code.launchpad.net |
Commit message
Use art height as implicitHeight when the header is overlayed and there's no summary
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
* Did you perform an exploratory manual test run of the code change and any related functionality?
yes.
* Did CI run pass? If not, please explain why.
waiting
* Did you make sure that the branch does not contain spurious tags?
yes