Merge lp:~aacid/unity8/cardCreatorTest7Update into lp:unity8

Proposed by Albert Astals Cid
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp:~aacid/unity8/cardCreatorTest7Update
Merge into: lp:unity8
Diff against target: 12 lines (+1/-1)
1 file modified
tests/plugins/Dash/cardcreator/7.res (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity8/cardCreatorTest7Update
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Andrea Cimitan (community) Disapprove
Review via email: mp+229763@code.launchpad.net

Commit message

Update expected result for test 7

Description of the change

* Are there any related MPs required for this MP to build/function as expected?
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
No, test change only

* Did you make sure that your branch does not contain spurious tags?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

* If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :
review: Disapprove
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

1115. By Albert Astals Cid

Update expected result for test 7

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/plugins/Dash/cardcreator/7.res'
2--- tests/plugins/Dash/cardcreator/7.res 2014-07-24 10:03:58 +0000
3+++ tests/plugins/Dash/cardcreator/7.res 2014-08-06 10:56:24 +0000
4@@ -116,7 +116,7 @@
5 objectName: "attributesRow";
6 anchors { left: parent.left; right: parent.right }
7 color: backgroundLoader.active && backgroundLoader.item && backgroundLoader.item.luminance < 0.7 ? "white" : (root.scopeStyle ? root.scopeStyle.foreground : "grey");
8- model: cardData["attributes"]
9+ model: cardData && cardData["attributes"] || undefined;
10 }
11
12 ]

Subscribers

People subscribed via source and target branches