Merge lp:~aacid/unity8/card-social-category-fix into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 2133
Merged at revision: 2384
Proposed branch: lp:~aacid/unity8/card-social-category-fix
Merge into: lp:unity8
Prerequisite: lp:~cimi/unity8/card-social
Diff against target: 12 lines (+1/-1)
1 file modified
qml/Dash/GenericScopeView.qml (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity8/card-social-category-fix
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Paweł Stołowski (community) Approve
Review via email: mp+290404@code.launchpad.net

Commit message

Pass the category correctly

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
prereq

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Pawel did

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Confirmed to fix the issue, works fine with the changes in the silo 71. +1

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/GenericScopeView.qml'
2--- qml/Dash/GenericScopeView.qml 2016-03-30 08:33:35 +0000
3+++ qml/Dash/GenericScopeView.qml 2016-03-30 08:33:35 +0000
4@@ -391,7 +391,7 @@
5 }
6
7 onAction: { // (int index, var result, var actionId)
8- scope.activateAction(result, baseItem.categoryId, actionId);
9+ scope.activateAction(result, baseItem.category, actionId);
10 }
11
12 function categoryItemCount() {

Subscribers

People subscribed via source and target branches