Merge lp:~aacid/unity8/autopilot_drag_more into lp:unity8

[Albert Astals Cid]

Make the drag range be a multiple of the drag "rate" value. Workarounds https://bugs.launchpad.net/mir/+bug/1399690

Also small fixlet to make _get_scope_loader faster

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1461
http://jenkins.qa.ubuntu.com/job/unity8-ci/5000/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/440/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/177
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/165
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/165
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/386/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/440
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/440/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16385

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5000/rebuild

review: Needs Fixing (continuous-integration)

[lp:~aacid/unity8/autopilot_drag_more]

1462. By Albert Astals Cid on 2014-12-02

Some debug, let's see what is going on on CI

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1462
http://jenkins.qa.ubuntu.com/job/unity8-ci/5006/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/459
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/183
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/171
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/171
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/404
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/459
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/459/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16412

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5006/rebuild

review: Needs Fixing (continuous-integration)

[Andrea Cimitan (cimi)]

review: Needs Fixing

[lp:~aacid/unity8/autopilot_drag_more]

1463. By Albert Astals Cid on 2014-12-05

Make the dragged distance be a multiple of the dragged area

This is a workaround for a bug in if the last remaining bit of dragging
is just 1 pixel to the left of one of the multiples the drag seems to go back

I've traced this as far as the bug seems to be in /dev/uinput or the input layer in mir
so filed a bug for it and workarounding it here for the test

1464. By Albert Astals Cid on 2014-12-05

Add the comment here too

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1464
http://jenkins.qa.ubuntu.com/job/unity8-ci/5023/
Executed test runs:
    None: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/527/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/188
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/188
    None: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/525/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5023/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1464
http://jenkins.qa.ubuntu.com/job/unity8-ci/5038/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/553
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/202
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/203
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/203
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/475
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/551
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/551/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16549

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5038/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

The test in question passes now.

review: Approve

=== modified file 'tests/autopilot/unity8/shell/emulators/dash.py'
--- tests/autopilot/unity8/shell/emulators/dash.py	2014-12-01 15:52:52 +0000
+++ tests/autopilot/unity8/shell/emulators/dash.py	2014-12-05 15:59:15 +0000
@@ -90,8 +90,12 @@
 
     def _get_scope_loader(self, scope_id):
         try:
-            return self.dash_content_list.wait_select_single(
-                'QQuickLoader', scopeId=scope_id)
+            aux = self.dash_content_list.get_children_by_type('QQuickItem')[0]
+            for l in aux.get_children_by_type('QQuickLoader'):
+                if (l.scopeId == scope_id):
+                    return l;
+            raise emulators.UnityEmulatorException(
+                'No scope found with id {0}'.format(scope_id))
         except dbus.StateNotFoundError:
             raise emulators.UnityEmulatorException(
                 'No scope found with id {0}'.format(scope_id))
@@ -125,10 +129,15 @@
         original_index = self.dash_content_list.currentIndex
         dash_content = self.select_single(objectName="dashContent")
         x, y, width, height = dash_content.globalRect
-        start_x = x + width / 3
-        stop_x = x + width / 3 * 2
+        # Make the drag range be a multiple of the drag "rate" value.
+        # Workarounds https://bugs.launchpad.net/mir/+bug/1399690
+        rate = 10
+        divisions = 5
+        jump = ( width / divisions ) // rate * rate
+        start_x = x + jump
+        stop_x = x + jump * (divisions - 1)
         start_y = stop_y = y + 1
-        self.pointing_device.drag(start_x, start_y, stop_x, stop_y)
+        self.pointing_device.drag(start_x, start_y, stop_x, stop_y, rate)
         self.dash_content_list.currentIndex.wait_for(original_index - 1)
 
     @autopilot_logging.log_action(logger.info)
@@ -136,10 +145,15 @@
         original_index = self.dash_content_list.currentIndex
         dash_content = self.select_single(objectName="dashContent")
         x, y, width, height = dash_content.globalRect
-        start_x = x + width / 3 * 2
-        stop_x = x + width / 3
+        # Make the drag range be a multiple of the drag "rate" value.
+        # Workarounds https://bugs.launchpad.net/mir/+bug/1399690
+        rate = 10
+        divisions = 5
+        jump = ( width / divisions ) // rate * rate
+        start_x = x + jump * (divisions - 1)
+        stop_x = x + jump
         start_y = stop_y = y + 1
-        self.pointing_device.drag(start_x, start_y, stop_x, stop_y)
+        self.pointing_device.drag(start_x, start_y, stop_x, stop_y, rate)
         self.dash_content_list.currentIndex.wait_for(original_index + 1)
 
     def enter_search_query(self, query):