Merge lp:~aacid/unity8/add_override into lp:unity8

Proposed by Albert Astals Cid on 2015-04-30
Status: Merged
Approved by: Michał Sawicz on 2015-04-30
Approved revision: no longer in the source branch.
Merged at revision: 1782
Proposed branch: lp:~aacid/unity8/add_override
Merge into: lp:unity8
Diff against target: 1436 lines (+193/-193)
82 files modified
plugins/AccountsService/plugin.h (+1/-1)
plugins/Dash/plugin.h (+1/-1)
plugins/Greeter/Unity/Launcher/launchermodelas.h (+11/-11)
plugins/Greeter/Unity/Launcher/plugin.h (+1/-1)
plugins/Greeter/Unity/Launcher/quicklistmodel.h (+2/-2)
plugins/LightDM/UsersModel.cpp (+1/-1)
plugins/LightDM/liblightdm/UsersModel.h (+2/-2)
plugins/LightDM/plugin.h (+1/-1)
plugins/Lights/plugin.h (+1/-1)
plugins/Powerd/plugin.h (+1/-1)
plugins/ScreenGrabber/plugin.h (+1/-1)
plugins/SessionBroadcast/plugin.h (+1/-1)
plugins/Ubuntu/DownloadDaemonListener/plugin.h (+2/-2)
plugins/Ubuntu/Gestures/DirectionalDragArea.h (+2/-2)
plugins/Ubuntu/Gestures/plugin.h (+1/-1)
plugins/Ubuntu/Payments/plugin.h (+1/-1)
plugins/Ubuntu/SystemImage/plugin.h (+1/-1)
plugins/Unity/Connectivity/plugin.h (+1/-1)
plugins/Unity/DashCommunicator/plugin.h (+1/-1)
plugins/Unity/Indicators/indicatorsmodel.h (+5/-5)
plugins/Unity/Indicators/menucontentactivator.cpp (+4/-4)
plugins/Unity/Indicators/plugin.h (+1/-1)
plugins/Unity/Launcher/launchermodel.h (+12/-12)
plugins/Unity/Launcher/plugin.h (+1/-1)
plugins/Unity/Launcher/quicklistmodel.h (+2/-2)
plugins/Unity/Session/plugin.h (+1/-1)
plugins/Utils/HomeKeyWatcher.h (+1/-1)
plugins/Utils/plugin.h (+2/-2)
plugins/Utils/qlimitproxymodelqml.h (+2/-2)
plugins/Utils/qvariantlistmodel.h (+8/-8)
plugins/Utils/timeformatter.h (+1/-1)
plugins/Utils/unitysortfilterproxymodelqml.h (+2/-2)
plugins/Utils/windowkeysfilter.h (+1/-1)
plugins/Wizard/plugin.h (+1/-1)
tests/mocks/AccountsService/plugin.h (+1/-1)
tests/mocks/GSettings.1.0/plugin.h (+1/-1)
tests/mocks/LightDM/liblightdm/UsersModel.h (+2/-2)
tests/mocks/LightDM/plugin.h (+1/-1)
tests/mocks/Lights/plugin.h (+1/-1)
tests/mocks/MeeGo/QOfono/plugin.h (+1/-1)
tests/mocks/Powerd/plugin.h (+1/-1)
tests/mocks/QMenuModel/plugin.h (+1/-1)
tests/mocks/QMenuModel/unitymenumodel.h (+6/-6)
tests/mocks/QtMultimedia/plugin.h (+1/-1)
tests/mocks/Ubuntu/Connectivity/plugin.h (+2/-2)
tests/mocks/Ubuntu/DownloadDaemonListener/plugin.h (+1/-1)
tests/mocks/Ubuntu/Payments/plugin.h (+1/-1)
tests/mocks/Ubuntu/SystemImage/plugin.h (+1/-1)
tests/mocks/Ubuntu/SystemSettings/SecurityPrivacy/plugin.h (+1/-1)
tests/mocks/Ubuntu/Telephony/MockCallEntry.h (+1/-1)
tests/mocks/Ubuntu/Telephony/plugin.h (+2/-2)
tests/mocks/Unity/Application/ObjectListModel.h (+1/-1)
tests/mocks/Unity/Application/plugin.h (+2/-2)
tests/mocks/Unity/Connectivity/plugin.h (+1/-1)
tests/mocks/Unity/DashCommunicator/plugin.h (+1/-1)
tests/mocks/Unity/Indicators/fakeindicatorsmodel.h (+5/-5)
tests/mocks/Unity/Indicators/fakeplugin.h (+1/-1)
tests/mocks/Unity/Launcher/MockLauncherItem.h (+2/-2)
tests/mocks/Unity/Launcher/MockLauncherModel.h (+12/-12)
tests/mocks/Unity/Launcher/MockQuickListModel.h (+2/-2)
tests/mocks/Unity/Launcher/plugin.h (+1/-1)
tests/mocks/Unity/Notifications/MockActionModel.h (+3/-3)
tests/mocks/Unity/Notifications/MockNotificationModel.h (+3/-3)
tests/mocks/Unity/Notifications/plugin.h (+1/-1)
tests/mocks/Unity/fake_scopes.h (+2/-2)
tests/mocks/Unity/fake_unity_plugin.h (+1/-1)
tests/mocks/Wizard/mockplugin.h (+1/-1)
tests/plugins/Dash/horizontaljournaltest.cpp (+3/-3)
tests/plugins/Dash/horizontaljournaltry.cpp (+1/-1)
tests/plugins/Dash/listviewwithpageheadersectionexternalmodeltest.cpp (+3/-3)
tests/plugins/Dash/organicgridtest.cpp (+2/-2)
tests/plugins/Dash/organicgridtry.cpp (+2/-2)
tests/plugins/Dash/verticaljournaltest.cpp (+3/-3)
tests/plugins/Dash/verticaljournaltry.cpp (+1/-1)
tests/plugins/Ubuntu/Gestures/tst_AxisVelocityCalculator.cpp (+1/-1)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp (+1/-1)
tests/plugins/Ubuntu/Gestures/tst_PressedOutsideNotifier.cpp (+1/-1)
tests/plugins/Unity/Indicators/menucontentactivatortest.cpp (+2/-2)
tests/plugins/Unity/Launcher/launchermodeltest.cpp (+21/-21)
tests/plugins/Utils/qlimitproxymodeltest.cpp (+5/-5)
tests/plugins/Utils/unitysortfilterproxymodeltest.cpp (+5/-5)
tests/utils/modules/Unity/Test/plugin.h (+1/-1)
To merge this branch: bzr merge lp:~aacid/unity8/add_override
Reviewer Review Type Date Requested Status
Gerry Boland 2015-04-30 Approve on 2015-04-30
PS Jenkins bot continuous-integration Needs Fixing on 2015-04-30
Review via email: mp+257865@code.launchpad.net

Commit Message

Add overrides to override functions

clang-modernize-3.6 -p=builddir -include=. -add-override

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes, builds

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Gerry Boland (gerboland) wrote :

I'm a fan of the 'override', a +1 from me

review: Approve
lp:~aacid/unity8/add_override updated on 2015-05-20
1755. By Launchpad Translations on behalf of unity-team on 2015-05-02

Launchpad automatic translations update.

1756. By Launchpad Translations on behalf of unity-team on 2015-05-03

Launchpad automatic translations update.

1757. By Launchpad Translations on behalf of unity-team on 2015-05-05

Launchpad automatic translations update.

1758. By Daniel d'Andrada on 2015-05-05

DirectionalDragArea: improvements & API grooming

-Simplified DirectionalDragArea gesture recognition
 * The widening angle property was dropped. Didn't really work
   as in real life swipes might start up in very different directions
   before finally turning to the final overall direction. That's specially
   bad when you have to conclude the recognition in a short amount
   of time so that you can still play animations to follow the user's finger
 * minSpeed as well. Went for a simpler way of expressing and evaluating it
   which is having maxTime and maxDistance.

-EdgeDragArea got absorbed by DirectionalDragArea

-Privatized all gesture recognition parameters.

-Privatized DirectionalDragArea.status property. All apps need is
 DirectionalDragArea.dragging. Modified qml code using DDA accordingly.

-Modified DirectionalDragArea.dragging semantics a bit. It goes to true only
 once a gesture is recognized

-Moved code that smooths out touch movement into DirectionalDragArea so all users
 get it for free.

-Cleaned up DirectionalDragArea.h of all implementation details, getting it ready
 to be moved out of unity8, into the SDK.

-Removed DirectionalDragArea.tapped() signal as it doesn't belong to it.

-Fine-tuned gesture recognition parameters and made them based on physical size.

-Added tests with input from real gestures to catch those annoying
  false-negatives and false-positives introduced by badly set recognition parameters

-Improved debug output

-UnownedTouchEvents are no longer sent to interim owners

-Fixed issue when TouchGate got disabled while holding an active touch

-Made "make tryDirectionalDragArea" and "make tryDragHandle" work with mouse again. Fixes: #1417920
Approved by: Michael Zanetti, Albert Astals Cid

1759. By Daniel d'Andrada on 2015-05-05

Fix EdgeDragEvaluator when a drag can happen both ways (Direction.Horizontal)
Approved by: Albert Astals Cid

1760. By Josh Arenson on 2015-05-05

Remove panelHeight property as it is unused.
Approved by: Albert Astals Cid

1761. By Michał Sawicz on 2015-05-05

UNITY_SCOPES_LIST is no more
Approved by: Pawel Stolowski, Albert Astals Cid

1762. By Leo Arias on 2015-05-05

Initial clean up of the autopilot tests set up.
- Removed the touch device from the test case.
- Moved the restart of unity to a fixture.
- Removed the unused DragMixin.
- Updated the setUpClass to use process_helpers.
- Removed the workaround for bug #1238417, already fixed.
- Use the toolkit helper to set the testability environment variable.
- Fixed the indicators base class that was restarting unity twice. Fixes: #1447206
Approved by: Albert Astals Cid

1763. By handsome_feng on 2015-05-05

When click the favorite scope in Dash Manager , it just return to the corresponding scope page. Fixes: #1447056
Approved by: Pawel Stolowski, Albert Astals Cid

1764. By Leo Arias on 2015-05-05

Use the base class from the toolkit in autopilot tests.
Approved by: Albert Astals Cid, Christopher Lee

1765. By Michael Zanetti on 2015-05-05

emit application-stop when we're going down Fixes: #1326513
Approved by: Albert Astals Cid

1766. By Albert Astals Cid on 2015-05-05

Make runtests fake a test error if make fails

This means that we will have 2 errors if there is a test that is run and fails, which is sub-optimal, but at least we'll have also a failure if the test doesn't fail because it was not run for example (i.e. missing dbus-launch).
Approved by: Michael Zanetti

1767. By Albert Astals Cid on 2015-05-05

Use dbus-test-runner instead of dbus-launch

Since we actually depend on it in the control file
Approved by: Michael Zanetti

1768. By Albert Astals Cid on 2015-05-05

Make the test more stable

The test was unstable because scrolling vs creation time is not always stable so at some point we were scrolling "too fast" and when deciding if the new item is out of viewport or in sometimes it went the other way.
Approved by: Michael Zanetti

1769. By CI Train Bot Account on 2015-05-05

Releasing 8.02+15.04.20150505-0ubuntu1

1770. By CI Train Bot Account on 2015-05-09

Resync trunk.

1771. By Launchpad Translations on behalf of unity-team on 2015-05-09

Launchpad automatic translations update.

1772. By Launchpad Translations on behalf of unity-team on 2015-05-11

Launchpad automatic translations update.

1773. By Albert Astals Cid on 2015-05-11

Workarounds for concierge mode.
Approved by: Pawel Stolowski, Michael Zanetti

1774. By CI Train Bot Account on 2015-05-11

Releasing 8.02+15.04.20150511-0ubuntu1

1775. By CI Train Bot Account on 2015-05-12

Resync trunk.

1776. By Launchpad Translations on behalf of unity-team on 2015-05-13

Launchpad automatic translations update.

1777. By Launchpad Translations on behalf of unity-team on 2015-05-15

Launchpad automatic translations update.

1778. By Nick Dedekind on 2015-05-18

Fixed desktop stage app focus.
Approved by: Daniel d'Andrada

1779. By Daniel d'Andrada on 2015-05-18

Introducing FloatingFlickable
Approved by: Michael Zanetti

1780. By Michael Terry on 2015-05-18

Fix a possible crash in our PAM threading code. (LP: #1425362)

So it was possible for a PAM subthread (which does the actual authenticating) to get mismatched state with the main thread. When this happened (i.e. when the subthread tried to use a pam_handle object that the main thread had already closed), a crash occurs. Like LP: #1425362.

So I've done a few cleanups here:
- Use a cancellable QConcurrent method (::mapped instead of ::run). Being able to cancel the thread is a stronger hammer than just hoping we answer all questions from the thread and it will close itself.
- We now block when the subthread sends a prompt request to the main thread. This makes handling those signals more predictable when we're trying to close the thread.
- We will process events while waiting for the subthread to close, so that we can actually process the above signals in the main thread.

I've added a dumb little test that tries to authenticate/cancel/authenticate 100 times in quick succession. Without this branch, we'd crash reliably anywhere from attempt 2 to 7. With this branch, we're fine all 100. Fixes: #1425362
Approved by: Albert Astals Cid

1781. By Michael Terry on 2015-05-18

Fix the lockscreen becoming unresponsive after testing an app on the device from QtCreator.

Using the hideGreeter dbus call got unity8 in a state where the greeter would try to call a method on an object that didn't exist at the time. Which meant it early-exited from a method before the greeter got re-enabled. Fixes: #1435364
Approved by: Daniel d'Andrada

1782. By Albert Astals Cid on 2015-05-18

Add overrides to override functions

clang-modernize-3.6 -p=builddir -include=. -add-override
Approved by: Gerry Boland

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/AccountsService/plugin.h'
2--- plugins/AccountsService/plugin.h 2013-08-22 14:54:08 +0000
3+++ plugins/AccountsService/plugin.h 2015-05-11 07:50:04 +0000
4@@ -28,7 +28,7 @@
5 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
6
7 public:
8- void registerTypes(const char *uri);
9+ void registerTypes(const char *uri) override;
10 };
11
12 #endif
13
14=== modified file 'plugins/Dash/plugin.h'
15--- plugins/Dash/plugin.h 2014-04-30 10:06:33 +0000
16+++ plugins/Dash/plugin.h 2015-05-11 07:50:04 +0000
17@@ -27,7 +27,7 @@
18 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
19
20 public:
21- void registerTypes(const char *uri);
22+ void registerTypes(const char *uri) override;
23 };
24
25 #endif
26
27=== modified file 'plugins/Greeter/Unity/Launcher/launchermodelas.h'
28--- plugins/Greeter/Unity/Launcher/launchermodelas.h 2015-02-11 14:02:24 +0000
29+++ plugins/Greeter/Unity/Launcher/launchermodelas.h 2015-05-11 07:50:04 +0000
30@@ -37,19 +37,19 @@
31 LauncherModel(QObject *parent = 0);
32 ~LauncherModel();
33
34- int rowCount(const QModelIndex &parent = QModelIndex()) const;
35-
36- QVariant data(const QModelIndex &index, int role) const;
37-
38- Q_INVOKABLE unity::shell::launcher::LauncherItemInterface* get(int index) const;
39- Q_INVOKABLE void move(int oldIndex, int newIndex);
40- Q_INVOKABLE void pin(const QString &appId, int index = -1);
41- Q_INVOKABLE void quickListActionInvoked(const QString &appId, int actionIndex);
42- Q_INVOKABLE void setUser(const QString &username);
43+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
44+
45+ QVariant data(const QModelIndex &index, int role) const override;
46+
47+ Q_INVOKABLE unity::shell::launcher::LauncherItemInterface* get(int index) const override;
48+ Q_INVOKABLE void move(int oldIndex, int newIndex) override;
49+ Q_INVOKABLE void pin(const QString &appId, int index = -1) override;
50+ Q_INVOKABLE void quickListActionInvoked(const QString &appId, int actionIndex) override;
51+ Q_INVOKABLE void setUser(const QString &username) override;
52 Q_INVOKABLE QString getUrlForAppId(const QString &appId) const;
53
54- unity::shell::application::ApplicationManagerInterface* applicationManager() const;
55- void setApplicationManager(unity::shell::application::ApplicationManagerInterface *appManager);
56+ unity::shell::application::ApplicationManagerInterface* applicationManager() const override;
57+ void setApplicationManager(unity::shell::application::ApplicationManagerInterface *appManager) override;
58
59 bool onlyPinned() const override;
60 void setOnlyPinned(bool onlyPinned) override;
61
62=== modified file 'plugins/Greeter/Unity/Launcher/plugin.h'
63--- plugins/Greeter/Unity/Launcher/plugin.h 2015-02-11 14:11:26 +0000
64+++ plugins/Greeter/Unity/Launcher/plugin.h 2015-05-11 07:50:04 +0000
65@@ -26,7 +26,7 @@
66 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
67
68 public:
69- void registerTypes(const char *uri);
70+ void registerTypes(const char *uri) override;
71 };
72
73 #endif
74
75=== modified file 'plugins/Greeter/Unity/Launcher/quicklistmodel.h'
76--- plugins/Greeter/Unity/Launcher/quicklistmodel.h 2015-02-11 14:11:26 +0000
77+++ plugins/Greeter/Unity/Launcher/quicklistmodel.h 2015-05-11 07:50:04 +0000
78@@ -45,8 +45,8 @@
79
80 QuickListEntry get(int index) const;
81
82- int rowCount(const QModelIndex &parent = QModelIndex()) const;
83- QVariant data(const QModelIndex &index, int role) const;
84+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
85+ QVariant data(const QModelIndex &index, int role) const override;
86
87 private:
88 QList<QuickListEntry> m_list;
89
90=== modified file 'plugins/LightDM/UsersModel.cpp'
91--- plugins/LightDM/UsersModel.cpp 2014-12-19 14:51:35 +0000
92+++ plugins/LightDM/UsersModel.cpp 2015-05-11 07:50:04 +0000
93@@ -32,7 +32,7 @@
94 public:
95 explicit MangleModel(QObject* parent=0);
96
97- virtual QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const;
98+ QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
99 };
100
101 MangleModel::MangleModel(QObject* parent)
102
103=== modified file 'plugins/LightDM/liblightdm/UsersModel.h'
104--- plugins/LightDM/liblightdm/UsersModel.h 2015-01-20 11:50:19 +0000
105+++ plugins/LightDM/liblightdm/UsersModel.h 2015-05-11 07:50:04 +0000
106@@ -53,8 +53,8 @@
107 BackgroundPathRole
108 };
109
110- int rowCount(const QModelIndex &parent) const;
111- QVariant data(const QModelIndex &index, int role) const;
112+ int rowCount(const QModelIndex &parent) const override;
113+ QVariant data(const QModelIndex &index, int role) const override;
114
115 private:
116 UsersModelPrivate * const d_ptr;
117
118=== modified file 'plugins/LightDM/plugin.h'
119--- plugins/LightDM/plugin.h 2013-06-05 22:03:08 +0000
120+++ plugins/LightDM/plugin.h 2015-05-11 07:50:04 +0000
121@@ -29,7 +29,7 @@
122 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
123
124 public:
125- void registerTypes(const char *uri);
126+ void registerTypes(const char *uri) override;
127 };
128
129 #endif
130
131=== modified file 'plugins/Lights/plugin.h'
132--- plugins/Lights/plugin.h 2014-07-03 12:35:13 +0000
133+++ plugins/Lights/plugin.h 2015-05-11 07:50:04 +0000
134@@ -28,7 +28,7 @@
135 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
136
137 public:
138- void registerTypes(const char *uri);
139+ void registerTypes(const char *uri) override;
140 };
141
142 #endif
143
144=== modified file 'plugins/Powerd/plugin.h'
145--- plugins/Powerd/plugin.h 2013-08-02 16:18:28 +0000
146+++ plugins/Powerd/plugin.h 2015-05-11 07:50:04 +0000
147@@ -29,7 +29,7 @@
148 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
149
150 public:
151- void registerTypes(const char *uri);
152+ void registerTypes(const char *uri) override;
153 };
154
155 #endif
156
157=== modified file 'plugins/ScreenGrabber/plugin.h'
158--- plugins/ScreenGrabber/plugin.h 2014-09-27 02:16:11 +0000
159+++ plugins/ScreenGrabber/plugin.h 2015-05-11 07:50:04 +0000
160@@ -27,7 +27,7 @@
161 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
162
163 public:
164- void registerTypes(const char *uri);
165+ void registerTypes(const char *uri) override;
166 };
167
168 #endif // SCREENGRABBER_PLUGIN_H
169
170=== modified file 'plugins/SessionBroadcast/plugin.h'
171--- plugins/SessionBroadcast/plugin.h 2013-09-18 20:59:03 +0000
172+++ plugins/SessionBroadcast/plugin.h 2015-05-11 07:50:04 +0000
173@@ -27,7 +27,7 @@
174 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
175
176 public:
177- void registerTypes(const char *uri);
178+ void registerTypes(const char *uri) override;
179 };
180
181 #endif
182
183=== modified file 'plugins/Ubuntu/DownloadDaemonListener/plugin.h'
184--- plugins/Ubuntu/DownloadDaemonListener/plugin.h 2013-08-09 08:54:58 +0000
185+++ plugins/Ubuntu/DownloadDaemonListener/plugin.h 2015-05-11 07:50:04 +0000
186@@ -31,7 +31,7 @@
187 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
188
189 public:
190- void registerTypes(const char *uri);
191- void initializeEngine(QQmlEngine *engine, const char *uri);
192+ void registerTypes(const char *uri) override;
193+ void initializeEngine(QQmlEngine *engine, const char *uri) override;
194 };
195 #endif // BACKEND_PLUGIN_H
196
197=== modified file 'plugins/Ubuntu/Gestures/DirectionalDragArea.h'
198--- plugins/Ubuntu/Gestures/DirectionalDragArea.h 2015-04-15 20:02:08 +0000
199+++ plugins/Ubuntu/Gestures/DirectionalDragArea.h 2015-05-11 07:50:04 +0000
200@@ -125,8 +125,8 @@
201 void immediateRecognitionChanged(bool value);
202
203 protected:
204- virtual void touchEvent(QTouchEvent *event);
205- virtual void itemChange(ItemChange change, const ItemChangeData &value);
206+ void touchEvent(QTouchEvent *event) override;
207+ void itemChange(ItemChange change, const ItemChangeData &value) override;
208
209 public: // so tests can access it
210 DirectionalDragAreaPrivate *d;
211
212=== modified file 'plugins/Ubuntu/Gestures/plugin.h'
213--- plugins/Ubuntu/Gestures/plugin.h 2014-10-01 13:20:32 +0000
214+++ plugins/Ubuntu/Gestures/plugin.h 2015-05-11 07:50:04 +0000
215@@ -24,7 +24,7 @@
216 Q_OBJECT
217 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
218 public:
219- void registerTypes(const char *uri);
220+ void registerTypes(const char *uri) override;
221 };
222
223
224
225=== modified file 'plugins/Ubuntu/Payments/plugin.h'
226--- plugins/Ubuntu/Payments/plugin.h 2014-06-27 18:08:02 +0000
227+++ plugins/Ubuntu/Payments/plugin.h 2015-05-11 07:50:04 +0000
228@@ -25,7 +25,7 @@
229 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
230
231 public:
232- void registerTypes(const char *uri);
233+ void registerTypes(const char *uri) override;
234 };
235
236 #endif // PAYMENTS_PLUGIN_H
237
238=== modified file 'plugins/Ubuntu/SystemImage/plugin.h'
239--- plugins/Ubuntu/SystemImage/plugin.h 2014-07-30 11:08:29 +0000
240+++ plugins/Ubuntu/SystemImage/plugin.h 2015-05-11 07:50:04 +0000
241@@ -25,7 +25,7 @@
242 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
243
244 public:
245- void registerTypes(const char *uri);
246+ void registerTypes(const char *uri) override;
247 };
248
249 #endif // SYSTEMIMAGE_PLUGIN_H
250
251=== modified file 'plugins/Unity/Connectivity/plugin.h'
252--- plugins/Unity/Connectivity/plugin.h 2014-08-15 18:41:51 +0000
253+++ plugins/Unity/Connectivity/plugin.h 2015-05-11 07:50:04 +0000
254@@ -25,7 +25,7 @@
255 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
256
257 public:
258- void registerTypes(const char *uri);
259+ void registerTypes(const char *uri) override;
260 };
261
262 #endif // CONNECTIVITY_PLUGIN_H
263
264=== modified file 'plugins/Unity/DashCommunicator/plugin.h'
265--- plugins/Unity/DashCommunicator/plugin.h 2014-07-24 16:02:27 +0000
266+++ plugins/Unity/DashCommunicator/plugin.h 2015-05-11 07:50:04 +0000
267@@ -28,7 +28,7 @@
268 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
269
270 public:
271- void registerTypes(const char *uri);
272+ void registerTypes(const char *uri) override;
273 };
274
275 #endif
276
277=== modified file 'plugins/Unity/Indicators/indicatorsmodel.h'
278--- plugins/Unity/Indicators/indicatorsmodel.h 2014-11-17 23:04:48 +0000
279+++ plugins/Unity/Indicators/indicatorsmodel.h 2015-05-11 07:50:04 +0000
280@@ -50,11 +50,11 @@
281 void setProfile(const QString& profile);
282
283 /* QAbstractItemModel */
284- QHash<int, QByteArray> roleNames() const;
285- int columnCount(const QModelIndex &parent = QModelIndex()) const;
286- QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const;
287- QModelIndex parent (const QModelIndex &index) const;
288- int rowCount(const QModelIndex &parent = QModelIndex()) const;
289+ QHash<int, QByteArray> roleNames() const override;
290+ int columnCount(const QModelIndex &parent = QModelIndex()) const override;
291+ QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
292+ QModelIndex parent (const QModelIndex &index) const override;
293+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
294
295
296 Q_SIGNALS:
297
298=== modified file 'plugins/Unity/Indicators/menucontentactivator.cpp'
299--- plugins/Unity/Indicators/menucontentactivator.cpp 2014-08-26 08:14:44 +0000
300+++ plugins/Unity/Indicators/menucontentactivator.cpp 2015-05-11 07:50:04 +0000
301@@ -28,10 +28,10 @@
302 connect(&m_timer, &QTimer::timeout,
303 this, &UnityIndicators::AbstractTimer::timeout);
304 }
305- virtual int interval() const { return m_timer.interval(); }
306- virtual void setInterval(int msecs) { m_timer.setInterval(msecs); }
307- virtual void start() { m_timer.start(); UnityIndicators::AbstractTimer::start(); }
308- virtual void stop() { m_timer.stop(); UnityIndicators::AbstractTimer::stop(); }
309+ int interval() const override { return m_timer.interval(); }
310+ void setInterval(int msecs) override { m_timer.setInterval(msecs); }
311+ void start() override { m_timer.start(); UnityIndicators::AbstractTimer::start(); }
312+ void stop() override { m_timer.stop(); UnityIndicators::AbstractTimer::stop(); }
313 private:
314 QTimer m_timer;
315 };
316
317=== modified file 'plugins/Unity/Indicators/plugin.h'
318--- plugins/Unity/Indicators/plugin.h 2014-10-07 10:28:59 +0000
319+++ plugins/Unity/Indicators/plugin.h 2015-05-11 07:50:04 +0000
320@@ -27,7 +27,7 @@
321 Q_OBJECT
322 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
323 public:
324- void registerTypes(const char *uri);
325+ void registerTypes(const char *uri) override;
326 };
327
328 #endif // INDICATORS2_PLUGIN_H
329
330=== modified file 'plugins/Unity/Launcher/launchermodel.h'
331--- plugins/Unity/Launcher/launchermodel.h 2015-02-09 17:17:59 +0000
332+++ plugins/Unity/Launcher/launchermodel.h 2015-05-11 07:50:04 +0000
333@@ -41,19 +41,19 @@
334 LauncherModel(QObject *parent = 0);
335 ~LauncherModel();
336
337- int rowCount(const QModelIndex &parent = QModelIndex()) const;
338-
339- QVariant data(const QModelIndex &index, int role) const;
340-
341- Q_INVOKABLE unity::shell::launcher::LauncherItemInterface* get(int index) const;
342- Q_INVOKABLE void move(int oldIndex, int newIndex);
343- Q_INVOKABLE void pin(const QString &appId, int index = -1);
344- Q_INVOKABLE void quickListActionInvoked(const QString &appId, int actionIndex);
345- Q_INVOKABLE void setUser(const QString &username);
346+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
347+
348+ QVariant data(const QModelIndex &index, int role) const override;
349+
350+ Q_INVOKABLE unity::shell::launcher::LauncherItemInterface* get(int index) const override;
351+ Q_INVOKABLE void move(int oldIndex, int newIndex) override;
352+ Q_INVOKABLE void pin(const QString &appId, int index = -1) override;
353+ Q_INVOKABLE void quickListActionInvoked(const QString &appId, int actionIndex) override;
354+ Q_INVOKABLE void setUser(const QString &username) override;
355 Q_INVOKABLE QString getUrlForAppId(const QString &appId) const;
356
357- unity::shell::application::ApplicationManagerInterface* applicationManager() const;
358- void setApplicationManager(unity::shell::application::ApplicationManagerInterface *appManager);
359+ unity::shell::application::ApplicationManagerInterface* applicationManager() const override;
360+ void setApplicationManager(unity::shell::application::ApplicationManagerInterface *appManager) override;
361
362 bool onlyPinned() const override;
363 void setOnlyPinned(bool onlyPinned) override;
364@@ -61,7 +61,7 @@
365 int findApplication(const QString &appId);
366
367 public Q_SLOTS:
368- void requestRemove(const QString &appId);
369+ void requestRemove(const QString &appId) override;
370 Q_INVOKABLE void refresh();
371
372 private:
373
374=== modified file 'plugins/Unity/Launcher/plugin.h'
375--- plugins/Unity/Launcher/plugin.h 2013-06-26 14:08:43 +0000
376+++ plugins/Unity/Launcher/plugin.h 2015-05-11 07:50:04 +0000
377@@ -28,7 +28,7 @@
378 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
379
380 public:
381- void registerTypes(const char *uri);
382+ void registerTypes(const char *uri) override;
383 };
384
385 #endif
386
387=== modified file 'plugins/Unity/Launcher/quicklistmodel.h'
388--- plugins/Unity/Launcher/quicklistmodel.h 2014-08-26 11:34:22 +0000
389+++ plugins/Unity/Launcher/quicklistmodel.h 2015-05-11 07:50:04 +0000
390@@ -48,8 +48,8 @@
391
392 QuickListEntry get(int index) const;
393
394- int rowCount(const QModelIndex &parent = QModelIndex()) const;
395- QVariant data(const QModelIndex &index, int role) const;
396+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
397+ QVariant data(const QModelIndex &index, int role) const override;
398
399 private:
400 QList<QuickListEntry> m_list;
401
402=== modified file 'plugins/Unity/Session/plugin.h'
403--- plugins/Unity/Session/plugin.h 2014-05-07 15:21:51 +0000
404+++ plugins/Unity/Session/plugin.h 2015-05-11 07:50:04 +0000
405@@ -28,7 +28,7 @@
406 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
407
408 public:
409- void registerTypes(const char *uri);
410+ void registerTypes(const char *uri) override;
411 };
412
413 #endif
414
415=== modified file 'plugins/Utils/HomeKeyWatcher.h'
416--- plugins/Utils/HomeKeyWatcher.h 2015-04-23 12:49:15 +0000
417+++ plugins/Utils/HomeKeyWatcher.h 2015-05-11 07:50:04 +0000
418@@ -49,7 +49,7 @@
419
420 virtual ~HomeKeyWatcher();
421
422- bool eventFilter(QObject *watched, QEvent *event);
423+ bool eventFilter(QObject *watched, QEvent *event) override;
424
425 void update(QEvent *event);
426
427
428=== modified file 'plugins/Utils/plugin.h'
429--- plugins/Utils/plugin.h 2013-10-07 22:32:43 +0000
430+++ plugins/Utils/plugin.h 2015-05-11 07:50:04 +0000
431@@ -28,8 +28,8 @@
432 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
433
434 public:
435- void registerTypes(const char *uri);
436- void initializeEngine(QQmlEngine *engine, const char *uri);
437+ void registerTypes(const char *uri) override;
438+ void initializeEngine(QQmlEngine *engine, const char *uri) override;
439 };
440
441 #endif
442
443=== modified file 'plugins/Utils/qlimitproxymodelqml.h'
444--- plugins/Utils/qlimitproxymodelqml.h 2013-08-20 15:13:59 +0000
445+++ plugins/Utils/qlimitproxymodelqml.h 2015-05-11 07:50:04 +0000
446@@ -32,8 +32,8 @@
447
448 /* getters */
449 int limit() const;
450- int rowCount(const QModelIndex &parent = QModelIndex()) const;
451- QHash<int, QByteArray> roleNames() const;
452+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
453+ QHash<int, QByteArray> roleNames() const override;
454
455 /* setters */
456 void setModel(QAbstractItemModel *model);
457
458=== modified file 'plugins/Utils/qvariantlistmodel.h'
459--- plugins/Utils/qvariantlistmodel.h 2013-06-05 22:03:08 +0000
460+++ plugins/Utils/qvariantlistmodel.h 2015-05-11 07:50:04 +0000
461@@ -54,14 +54,14 @@
462
463 ~QVariantListModel();
464
465- int rowCount(const QModelIndex &parent = QModelIndex()) const;
466- QModelIndex sibling(int row, int column, const QModelIndex &idx) const;
467-
468- QVariant data(const QModelIndex &index, int role) const;
469- bool setData(const QModelIndex &index, const QVariant &value, int role = Qt::EditRole);
470-
471- bool insertRows(int row, int count, const QModelIndex &parent = QModelIndex());
472- bool removeRows(int row, int count, const QModelIndex &parent = QModelIndex());
473+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
474+ QModelIndex sibling(int row, int column, const QModelIndex &idx) const override;
475+
476+ QVariant data(const QModelIndex &index, int role) const override;
477+ bool setData(const QModelIndex &index, const QVariant &value, int role = Qt::EditRole) override;
478+
479+ bool insertRows(int row, int count, const QModelIndex &parent = QModelIndex()) override;
480+ bool removeRows(int row, int count, const QModelIndex &parent = QModelIndex()) override;
481
482 QVariantList variantList() const;
483 void setVariantList(const QVariantList &list);
484
485=== modified file 'plugins/Utils/timeformatter.h'
486--- plugins/Utils/timeformatter.h 2014-09-03 12:11:09 +0000
487+++ plugins/Utils/timeformatter.h 2015-05-11 07:50:04 +0000
488@@ -62,7 +62,7 @@
489 GDateTimeFormatter(QObject *parent = 0);
490
491 protected:
492- virtual QString formatTime() const;
493+ QString formatTime() const override;
494 };
495
496 #endif
497
498=== modified file 'plugins/Utils/unitysortfilterproxymodelqml.h'
499--- plugins/Utils/unitysortfilterproxymodelqml.h 2014-12-19 14:51:35 +0000
500+++ plugins/Utils/unitysortfilterproxymodelqml.h 2015-05-11 07:50:04 +0000
501@@ -36,12 +36,12 @@
502 Q_INVOKABLE int count();
503 Q_INVOKABLE int findFirst(int role, const QVariant& value) const;
504 Q_INVOKABLE int mapRowToSource(int row);
505- virtual bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const;
506+ bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;
507
508 /* getters */
509 int totalCount() const;
510 bool invertMatch() const;
511- QHash<int, QByteArray> roleNames() const;
512+ QHash<int, QByteArray> roleNames() const override;
513
514 /* setters */
515 void setModel(QAbstractItemModel *model);
516
517=== modified file 'plugins/Utils/windowkeysfilter.h'
518--- plugins/Utils/windowkeysfilter.h 2014-07-18 10:20:42 +0000
519+++ plugins/Utils/windowkeysfilter.h 2015-05-11 07:50:04 +0000
520@@ -39,7 +39,7 @@
521 public:
522 WindowKeysFilter(QQuickItem *parent = 0);
523
524- bool eventFilter(QObject *watched, QEvent *event);
525+ bool eventFilter(QObject *watched, QEvent *event) override;
526
527 private Q_SLOTS:
528 void setupFilterOnWindow(QQuickWindow *window);
529
530=== modified file 'plugins/Wizard/plugin.h'
531--- plugins/Wizard/plugin.h 2014-11-24 17:56:44 +0000
532+++ plugins/Wizard/plugin.h 2015-05-11 07:50:04 +0000
533@@ -26,7 +26,7 @@
534 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
535
536 public:
537- void registerTypes(const char *uri);
538+ void registerTypes(const char *uri) override;
539 };
540
541 #endif
542
543=== modified file 'tests/mocks/AccountsService/plugin.h'
544--- tests/mocks/AccountsService/plugin.h 2013-08-27 17:34:46 +0000
545+++ tests/mocks/AccountsService/plugin.h 2015-05-11 07:50:04 +0000
546@@ -29,7 +29,7 @@
547 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
548
549 public:
550- void registerTypes(const char *uri);
551+ void registerTypes(const char *uri) override;
552 };
553
554 #endif
555
556=== modified file 'tests/mocks/GSettings.1.0/plugin.h'
557--- tests/mocks/GSettings.1.0/plugin.h 2013-08-12 13:05:38 +0000
558+++ tests/mocks/GSettings.1.0/plugin.h 2015-05-11 07:50:04 +0000
559@@ -25,7 +25,7 @@
560 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
561
562 public:
563- void registerTypes(const char *uri);
564+ void registerTypes(const char *uri) override;
565 };
566
567 #endif // PLUGIN_H
568
569=== modified file 'tests/mocks/LightDM/liblightdm/UsersModel.h'
570--- tests/mocks/LightDM/liblightdm/UsersModel.h 2015-01-20 11:50:19 +0000
571+++ tests/mocks/LightDM/liblightdm/UsersModel.h 2015-05-11 07:50:04 +0000
572@@ -53,8 +53,8 @@
573 BackgroundPathRole
574 };
575
576- int rowCount(const QModelIndex &parent) const;
577- QVariant data(const QModelIndex &index, int role) const;
578+ int rowCount(const QModelIndex &parent) const override;
579+ QVariant data(const QModelIndex &index, int role) const override;
580
581 QString mockMode() const;
582 void setMockMode(QString mockMode);
583
584=== modified file 'tests/mocks/LightDM/plugin.h'
585--- tests/mocks/LightDM/plugin.h 2015-01-20 11:50:19 +0000
586+++ tests/mocks/LightDM/plugin.h 2015-05-11 07:50:04 +0000
587@@ -26,7 +26,7 @@
588 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
589
590 public:
591- void registerTypes(const char *uri);
592+ void registerTypes(const char *uri) override;
593 };
594
595 #endif
596
597=== modified file 'tests/mocks/Lights/plugin.h'
598--- tests/mocks/Lights/plugin.h 2014-11-24 11:56:32 +0000
599+++ tests/mocks/Lights/plugin.h 2015-05-11 07:50:04 +0000
600@@ -26,7 +26,7 @@
601 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
602
603 public:
604- void registerTypes(const char *uri);
605+ void registerTypes(const char *uri) override;
606 };
607
608 #endif
609
610=== modified file 'tests/mocks/MeeGo/QOfono/plugin.h'
611--- tests/mocks/MeeGo/QOfono/plugin.h 2014-11-21 19:28:16 +0000
612+++ tests/mocks/MeeGo/QOfono/plugin.h 2015-05-11 07:50:04 +0000
613@@ -25,7 +25,7 @@
614 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
615
616 public:
617- void registerTypes(const char *uri);
618+ void registerTypes(const char *uri) override;
619 };
620
621 #endif // MOCK_QOFONO_PLUGIN_H
622
623=== modified file 'tests/mocks/Powerd/plugin.h'
624--- tests/mocks/Powerd/plugin.h 2013-08-09 14:35:36 +0000
625+++ tests/mocks/Powerd/plugin.h 2015-05-11 07:50:04 +0000
626@@ -28,7 +28,7 @@
627 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
628
629 public:
630- void registerTypes(const char *uri);
631+ void registerTypes(const char *uri) override;
632 };
633
634 #endif
635
636=== modified file 'tests/mocks/QMenuModel/plugin.h'
637--- tests/mocks/QMenuModel/plugin.h 2013-09-27 17:50:00 +0000
638+++ tests/mocks/QMenuModel/plugin.h 2015-05-11 07:50:04 +0000
639@@ -28,7 +28,7 @@
640 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
641
642 public:
643- void registerTypes(const char *uri);
644+ void registerTypes(const char *uri) override;
645 };
646
647 #endif
648
649=== modified file 'tests/mocks/QMenuModel/unitymenumodel.h'
650--- tests/mocks/QMenuModel/unitymenumodel.h 2014-10-07 10:28:59 +0000
651+++ tests/mocks/QMenuModel/unitymenumodel.h 2015-05-11 07:50:04 +0000
652@@ -61,12 +61,12 @@
653
654 QString nameOwner() const;
655
656- int rowCount(const QModelIndex &parent = QModelIndex()) const;
657- int columnCount(const QModelIndex &parent = QModelIndex()) const;
658- QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const;
659- QModelIndex index(int row, int column = 0, const QModelIndex &parent = QModelIndex()) const;
660- QModelIndex parent(const QModelIndex &index) const;
661- QHash<int, QByteArray> roleNames() const;
662+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
663+ int columnCount(const QModelIndex &parent = QModelIndex()) const override;
664+ QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
665+ QModelIndex index(int row, int column = 0, const QModelIndex &parent = QModelIndex()) const override;
666+ QModelIndex parent(const QModelIndex &index) const override;
667+ QHash<int, QByteArray> roleNames() const override;
668
669 Q_INVOKABLE QObject * submenu(int position, QQmlComponent* actionStateParser = nullptr);
670 Q_INVOKABLE bool loadExtendedAttributes(int position, const QVariantMap &schema);
671
672=== modified file 'tests/mocks/QtMultimedia/plugin.h'
673--- tests/mocks/QtMultimedia/plugin.h 2013-11-14 11:48:33 +0000
674+++ tests/mocks/QtMultimedia/plugin.h 2015-05-11 07:50:04 +0000
675@@ -28,7 +28,7 @@
676 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
677
678 public:
679- void registerTypes(const char *uri);
680+ void registerTypes(const char *uri) override;
681 };
682
683 #endif
684
685=== modified file 'tests/mocks/Ubuntu/Connectivity/plugin.h'
686--- tests/mocks/Ubuntu/Connectivity/plugin.h 2014-09-01 11:24:02 +0000
687+++ tests/mocks/Ubuntu/Connectivity/plugin.h 2015-05-11 07:50:04 +0000
688@@ -28,8 +28,8 @@
689 Q_INTERFACES(QQmlExtensionInterface)
690
691 public:
692- void registerTypes(const char *uri);
693- void initializeEngine(QQmlEngine *engine, const char *uri);
694+ void registerTypes(const char *uri) override;
695+ void initializeEngine(QQmlEngine *engine, const char *uri) override;
696 };
697
698 #endif // QML_CONNECTIVITY_PLUGIN_H
699
700=== modified file 'tests/mocks/Ubuntu/DownloadDaemonListener/plugin.h'
701--- tests/mocks/Ubuntu/DownloadDaemonListener/plugin.h 2013-08-05 14:52:55 +0000
702+++ tests/mocks/Ubuntu/DownloadDaemonListener/plugin.h 2015-05-11 07:50:04 +0000
703@@ -24,7 +24,7 @@
704 Q_OBJECT
705 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
706 public:
707- void registerTypes(const char *uri);
708+ void registerTypes(const char *uri) override;
709 };
710
711 #endif
712
713=== modified file 'tests/mocks/Ubuntu/Payments/plugin.h'
714--- tests/mocks/Ubuntu/Payments/plugin.h 2014-06-27 20:53:24 +0000
715+++ tests/mocks/Ubuntu/Payments/plugin.h 2015-05-11 07:50:04 +0000
716@@ -25,7 +25,7 @@
717 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
718
719 public:
720- void registerTypes(const char *uri);
721+ void registerTypes(const char *uri) override;
722 };
723
724 #endif // PAYMENTS_PLUGIN_H
725
726=== modified file 'tests/mocks/Ubuntu/SystemImage/plugin.h'
727--- tests/mocks/Ubuntu/SystemImage/plugin.h 2014-07-30 11:08:29 +0000
728+++ tests/mocks/Ubuntu/SystemImage/plugin.h 2015-05-11 07:50:04 +0000
729@@ -25,7 +25,7 @@
730 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
731
732 public:
733- void registerTypes(const char *uri);
734+ void registerTypes(const char *uri) override;
735 };
736
737 #endif // MOCK_SYSTEMIMAGE_PLUGIN_H
738
739=== modified file 'tests/mocks/Ubuntu/SystemSettings/SecurityPrivacy/plugin.h'
740--- tests/mocks/Ubuntu/SystemSettings/SecurityPrivacy/plugin.h 2014-11-21 19:28:16 +0000
741+++ tests/mocks/Ubuntu/SystemSettings/SecurityPrivacy/plugin.h 2015-05-11 07:50:04 +0000
742@@ -25,7 +25,7 @@
743 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
744
745 public:
746- void registerTypes(const char *uri);
747+ void registerTypes(const char *uri) override;
748 };
749
750 #endif // MOCK_SECURITYPRIVACY_PLUGIN_H
751
752=== modified file 'tests/mocks/Ubuntu/Telephony/MockCallEntry.h'
753--- tests/mocks/Ubuntu/Telephony/MockCallEntry.h 2014-09-11 14:53:35 +0000
754+++ tests/mocks/Ubuntu/Telephony/MockCallEntry.h 2015-05-11 07:50:04 +0000
755@@ -53,7 +53,7 @@
756 void elapsedTimerRunningChanged();
757
758 protected:
759- void timerEvent(QTimerEvent * event);
760+ void timerEvent(QTimerEvent * event) override;
761
762 private:
763 QString m_phoneNumber;
764
765=== modified file 'tests/mocks/Ubuntu/Telephony/plugin.h'
766--- tests/mocks/Ubuntu/Telephony/plugin.h 2014-04-30 18:06:38 +0000
767+++ tests/mocks/Ubuntu/Telephony/plugin.h 2015-05-11 07:50:04 +0000
768@@ -27,8 +27,8 @@
769 Q_OBJECT
770 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
771 public:
772- void initializeEngine(QQmlEngine *engine, const char *uri);
773- void registerTypes(const char *uri);
774+ void initializeEngine(QQmlEngine *engine, const char *uri) override;
775+ void registerTypes(const char *uri) override;
776
777 private:
778 QQmlContext *mRootContext;
779
780=== modified file 'tests/mocks/Unity/Application/ObjectListModel.h'
781--- tests/mocks/Unity/Application/ObjectListModel.h 2014-08-29 11:22:48 +0000
782+++ tests/mocks/Unity/Application/ObjectListModel.h 2015-05-11 07:50:04 +0000
783@@ -76,7 +76,7 @@
784 return QVariant();
785 }
786
787- QHash<int, QByteArray> roleNames() const
788+ QHash<int, QByteArray> roleNames() const override
789 {
790 QHash<int, QByteArray> roleNames;
791 roleNames.insert(RoleModelData, "modelData");
792
793=== modified file 'tests/mocks/Unity/Application/plugin.h'
794--- tests/mocks/Unity/Application/plugin.h 2014-01-20 11:34:59 +0000
795+++ tests/mocks/Unity/Application/plugin.h 2015-05-11 07:50:04 +0000
796@@ -24,8 +24,8 @@
797 Q_OBJECT
798 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
799 public:
800- void registerTypes(const char *uri);
801- void initializeEngine(QQmlEngine *engine, const char *uri);
802+ void registerTypes(const char *uri) override;
803+ void initializeEngine(QQmlEngine *engine, const char *uri) override;
804 };
805
806 #endif
807
808=== modified file 'tests/mocks/Unity/Connectivity/plugin.h'
809--- tests/mocks/Unity/Connectivity/plugin.h 2014-08-15 18:41:51 +0000
810+++ tests/mocks/Unity/Connectivity/plugin.h 2015-05-11 07:50:04 +0000
811@@ -25,7 +25,7 @@
812 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
813
814 public:
815- void registerTypes(const char *uri);
816+ void registerTypes(const char *uri) override;
817 };
818
819 #endif // MOCK_CONNECTIVITY_PLUGIN_H
820
821=== modified file 'tests/mocks/Unity/DashCommunicator/plugin.h'
822--- tests/mocks/Unity/DashCommunicator/plugin.h 2014-07-29 11:35:10 +0000
823+++ tests/mocks/Unity/DashCommunicator/plugin.h 2015-05-11 07:50:04 +0000
824@@ -28,7 +28,7 @@
825 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
826
827 public:
828- void registerTypes(const char *uri);
829+ void registerTypes(const char *uri) override;
830 };
831
832 #endif
833
834=== modified file 'tests/mocks/Unity/Indicators/fakeindicatorsmodel.h'
835--- tests/mocks/Unity/Indicators/fakeindicatorsmodel.h 2014-11-17 23:04:48 +0000
836+++ tests/mocks/Unity/Indicators/fakeindicatorsmodel.h 2015-05-11 07:50:04 +0000
837@@ -50,11 +50,11 @@
838 QVariant modelData() const { return m_modelData; }
839
840 /* QAbstractItemModel */
841- QHash<int, QByteArray> roleNames() const;
842- int columnCount(const QModelIndex &parent = QModelIndex()) const;
843- QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const;
844- QModelIndex parent (const QModelIndex &index) const;
845- int rowCount(const QModelIndex &parent = QModelIndex()) const;
846+ QHash<int, QByteArray> roleNames() const override;
847+ int columnCount(const QModelIndex &parent = QModelIndex()) const override;
848+ QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
849+ QModelIndex parent (const QModelIndex &index) const override;
850+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
851
852 Q_SIGNALS:
853 void countChanged();
854
855=== modified file 'tests/mocks/Unity/Indicators/fakeplugin.h'
856--- tests/mocks/Unity/Indicators/fakeplugin.h 2013-07-01 09:40:30 +0000
857+++ tests/mocks/Unity/Indicators/fakeplugin.h 2015-05-11 07:50:04 +0000
858@@ -26,7 +26,7 @@
859 Q_OBJECT
860 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
861 public:
862- void registerTypes(const char *uri);
863+ void registerTypes(const char *uri) override;
864 };
865
866 #endif // INDICATORS_FAKE_PLUGIN_H
867
868=== modified file 'tests/mocks/Unity/Launcher/MockLauncherItem.h'
869--- tests/mocks/Unity/Launcher/MockLauncherItem.h 2014-09-02 18:22:37 +0000
870+++ tests/mocks/Unity/Launcher/MockLauncherItem.h 2015-05-11 07:50:04 +0000
871@@ -43,9 +43,9 @@
872 int progress() const override;
873 int count() const override;
874 bool countVisible() const override;
875- bool focused() const;
876+ bool focused() const override;
877
878- unity::shell::launcher::QuickListModelInterface *quickList() const;
879+ unity::shell::launcher::QuickListModelInterface *quickList() const override;
880
881 private:
882 void setPinned(bool pinned);
883
884=== modified file 'tests/mocks/Unity/Launcher/MockLauncherModel.h'
885--- tests/mocks/Unity/Launcher/MockLauncherModel.h 2015-02-09 17:17:59 +0000
886+++ tests/mocks/Unity/Launcher/MockLauncherModel.h 2015-05-11 07:50:04 +0000
887@@ -34,20 +34,20 @@
888 MockLauncherModel(QObject* parent = 0);
889 ~MockLauncherModel();
890
891- int rowCount(const QModelIndex& parent) const;
892-
893- QVariant data(const QModelIndex& index, int role) const;
894-
895- Q_INVOKABLE unity::shell::launcher::LauncherItemInterface *get(int index) const;
896- Q_INVOKABLE void move(int oldIndex, int newIndex);
897- Q_INVOKABLE void pin(const QString &appId, int index = -1);
898- Q_INVOKABLE void requestRemove(const QString &appId);
899- Q_INVOKABLE void quickListActionInvoked(const QString &appId, int actionIndex);
900- Q_INVOKABLE void setUser(const QString &username);
901+ int rowCount(const QModelIndex& parent) const override;
902+
903+ QVariant data(const QModelIndex& index, int role) const override;
904+
905+ Q_INVOKABLE unity::shell::launcher::LauncherItemInterface *get(int index) const override;
906+ Q_INVOKABLE void move(int oldIndex, int newIndex) override;
907+ Q_INVOKABLE void pin(const QString &appId, int index = -1) override;
908+ Q_INVOKABLE void requestRemove(const QString &appId) override;
909+ Q_INVOKABLE void quickListActionInvoked(const QString &appId, int actionIndex) override;
910+ Q_INVOKABLE void setUser(const QString &username) override;
911 Q_INVOKABLE QString getUrlForAppId(const QString &appId) const;
912
913- unity::shell::application::ApplicationManagerInterface *applicationManager() const;
914- void setApplicationManager(unity::shell::application::ApplicationManagerInterface *applicationManager);
915+ unity::shell::application::ApplicationManagerInterface *applicationManager() const override;
916+ void setApplicationManager(unity::shell::application::ApplicationManagerInterface *applicationManager) override;
917
918 bool onlyPinned() const override;
919 void setOnlyPinned(bool onlyPinned) override;
920
921=== modified file 'tests/mocks/Unity/Launcher/MockQuickListModel.h'
922--- tests/mocks/Unity/Launcher/MockQuickListModel.h 2013-07-05 11:25:54 +0000
923+++ tests/mocks/Unity/Launcher/MockQuickListModel.h 2015-05-11 07:50:04 +0000
924@@ -30,9 +30,9 @@
925 public:
926 MockQuickListModel(QObject *parent = 0);
927
928- QVariant data(const QModelIndex &index, int role) const;
929+ QVariant data(const QModelIndex &index, int role) const override;
930
931- int rowCount(const QModelIndex &parent = QModelIndex()) const;
932+ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
933 };
934
935 #endif // MOCKQUICKLISTMODEL_H
936
937=== modified file 'tests/mocks/Unity/Launcher/plugin.h'
938--- tests/mocks/Unity/Launcher/plugin.h 2013-07-05 11:25:54 +0000
939+++ tests/mocks/Unity/Launcher/plugin.h 2015-05-11 07:50:04 +0000
940@@ -29,7 +29,7 @@
941 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
942
943 public:
944- void registerTypes(const char* uri);
945+ void registerTypes(const char* uri) override;
946 };
947
948 #endif // TESTLAUNCHER_PLUGIN_H
949
950=== modified file 'tests/mocks/Unity/Notifications/MockActionModel.h'
951--- tests/mocks/Unity/Notifications/MockActionModel.h 2015-01-26 12:16:11 +0000
952+++ tests/mocks/Unity/Notifications/MockActionModel.h 2015-05-11 07:50:04 +0000
953@@ -32,9 +32,9 @@
954 ActionModel(QObject *parent=nullptr);
955 virtual ~ActionModel();
956
957- virtual int rowCount(const QModelIndex &index) const;
958- virtual QVariant data(const QModelIndex &index, int role) const;
959- virtual QHash<int, QByteArray> roleNames() const;
960+ int rowCount(const QModelIndex &index) const override;
961+ QVariant data(const QModelIndex &index, int role) const override;
962+ QHash<int, QByteArray> roleNames() const override;
963
964 Q_ENUMS(ActionsRoles)
965 enum ActionsRoles {
966
967=== modified file 'tests/mocks/Unity/Notifications/MockNotificationModel.h'
968--- tests/mocks/Unity/Notifications/MockNotificationModel.h 2015-01-26 12:03:19 +0000
969+++ tests/mocks/Unity/Notifications/MockNotificationModel.h 2015-05-11 07:50:04 +0000
970@@ -35,9 +35,9 @@
971 MockNotificationModel(QObject *parent=nullptr);
972 virtual ~MockNotificationModel();
973
974- virtual int rowCount(const QModelIndex &parent) const;
975- virtual QVariant data(const QModelIndex &index, int role) const;
976- virtual QHash<int, QByteArray> roleNames() const;
977+ int rowCount(const QModelIndex &parent) const override;
978+ QVariant data(const QModelIndex &index, int role) const override;
979+ QHash<int, QByteArray> roleNames() const override;
980
981 Q_INVOKABLE void append(MockNotification* n);
982 MockNotification* getNotification(int id) const;
983
984=== modified file 'tests/mocks/Unity/Notifications/plugin.h'
985--- tests/mocks/Unity/Notifications/plugin.h 2015-01-12 15:32:40 +0000
986+++ tests/mocks/Unity/Notifications/plugin.h 2015-05-11 07:50:04 +0000
987@@ -28,7 +28,7 @@
988 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
989
990 public:
991- void registerTypes(const char* uri);
992+ void registerTypes(const char* uri) override;
993 };
994
995 #endif // TESTNOTIFICATION_PLUGIN_H
996
997=== modified file 'tests/mocks/Unity/fake_scopes.h'
998--- tests/mocks/Unity/fake_scopes.h 2015-02-12 12:20:49 +0000
999+++ tests/mocks/Unity/fake_scopes.h 2015-05-11 07:50:04 +0000
1000@@ -50,8 +50,8 @@
1001 Q_INVOKABLE void clearFavorites();
1002 Q_INVOKABLE void load();
1003
1004- QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const;
1005- QModelIndex parent ( const QModelIndex & index ) const;
1006+ QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;
1007+ QModelIndex parent ( const QModelIndex & index ) const override;
1008
1009 bool loaded() const override;
1010 int count() const override;
1011
1012=== modified file 'tests/mocks/Unity/fake_unity_plugin.h'
1013--- tests/mocks/Unity/fake_unity_plugin.h 2013-06-05 22:03:08 +0000
1014+++ tests/mocks/Unity/fake_unity_plugin.h 2015-05-11 07:50:04 +0000
1015@@ -28,7 +28,7 @@
1016 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
1017
1018 public:
1019- void registerTypes(const char *uri);
1020+ void registerTypes(const char *uri) override;
1021 };
1022
1023 #endif
1024
1025=== modified file 'tests/mocks/Wizard/mockplugin.h'
1026--- tests/mocks/Wizard/mockplugin.h 2014-11-14 17:47:00 +0000
1027+++ tests/mocks/Wizard/mockplugin.h 2015-05-11 07:50:04 +0000
1028@@ -26,7 +26,7 @@
1029 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
1030
1031 public:
1032- void registerTypes(const char *uri);
1033+ void registerTypes(const char *uri) override;
1034 };
1035
1036 #endif
1037
1038=== modified file 'tests/plugins/Dash/horizontaljournaltest.cpp'
1039--- tests/plugins/Dash/horizontaljournaltest.cpp 2014-05-15 14:50:23 +0000
1040+++ tests/plugins/Dash/horizontaljournaltest.cpp 2015-05-11 07:50:04 +0000
1041@@ -32,19 +32,19 @@
1042
1043 class WidthModel : public QAbstractListModel {
1044 public:
1045- QHash<int, QByteArray> roleNames() const
1046+ QHash<int, QByteArray> roleNames() const override
1047 {
1048 QHash<int, QByteArray> roles;
1049 roles.insert(Qt::DisplayRole, "modelWidth");
1050 return roles;
1051 }
1052
1053- int rowCount(const QModelIndex & /*parent*/) const
1054+ int rowCount(const QModelIndex & /*parent*/) const override
1055 {
1056 return m_list.count();
1057 }
1058
1059- QVariant data(const QModelIndex &index, int /*role*/) const
1060+ QVariant data(const QModelIndex &index, int /*role*/) const override
1061 {
1062 return m_list[index.row()];
1063 }
1064
1065=== modified file 'tests/plugins/Dash/horizontaljournaltry.cpp'
1066--- tests/plugins/Dash/horizontaljournaltry.cpp 2013-12-19 16:02:38 +0000
1067+++ tests/plugins/Dash/horizontaljournaltry.cpp 2015-05-11 07:50:04 +0000
1068@@ -29,7 +29,7 @@
1069 class QWidthModela : public QStringListModel {
1070 Q_OBJECT
1071 public:
1072- QHash<int, QByteArray> roleNames() const
1073+ QHash<int, QByteArray> roleNames() const override
1074 {
1075 QHash<int, QByteArray> roles;
1076 roles.insert(Qt::DisplayRole, "modelWidth");
1077
1078=== modified file 'tests/plugins/Dash/listviewwithpageheadersectionexternalmodeltest.cpp'
1079--- tests/plugins/Dash/listviewwithpageheadersectionexternalmodeltest.cpp 2014-06-05 08:38:51 +0000
1080+++ tests/plugins/Dash/listviewwithpageheadersectionexternalmodeltest.cpp 2015-05-11 07:50:04 +0000
1081@@ -37,7 +37,7 @@
1082 list << "A" << "B" << "C" << "D" << "E" << "F" << "G" << "H";
1083 }
1084
1085- int rowCount(const QModelIndex &parent) const
1086+ int rowCount(const QModelIndex &parent) const override
1087 {
1088 if (parent.isValid())
1089 return 0;
1090@@ -45,14 +45,14 @@
1091 return list.count();
1092 }
1093
1094- QVariant data(const QModelIndex &index, int role) const
1095+ QVariant data(const QModelIndex &index, int role) const override
1096 {
1097 if (role == Qt::SizeHintRole) return 50;
1098 else if (role == Qt::DisplayRole) return list[index.row()];
1099 return QVariant();
1100 }
1101
1102- QHash<int, QByteArray> roleNames() const
1103+ QHash<int, QByteArray> roleNames() const override
1104 {
1105 QHash<int, QByteArray> hash;
1106 hash.insert(Qt::DisplayRole, "type");
1107
1108=== modified file 'tests/plugins/Dash/organicgridtest.cpp'
1109--- tests/plugins/Dash/organicgridtest.cpp 2014-05-22 13:37:05 +0000
1110+++ tests/plugins/Dash/organicgridtest.cpp 2015-05-11 07:50:04 +0000
1111@@ -34,12 +34,12 @@
1112 public:
1113 DummyModel() : m_count(0) {}
1114
1115- int rowCount(const QModelIndex & /*parent*/) const
1116+ int rowCount(const QModelIndex & /*parent*/) const override
1117 {
1118 return m_count;
1119 }
1120
1121- QVariant data(const QModelIndex & /*index*/, int /*role*/) const
1122+ QVariant data(const QModelIndex & /*index*/, int /*role*/) const override
1123 {
1124 return QVariant();
1125 }
1126
1127=== modified file 'tests/plugins/Dash/organicgridtry.cpp'
1128--- tests/plugins/Dash/organicgridtry.cpp 2014-01-14 12:25:52 +0000
1129+++ tests/plugins/Dash/organicgridtry.cpp 2015-05-11 07:50:04 +0000
1130@@ -31,12 +31,12 @@
1131 public:
1132 DummyModel() : m_count(0) {}
1133
1134- int rowCount(const QModelIndex & /*parent*/) const
1135+ int rowCount(const QModelIndex & /*parent*/) const override
1136 {
1137 return m_count;
1138 }
1139
1140- QVariant data(const QModelIndex & /*index*/, int /*role*/) const
1141+ QVariant data(const QModelIndex & /*index*/, int /*role*/) const override
1142 {
1143 return QVariant();
1144 }
1145
1146=== modified file 'tests/plugins/Dash/verticaljournaltest.cpp'
1147--- tests/plugins/Dash/verticaljournaltest.cpp 2014-05-15 14:50:23 +0000
1148+++ tests/plugins/Dash/verticaljournaltest.cpp 2015-05-11 07:50:04 +0000
1149@@ -32,19 +32,19 @@
1150
1151 class HeightModel : public QAbstractListModel {
1152 public:
1153- QHash<int, QByteArray> roleNames() const
1154+ QHash<int, QByteArray> roleNames() const override
1155 {
1156 QHash<int, QByteArray> roles;
1157 roles.insert(Qt::DisplayRole, "modelHeight");
1158 return roles;
1159 }
1160
1161- int rowCount(const QModelIndex & /*parent*/) const
1162+ int rowCount(const QModelIndex & /*parent*/) const override
1163 {
1164 return m_list.count();
1165 }
1166
1167- QVariant data(const QModelIndex &index, int /*role*/) const
1168+ QVariant data(const QModelIndex &index, int /*role*/) const override
1169 {
1170 return m_list[index.row()];
1171 }
1172
1173=== modified file 'tests/plugins/Dash/verticaljournaltry.cpp'
1174--- tests/plugins/Dash/verticaljournaltry.cpp 2013-12-17 16:35:44 +0000
1175+++ tests/plugins/Dash/verticaljournaltry.cpp 2015-05-11 07:50:04 +0000
1176@@ -29,7 +29,7 @@
1177 class QHeightModel : public QStringListModel {
1178 Q_OBJECT
1179 public:
1180- QHash<int, QByteArray> roleNames() const
1181+ QHash<int, QByteArray> roleNames() const override
1182 {
1183 QHash<int, QByteArray> roles;
1184 roles.insert(Qt::DisplayRole, "modelHeight");
1185
1186=== modified file 'tests/plugins/Ubuntu/Gestures/tst_AxisVelocityCalculator.cpp'
1187--- tests/plugins/Ubuntu/Gestures/tst_AxisVelocityCalculator.cpp 2013-10-22 15:56:37 +0000
1188+++ tests/plugins/Ubuntu/Gestures/tst_AxisVelocityCalculator.cpp 2015-05-11 07:50:04 +0000
1189@@ -24,7 +24,7 @@
1190 public:
1191 FakeTimeSource() : m_value(0) {}
1192
1193- virtual qint64 msecsSinceReference() {
1194+ qint64 msecsSinceReference() override {
1195 return m_value;
1196 }
1197
1198
1199=== modified file 'tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp'
1200--- tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp 2015-04-10 21:16:37 +0000
1201+++ tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp 2015-05-11 07:50:04 +0000
1202@@ -84,7 +84,7 @@
1203 public:
1204 tst_DirectionalDragArea();
1205 private Q_SLOTS:
1206- void init(); // called right before each and every test function is executed
1207+ void init() override; // called right before each and every test function is executed
1208
1209 void dragWithShortDirectionChange();
1210 void recognitionTimerUsage();
1211
1212=== modified file 'tests/plugins/Ubuntu/Gestures/tst_PressedOutsideNotifier.cpp'
1213--- tests/plugins/Ubuntu/Gestures/tst_PressedOutsideNotifier.cpp 2013-11-22 13:43:40 +0000
1214+++ tests/plugins/Ubuntu/Gestures/tst_PressedOutsideNotifier.cpp 2015-05-11 07:50:04 +0000
1215@@ -28,7 +28,7 @@
1216 public:
1217 tst_PressedOutsideNotifier();
1218 private Q_SLOTS:
1219- void init(); // called right before each and every test function is executed
1220+ void init() override; // called right before each and every test function is executed
1221
1222 void touchOutsideAreaTriggersSignal();
1223 void touchInsideAreaHasNoEffect();
1224
1225=== modified file 'tests/plugins/Unity/Indicators/menucontentactivatortest.cpp'
1226--- tests/plugins/Unity/Indicators/menucontentactivatortest.cpp 2013-12-12 12:25:20 +0000
1227+++ tests/plugins/Unity/Indicators/menucontentactivatortest.cpp 2015-05-11 07:50:04 +0000
1228@@ -30,8 +30,8 @@
1229 : UnityIndicators::AbstractTimer(parent)
1230 {}
1231
1232- virtual int interval() const { return m_duration; }
1233- virtual void setInterval(int msecs) { m_duration = msecs; }
1234+ int interval() const override { return m_duration; }
1235+ void setInterval(int msecs) override { m_duration = msecs; }
1236
1237 void emitTimeout() {
1238 if (isRunning()) {
1239
1240=== modified file 'tests/plugins/Unity/Launcher/launchermodeltest.cpp'
1241--- tests/plugins/Unity/Launcher/launchermodeltest.cpp 2015-03-30 17:36:42 +0000
1242+++ tests/plugins/Unity/Launcher/launchermodeltest.cpp 2015-05-11 07:50:04 +0000
1243@@ -39,13 +39,13 @@
1244 Q_OBJECT
1245 public:
1246 MockApp(const QString &appId, QObject *parent = 0): ApplicationInfoInterface(appId, parent), m_appId(appId), m_focused(false) { }
1247- QString appId() const { return m_appId; }
1248- QString name() const { return "mock"; }
1249- QString comment() const { return "this is a mock"; }
1250- QUrl icon() const { return QUrl(); }
1251- ApplicationInfoInterface::Stage stage() const { return ApplicationInfoInterface::MainStage; }
1252- ApplicationInfoInterface::State state() const { return ApplicationInfoInterface::Running; }
1253- bool focused() const { return m_focused; }
1254+ QString appId() const override { return m_appId; }
1255+ QString name() const override { return "mock"; }
1256+ QString comment() const override { return "this is a mock"; }
1257+ QUrl icon() const override { return QUrl(); }
1258+ ApplicationInfoInterface::Stage stage() const override { return ApplicationInfoInterface::MainStage; }
1259+ ApplicationInfoInterface::State state() const override { return ApplicationInfoInterface::Running; }
1260+ bool focused() const override { return m_focused; }
1261 QString splashTitle() const override { return QString(); }
1262 QUrl splashImage() const override { return QUrl(); }
1263 bool splashShowHeader() const override { return true; }
1264@@ -66,16 +66,16 @@
1265 Q_OBJECT
1266 public:
1267 MockAppManager(QObject *parent = 0): ApplicationManagerInterface(parent) {}
1268- int rowCount(const QModelIndex &) const { return m_list.count(); }
1269- QVariant data(const QModelIndex &, int ) const { return QVariant(); }
1270- QString focusedApplicationId() const {
1271+ int rowCount(const QModelIndex &) const override { return m_list.count(); }
1272+ QVariant data(const QModelIndex &, int ) const override { return QVariant(); }
1273+ QString focusedApplicationId() const override {
1274 Q_FOREACH(MockApp *app, m_list) {
1275 if (app->focused()) return app->appId();
1276 }
1277 return QString();
1278 }
1279- unity::shell::application::ApplicationInfoInterface *get(int index) const { return m_list.at(index); }
1280- unity::shell::application::ApplicationInfoInterface *findApplication(const QString &appId) const {
1281+ unity::shell::application::ApplicationInfoInterface *get(int index) const override { return m_list.at(index); }
1282+ unity::shell::application::ApplicationInfoInterface *findApplication(const QString &appId) const override {
1283 Q_FOREACH(MockApp* app, m_list) {
1284 if (app->appId() == appId) {
1285 return app;
1286@@ -83,8 +83,8 @@
1287 }
1288 return nullptr;
1289 }
1290- unity::shell::application::ApplicationInfoInterface *startApplication(const QString &, const QStringList &) { return nullptr; }
1291- bool stopApplication(const QString &appId) {
1292+ unity::shell::application::ApplicationInfoInterface *startApplication(const QString &, const QStringList &) override { return nullptr; }
1293+ bool stopApplication(const QString &appId) override {
1294 Q_FOREACH(MockApp* app, m_list) {
1295 if (app->appId() == appId) {
1296 removeApplication(m_list.indexOf(app));
1297@@ -93,7 +93,7 @@
1298 }
1299 return false;
1300 }
1301- bool focusApplication(const QString &appId) {
1302+ bool focusApplication(const QString &appId) override {
1303 Q_FOREACH(MockApp* app, m_list) {
1304 app->setFocused(app->appId() == appId);
1305 }
1306@@ -101,7 +101,7 @@
1307 return true;
1308 }
1309
1310- void unfocusCurrentApplication() { }
1311+ void unfocusCurrentApplication() override { }
1312
1313 void addApplication(MockApp *app) {
1314 beginInsertRows(QModelIndex(), count(), count());
1315@@ -113,11 +113,11 @@
1316 m_list.takeAt(index)->deleteLater();
1317 endRemoveRows();
1318 }
1319- bool requestFocusApplication(const QString &appId) { Q_UNUSED(appId); return true; }
1320- bool suspended() const { return false; }
1321- void setSuspended(bool) {}
1322- bool forceDashActive() const { return false; }
1323- void setForceDashActive(bool) {}
1324+ bool requestFocusApplication(const QString &appId) override { Q_UNUSED(appId); return true; }
1325+ bool suspended() const override { return false; }
1326+ void setSuspended(bool) override {}
1327+ bool forceDashActive() const override { return false; }
1328+ void setForceDashActive(bool) override {}
1329
1330 private:
1331 QList<MockApp*> m_list;
1332
1333=== modified file 'tests/plugins/Utils/qlimitproxymodeltest.cpp'
1334--- tests/plugins/Utils/qlimitproxymodeltest.cpp 2013-08-20 15:13:59 +0000
1335+++ tests/plugins/Utils/qlimitproxymodeltest.cpp 2015-05-11 07:50:04 +0000
1336@@ -36,12 +36,12 @@
1337 {
1338 }
1339
1340- int rowCount(const QModelIndex& /* parent */ = QModelIndex()) const
1341+ int rowCount(const QModelIndex& /* parent */ = QModelIndex()) const override
1342 {
1343 return m_list.size();
1344 }
1345
1346- QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const
1347+ QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override
1348 {
1349 if (!index.isValid() || index.row() < 0 || index.row() >= m_list.size() || role != Qt::DisplayRole) {
1350 return QVariant();
1351@@ -49,7 +49,7 @@
1352 return QVariant(m_list[index.row()]);
1353 }
1354
1355- QHash<int, QByteArray> roleNames() const
1356+ QHash<int, QByteArray> roleNames() const override
1357 {
1358 return m_roles;
1359 }
1360@@ -65,7 +65,7 @@
1361 endRemoveRows();
1362 }
1363
1364- bool insertRows(int row, int count, const QModelIndex &parent=QModelIndex()) {
1365+ bool insertRows(int row, int count, const QModelIndex &parent=QModelIndex()) override {
1366 beginInsertRows(parent, row, row+count-1);
1367 for (int i=0; i<count; i++) {
1368 m_list.insert(i+row, QString::number(i));
1369@@ -81,7 +81,7 @@
1370 return true;
1371 }
1372
1373- bool removeRows(int row, int count, const QModelIndex &parent=QModelIndex()) {
1374+ bool removeRows(int row, int count, const QModelIndex &parent=QModelIndex()) override {
1375 beginRemoveRows(parent, row, row+count-1);
1376 for (int i=0; i<count; i++) {
1377 m_list.removeAt(row);
1378
1379=== modified file 'tests/plugins/Utils/unitysortfilterproxymodeltest.cpp'
1380--- tests/plugins/Utils/unitysortfilterproxymodeltest.cpp 2014-12-19 14:51:35 +0000
1381+++ tests/plugins/Utils/unitysortfilterproxymodeltest.cpp 2015-05-11 07:50:04 +0000
1382@@ -39,12 +39,12 @@
1383 {
1384 }
1385
1386- int rowCount(const QModelIndex& /* parent */ = QModelIndex()) const
1387+ int rowCount(const QModelIndex& /* parent */ = QModelIndex()) const override
1388 {
1389 return m_list.size();
1390 }
1391
1392- QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const
1393+ QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override
1394 {
1395 if (!index.isValid() || index.row() < 0 || index.row() >= m_list.size() || role != Qt::DisplayRole) {
1396 return QVariant();
1397@@ -52,7 +52,7 @@
1398 return QVariant(m_list[index.row()]);
1399 }
1400
1401- QHash<int, QByteArray> roleNames() const
1402+ QHash<int, QByteArray> roleNames() const override
1403 {
1404 return m_roles;
1405 }
1406@@ -61,7 +61,7 @@
1407 m_roles = roles;
1408 }
1409
1410- bool insertRows(int row, int count, const QModelIndex &parent=QModelIndex()) {
1411+ bool insertRows(int row, int count, const QModelIndex &parent=QModelIndex()) override {
1412 beginInsertRows(parent, row, row+count-1);
1413 for (int i=0; i<count; i++) {
1414 m_list.insert(i+row, QString("test%1").arg(i));
1415@@ -77,7 +77,7 @@
1416 return true;
1417 }
1418
1419- bool removeRows(int row, int count, const QModelIndex &parent=QModelIndex()) {
1420+ bool removeRows(int row, int count, const QModelIndex &parent=QModelIndex()) override {
1421 beginRemoveRows(parent, row, row+count-1);
1422 for (int i=0; i<count; i++) {
1423 m_list.removeAt(row);
1424
1425=== modified file 'tests/utils/modules/Unity/Test/plugin.h'
1426--- tests/utils/modules/Unity/Test/plugin.h 2013-06-05 22:03:08 +0000
1427+++ tests/utils/modules/Unity/Test/plugin.h 2015-05-11 07:50:04 +0000
1428@@ -26,7 +26,7 @@
1429 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
1430
1431 public:
1432- void registerTypes(const char *uri);
1433+ void registerTypes(const char *uri) override;
1434 };
1435
1436 #endif // UNITY_TEST_PLUGIN_H

Subscribers

People subscribed via source and target branches