Merge lp:~aacid/unity8/add_override into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Michał Sawicz on 2015-04-30 |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1782 |
| Proposed branch: | lp:~aacid/unity8/add_override |
| Merge into: | lp:unity8 |
| Diff against target: |
1436 lines (+193/-193) 82 files modified
plugins/AccountsService/plugin.h (+1/-1) plugins/Dash/plugin.h (+1/-1) plugins/Greeter/Unity/Launcher/launchermodelas.h (+11/-11) plugins/Greeter/Unity/Launcher/plugin.h (+1/-1) plugins/Greeter/Unity/Launcher/quicklistmodel.h (+2/-2) plugins/LightDM/UsersModel.cpp (+1/-1) plugins/LightDM/liblightdm/UsersModel.h (+2/-2) plugins/LightDM/plugin.h (+1/-1) plugins/Lights/plugin.h (+1/-1) plugins/Powerd/plugin.h (+1/-1) plugins/ScreenGrabber/plugin.h (+1/-1) plugins/SessionBroadcast/plugin.h (+1/-1) plugins/Ubuntu/DownloadDaemonListener/plugin.h (+2/-2) plugins/Ubuntu/Gestures/DirectionalDragArea.h (+2/-2) plugins/Ubuntu/Gestures/plugin.h (+1/-1) plugins/Ubuntu/Payments/plugin.h (+1/-1) plugins/Ubuntu/SystemImage/plugin.h (+1/-1) plugins/Unity/Connectivity/plugin.h (+1/-1) plugins/Unity/DashCommunicator/plugin.h (+1/-1) plugins/Unity/Indicators/indicatorsmodel.h (+5/-5) plugins/Unity/Indicators/menucontentactivator.cpp (+4/-4) plugins/Unity/Indicators/plugin.h (+1/-1) plugins/Unity/Launcher/launchermodel.h (+12/-12) plugins/Unity/Launcher/plugin.h (+1/-1) plugins/Unity/Launcher/quicklistmodel.h (+2/-2) plugins/Unity/Session/plugin.h (+1/-1) plugins/Utils/HomeKeyWatcher.h (+1/-1) plugins/Utils/plugin.h (+2/-2) plugins/Utils/qlimitproxymodelqml.h (+2/-2) plugins/Utils/qvariantlistmodel.h (+8/-8) plugins/Utils/timeformatter.h (+1/-1) plugins/Utils/unitysortfilterproxymodelqml.h (+2/-2) plugins/Utils/windowkeysfilter.h (+1/-1) plugins/Wizard/plugin.h (+1/-1) tests/mocks/AccountsService/plugin.h (+1/-1) tests/mocks/GSettings.1.0/plugin.h (+1/-1) tests/mocks/LightDM/liblightdm/UsersModel.h (+2/-2) tests/mocks/LightDM/plugin.h (+1/-1) tests/mocks/Lights/plugin.h (+1/-1) tests/mocks/MeeGo/QOfono/plugin.h (+1/-1) tests/mocks/Powerd/plugin.h (+1/-1) tests/mocks/QMenuModel/plugin.h (+1/-1) tests/mocks/QMenuModel/unitymenumodel.h (+6/-6) tests/mocks/QtMultimedia/plugin.h (+1/-1) tests/mocks/Ubuntu/Connectivity/plugin.h (+2/-2) tests/mocks/Ubuntu/DownloadDaemonListener/plugin.h (+1/-1) tests/mocks/Ubuntu/Payments/plugin.h (+1/-1) tests/mocks/Ubuntu/SystemImage/plugin.h (+1/-1) tests/mocks/Ubuntu/SystemSettings/SecurityPrivacy/plugin.h (+1/-1) tests/mocks/Ubuntu/Telephony/MockCallEntry.h (+1/-1) tests/mocks/Ubuntu/Telephony/plugin.h (+2/-2) tests/mocks/Unity/Application/ObjectListModel.h (+1/-1) tests/mocks/Unity/Application/plugin.h (+2/-2) tests/mocks/Unity/Connectivity/plugin.h (+1/-1) tests/mocks/Unity/DashCommunicator/plugin.h (+1/-1) tests/mocks/Unity/Indicators/fakeindicatorsmodel.h (+5/-5) tests/mocks/Unity/Indicators/fakeplugin.h (+1/-1) tests/mocks/Unity/Launcher/MockLauncherItem.h (+2/-2) tests/mocks/Unity/Launcher/MockLauncherModel.h (+12/-12) tests/mocks/Unity/Launcher/MockQuickListModel.h (+2/-2) tests/mocks/Unity/Launcher/plugin.h (+1/-1) tests/mocks/Unity/Notifications/MockActionModel.h (+3/-3) tests/mocks/Unity/Notifications/MockNotificationModel.h (+3/-3) tests/mocks/Unity/Notifications/plugin.h (+1/-1) tests/mocks/Unity/fake_scopes.h (+2/-2) tests/mocks/Unity/fake_unity_plugin.h (+1/-1) tests/mocks/Wizard/mockplugin.h (+1/-1) tests/plugins/Dash/horizontaljournaltest.cpp (+3/-3) tests/plugins/Dash/horizontaljournaltry.cpp (+1/-1) tests/plugins/Dash/listviewwithpageheadersectionexternalmodeltest.cpp (+3/-3) tests/plugins/Dash/organicgridtest.cpp (+2/-2) tests/plugins/Dash/organicgridtry.cpp (+2/-2) tests/plugins/Dash/verticaljournaltest.cpp (+3/-3) tests/plugins/Dash/verticaljournaltry.cpp (+1/-1) tests/plugins/Ubuntu/Gestures/tst_AxisVelocityCalculator.cpp (+1/-1) tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp (+1/-1) tests/plugins/Ubuntu/Gestures/tst_PressedOutsideNotifier.cpp (+1/-1) tests/plugins/Unity/Indicators/menucontentactivatortest.cpp (+2/-2) tests/plugins/Unity/Launcher/launchermodeltest.cpp (+21/-21) tests/plugins/Utils/qlimitproxymodeltest.cpp (+5/-5) tests/plugins/Utils/unitysortfilterproxymodeltest.cpp (+5/-5) tests/utils/modules/Unity/Test/plugin.h (+1/-1) |
| To merge this branch: | bzr merge lp:~aacid/unity8/add_override |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gerry Boland | 2015-04-30 | Approve on 2015-04-30 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-04-30 | |
|
Review via email:
|
|||
Commit Message
Add overrides to override functions
clang-modernize-3.6 -p=builddir -include=. -add-override
Description of the Change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes, builds
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
- 1755. By Launchpad Translations on behalf of unity-team on 2015-05-02
-
Launchpad automatic translations update.
- 1756. By Launchpad Translations on behalf of unity-team on 2015-05-03
-
Launchpad automatic translations update.
- 1757. By Launchpad Translations on behalf of unity-team on 2015-05-05
-
Launchpad automatic translations update.
- 1758. By Daniel d'Andrada on 2015-05-05
-
DirectionalDrag
Area: improvements & API grooming -Simplified DirectionalDragArea gesture recognition
* The widening angle property was dropped. Didn't really work
as in real life swipes might start up in very different directions
before finally turning to the final overall direction. That's specially
bad when you have to conclude the recognition in a short amount
of time so that you can still play animations to follow the user's finger
* minSpeed as well. Went for a simpler way of expressing and evaluating it
which is having maxTime and maxDistance.-EdgeDragArea got absorbed by DirectionalDragArea
-Privatized all gesture recognition parameters.
-Privatized DirectionalDrag
Area.status property. All apps need is
DirectionalDragArea.dragging. Modified qml code using DDA accordingly. -Modified DirectionalDrag
Area.dragging semantics a bit. It goes to true only
once a gesture is recognized-Moved code that smooths out touch movement into DirectionalDragArea so all users
get it for free.-Cleaned up DirectionalDrag
Area.h of all implementation details, getting it ready
to be moved out of unity8, into the SDK.-Removed DirectionalDrag
Area.tapped( ) signal as it doesn't belong to it. -Fine-tuned gesture recognition parameters and made them based on physical size.
-Added tests with input from real gestures to catch those annoying
false-negatives and false-positives introduced by badly set recognition parameters-Improved debug output
-UnownedTouchEvents are no longer sent to interim owners
-Fixed issue when TouchGate got disabled while holding an active touch
-Made "make tryDirectionalD
ragArea" and "make tryDragHandle" work with mouse again. Fixes: #1417920
Approved by: Michael Zanetti, Albert Astals Cid - 1759. By Daniel d'Andrada on 2015-05-05
-
Fix EdgeDragEvaluator when a drag can happen both ways (Direction.
Horizontal)
Approved by: Albert Astals Cid - 1760. By Josh Arenson on 2015-05-05
-
Remove panelHeight property as it is unused.
Approved by: Albert Astals Cid - 1761. By Michał Sawicz on 2015-05-05
-
UNITY_SCOPES_LIST is no more
Approved by: Pawel Stolowski, Albert Astals Cid - 1762. By Leo Arias on 2015-05-05
-
Initial clean up of the autopilot tests set up.
- Removed the touch device from the test case.
- Moved the restart of unity to a fixture.
- Removed the unused DragMixin.
- Updated the setUpClass to use process_helpers.
- Removed the workaround for bug #1238417, already fixed.
- Use the toolkit helper to set the testability environment variable.
- Fixed the indicators base class that was restarting unity twice. Fixes: #1447206
Approved by: Albert Astals Cid - 1763. By handsome_feng on 2015-05-05
-
When click the favorite scope in Dash Manager , it just return to the corresponding scope page. Fixes: #1447056
Approved by: Pawel Stolowski, Albert Astals Cid - 1764. By Leo Arias on 2015-05-05
-
Use the base class from the toolkit in autopilot tests.
Approved by: Albert Astals Cid, Christopher Lee - 1765. By Michael Zanetti on 2015-05-05
-
emit application-stop when we're going down Fixes: #1326513
Approved by: Albert Astals Cid - 1766. By Albert Astals Cid on 2015-05-05
-
Make runtests fake a test error if make fails
This means that we will have 2 errors if there is a test that is run and fails, which is sub-optimal, but at least we'll have also a failure if the test doesn't fail because it was not run for example (i.e. missing dbus-launch).
Approved by: Michael Zanetti - 1767. By Albert Astals Cid on 2015-05-05
-
Use dbus-test-runner instead of dbus-launch
Since we actually depend on it in the control file
Approved by: Michael Zanetti - 1768. By Albert Astals Cid on 2015-05-05
-
Make the test more stable
The test was unstable because scrolling vs creation time is not always stable so at some point we were scrolling "too fast" and when deciding if the new item is out of viewport or in sometimes it went the other way.
Approved by: Michael Zanetti - 1769. By CI Train Bot Account on 2015-05-05
-
Releasing 8.02+15.
04.20150505- 0ubuntu1 - 1770. By CI Train Bot Account on 2015-05-09
-
Resync trunk.
- 1771. By Launchpad Translations on behalf of unity-team on 2015-05-09
-
Launchpad automatic translations update.
- 1772. By Launchpad Translations on behalf of unity-team on 2015-05-11
-
Launchpad automatic translations update.
- 1773. By Albert Astals Cid on 2015-05-11
-
Workarounds for concierge mode.
Approved by: Pawel Stolowski, Michael Zanetti - 1774. By CI Train Bot Account on 2015-05-11
-
Releasing 8.02+15.
04.20150511- 0ubuntu1 - 1775. By CI Train Bot Account on 2015-05-12
-
Resync trunk.
- 1776. By Launchpad Translations on behalf of unity-team on 2015-05-13
-
Launchpad automatic translations update.
- 1777. By Launchpad Translations on behalf of unity-team on 2015-05-15
-
Launchpad automatic translations update.
- 1778. By Nick Dedekind on 2015-05-18
-
Fixed desktop stage app focus.
Approved by: Daniel d'Andrada - 1779. By Daniel d'Andrada on 2015-05-18
-
Introducing FloatingFlickable
Approved by: Michael Zanetti - 1780. By Michael Terry on 2015-05-18
-
Fix a possible crash in our PAM threading code. (LP: #1425362)
So it was possible for a PAM subthread (which does the actual authenticating) to get mismatched state with the main thread. When this happened (i.e. when the subthread tried to use a pam_handle object that the main thread had already closed), a crash occurs. Like LP: #1425362.
So I've done a few cleanups here:
- Use a cancellable QConcurrent method (::mapped instead of ::run). Being able to cancel the thread is a stronger hammer than just hoping we answer all questions from the thread and it will close itself.
- We now block when the subthread sends a prompt request to the main thread. This makes handling those signals more predictable when we're trying to close the thread.
- We will process events while waiting for the subthread to close, so that we can actually process the above signals in the main thread.I've added a dumb little test that tries to authenticate/
cancel/ authenticate 100 times in quick succession. Without this branch, we'd crash reliably anywhere from attempt 2 to 7. With this branch, we're fine all 100. Fixes: #1425362
Approved by: Albert Astals Cid - 1781. By Michael Terry on 2015-05-18
-
Fix the lockscreen becoming unresponsive after testing an app on the device from QtCreator.
Using the hideGreeter dbus call got unity8 in a state where the greeter would try to call a method on an object that didn't exist at the time. Which meant it early-exited from a method before the greeter got re-enabled. Fixes: #1435364
Approved by: Daniel d'Andrada - 1782. By Albert Astals Cid on 2015-05-18
-
Add overrides to override functions
clang-modernize-3.6 -p=builddir -include=. -add-override
Approved by: Gerry Boland

FAILED: Continuous integration, rev:1753 jenkins. qa.ubuntu. com/job/ unity8- ci/5648/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 2561 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- vivid/811 jenkins. qa.ubuntu. com/job/ unity8- vivid-amd64- ci/813 jenkins. qa.ubuntu. com/job/ unity8- vivid-i386- ci/813 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 2219 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 2559 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 2559/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 20075
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5648/ rebuild
http://